type stringclasses 2
values | source stringclasses 4
values | report stringclasses 1
value | contract stringclasses 1
value | severity stringclasses 3
values | contract_url stringclasses 31
values | findings listlengths 0 0 ⌀ | repo stringclasses 127
values | title stringlengths 4 407 ⌀ | body stringlengths 47 3k ⌀ | url stringlengths 60 86 ⌀ |
|---|---|---|---|---|---|---|---|---|---|---|
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-04-renzo-findings | Users can front-run eigenlayer updates to avoid penalties | # Lines of code
https://github.com/code-423n4/2024-04-renzo/blob/519e518f2d8dec9acf6482b84a181e403070d22d/contracts/Withdraw/WithdrawQueue.sol#L206
# Vulnerability details
Validator balances are updated when [verifyBalanceUpdates()](https://github.com/Layr-Labs/eigenlayer-contracts/blob/v0.2.1-goerli-m2/src/contrac... | https://github.com/code-423n4/2024-04-renzo-findings/issues/442 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-04-renzo-findings | A Malicious ezETH holder can unfairly avoid the loss due to validator penalties or slashing by sandwiching eigenlayer updates | # Lines of code
https://github.com/Layr-Labs/eigenlayer-contracts/blob/ef2ea4a7459884f381057aa9bbcd29c7148cfb63/src/contracts/pods/EigenPod.sol#L188-L224
https://github.com/Layr-Labs/eigenlayer-contracts/blob/ef2ea4a7459884f381057aa9bbcd29c7148cfb63/src/contracts/pods/EigenPod.sol#L235-L280
https://github.com/code-423... | https://github.com/code-423n4/2024-04-renzo-findings/issues/441 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-04-renzo-findings | Users can circumvent slashing penalties by front-running EigenLayer updates | # Lines of code
https://github.com/code-423n4/2024-04-renzo/blob/519e518f2d8dec9acf6482b84a181e403070d22d/contracts/Withdraw/WithdrawQueue.sol#L220-L224
https://github.com/code-423n4/2024-04-renzo/blob/519e518f2d8dec9acf6482b84a181e403070d22d/contracts/Withdraw/WithdrawQueue.sol#L242-L249
# Vulnerability details
#... | https://github.com/code-423n4/2024-04-renzo-findings/issues/440 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-04-renzo-findings | Protocol allows stakers to sidestep and avoid validator penalties/slashing | # Lines of code
https://github.com/code-423n4/2024-04-renzo/blob/1c7cc4e632564349b204b4b5e5f494c9b0bc631d/contracts/Withdraw/WithdrawQueue.sol#L206-L263
https://github.com/code-423n4/2024-04-renzo/blob/1c7cc4e632564349b204b4b5e5f494c9b0bc631d/contracts/Withdraw/WithdrawQueue.sol#L206-L263
# Vulnerability details
#... | https://github.com/code-423n4/2024-04-renzo-findings/issues/439 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-superposition-findings | Incorrect underflow handling in `tick::get_fee_growth_inside()` may prevent position modifications | # Lines of code
https://github.com/code-423n4/2024-08-superposition/blob/4528c9d2dbe1550d2660dac903a8246076044905/pkg/seawater/src/tick.rs#L125-L246
# Vulnerability details
## Impact
`tick::get_fee_growth_inside()` can revert in certain situations due to not handling underflows correctly. As a result, some ... | https://github.com/code-423n4/2024-08-superposition-findings/issues/173 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-superposition-findings | update_emergency_council_7_D_0_C_1_C_58() updates nft manager instead of emergency council | # Lines of code
https://github.com/code-423n4/2024-08-superposition/blob/main/pkg/seawater/src/lib.rs#L1121
# Vulnerability details
## Impact
Inside of `lib.rs`, there is a function `update_emergency_council_7_D_0_C_1_C_58()` that is needed to update the emergency council that can disable the pools. However, in th... | https://github.com/code-423n4/2024-08-superposition-findings/issues/162 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-superposition-findings | Unrevoked approvals allow NFT recovery by previous owner | # Lines of code
https://github.com/code-423n4/2024-08-superposition/blob/main/pkg/sol/OwnershipNFTs.sol#L98-L107
# Vulnerability details
## Impact
The vulnerability arises from the fact that after a token transfer, the approval status for the token is not revoked. Specifically, the `getApproved[_tokenId]` is not up... | https://github.com/code-423n4/2024-08-superposition-findings/issues/160 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-superposition-findings | Missing clear token approval when the NFT is transferred. | # Lines of code
https://github.com/code-423n4/2024-08-superposition/blob/4528c9d2dbe1550d2660dac903a8246076044905/pkg/sol/OwnershipNFTs.sol#L98-L107
# Vulnerability details
## Impact
When one NFT is transferred, the NFT token's `getApproved` still take effect. This will cause the previous NFT token approval can sti... | https://github.com/code-423n4/2024-08-superposition-findings/issues/156 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-superposition-findings | Incorrect implementation of `updateEmergencyCouncil` | # Lines of code
https://github.com/code-423n4/2024-08-superposition/blob/4528c9d2dbe1550d2660dac903a8246076044905/pkg/seawater/src/lib.rs#L1109-L1124
# Vulnerability details
## Impact
The `emergency_council` address can never be updated once set
## Vulnerability Details
It appears that this issue is caused by a c... | https://github.com/code-423n4/2024-08-superposition-findings/issues/153 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-superposition-findings | Protocol fees can't be collected due to implementation error | # Lines of code
https://github.com/code-423n4/2024-08-superposition/blob/4528c9d2dbe1550d2660dac903a8246076044905/pkg/seawater/src/lib.rs#L1149-L1150
# Vulnerability details
## Impact
Protocol fees can't be collected
## Vulnerability Details
The current implementation contains a function, `collect_protocol`, whic... | https://github.com/code-423n4/2024-08-superposition-findings/issues/152 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-superposition-findings | Fees calculations don’t allow overflowing/underflowing | # Lines of code
https://github.com/code-423n4/2024-08-superposition/blob/4528c9d2dbe1550d2660dac903a8246076044905/pkg/seawater/src/tick.rs#L236-L245
# Vulnerability details
## Impact
`update_position`-related transactions may revert in some situations.
## Vulnerability Details
In the `get_fee_growth_inside` func... | https://github.com/code-423n4/2024-08-superposition-findings/issues/151 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-superposition-findings | Missing `lower<upper` check in `mint_position` | # Lines of code
https://github.com/code-423n4/2024-08-superposition/blob/29726230b13f1cf36c925d732d3eca459af1aff5/pkg/seawater/src/lib.rs#L506-L513
# Vulnerability details
## Details
The current implementation does not perform a check for `lower < upper` during `mint_position`, while many other functions assume `l... | https://github.com/code-423n4/2024-08-superposition-findings/issues/149 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-superposition-findings | An emergency council update will be impossible and results in a wrong state | # Lines of code
https://github.com/code-423n4/2024-08-superposition/blob/main/pkg/seawater/src/lib.rs#L1121
# Vulnerability details
## Impact
The `emergency_council` role should be mutable, but the setter function is wrongly implemented; thus it's impossible to change it after initialization.
Moreover, the new man... | https://github.com/code-423n4/2024-08-superposition-findings/issues/145 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-superposition-findings | Position's owed fees should allow underflow but it reverts instead, resulting in locked funds | # Lines of code
https://github.com/code-423n4/2024-08-superposition/blob/4528c9d2dbe1550d2660dac903a8246076044905/pkg/seawater/src/position.rs#L52-L66
# Vulnerability details
## Impact
The math used to calculate how many fees are owed to the user does not allow underflows, but this is a necessary due to how the Uni... | https://github.com/code-423n4/2024-08-superposition-findings/issues/143 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-superposition-findings | Position's fee growth can revert resulting in funds permanently locked | # Lines of code
https://github.com/code-423n4/2024-08-superposition/blob/4528c9d2dbe1550d2660dac903a8246076044905/pkg/seawater/src/tick.rs#L125-L246
# Vulnerability details
## Impact
To determine the fee growth for a position, a function similar to the one used by Uniswap V3 is used. The new logic differs from the ... | https://github.com/code-423n4/2024-08-superposition-findings/issues/142 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-superposition-findings | Token approvals are not revoked upon transfer which can cause position theft | # Lines of code
https://github.com/code-423n4/2024-08-superposition/blob/4528c9d2dbe1550d2660dac903a8246076044905/pkg/sol/OwnershipNFTs.sol#L109
# Vulnerability details
### Impact
Transferring the tokens from one user to the other doesn't revoke the token's approval which opens up the NFT to various attacks by the... | https://github.com/code-423n4/2024-08-superposition-findings/issues/141 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-superposition-findings | Incorrectly assigned roles when updating emergency council | # Lines of code
https://github.com/code-423n4/2024-08-superposition/blob/4528c9d2dbe1550d2660dac903a8246076044905/pkg/seawater/src/lib.rs#L1121
# Vulnerability details
### Impact
Emergency council cannot be updated if need be and NFTManager contract is replaced, potentially dossing all processes that occur from it... | https://github.com/code-423n4/2024-08-superposition-findings/issues/137 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-superposition-findings | Use of checked arithmetic when handling fee growth | # Lines of code
https://github.com/code-423n4/2024-08-superposition/blob/4528c9d2dbe1550d2660dac903a8246076044905/pkg/seawater/src/position.rs#L52-L66
https://github.com/code-423n4/2024-08-superposition/blob/4528c9d2dbe1550d2660dac903a8246076044905/pkg/seawater/src/tick.rs#L162-L169
https://github.com/code-423n4/2024-... | https://github.com/code-423n4/2024-08-superposition-findings/issues/136 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-superposition-findings | Emergency council update function incorrectly updates `nft_manager` instead of `emergency_council` | # Lines of code
https://github.com/code-423n4/2024-08-superposition/blob/4528c9d2dbe1550d2660dac903a8246076044905/pkg/seawater/src/lib.rs#L1110-L1124
# Vulnerability details
## Impact
The `update_emergency_council_7_D_0_C_1_C_58` function is intended to update the `emergency_council` field, but it mistakenly update... | https://github.com/code-423n4/2024-08-superposition-findings/issues/134 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-superposition-findings | Incorrect Update of NFT Manager in Update Emergency Council Function | # Lines of code
https://github.com/code-423n4/2024-08-superposition/blob/main/pkg/seawater/src/lib.rs#L1121
# Vulnerability details
In the `update_emergency_council_7_D_0_C_1_C_58` function, there is an incorrect update where the **NFT manager (self.nft_manager)** is being set instead of the **emergency council**. ... | https://github.com/code-423n4/2024-08-superposition-findings/issues/132 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-superposition-findings | The update_emergency_council function updates the NFT Manager | # Lines of code
https://github.com/code-423n4/2024-08-superposition/blob/4528c9d2dbe1550d2660dac903a8246076044905/pkg/seawater/src/lib.rs#L1111-L1124
# Vulnerability details
## Impact
When a user calls update_emergency_council it actually updates the nft manager.
## Proof of Concept
The parameter that the function... | https://github.com/code-423n4/2024-08-superposition-findings/issues/128 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-superposition-findings | Missing lower tick < upper tick check | # Lines of code
https://github.com/code-423n4/2024-08-superposition/blob/main/pkg/seawater/src/pool.rs#L75
# Vulnerability details
## Impact
In `pool.rs`, when creating a new position, the ticks are insufficiently validated which can lead to an unexpected behavior as the lower tick cannot be bigger than the upper ... | https://github.com/code-423n4/2024-08-superposition-findings/issues/125 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-superposition-findings | The StoragePositions new function doesn't validate low and up parameters as it states it should | # Lines of code
https://github.com/code-423n4/2024-08-superposition/blob/4528c9d2dbe1550d2660dac903a8246076044905/pkg/seawater/src/position.rs#L29-L39
# Vulnerability details
## Impact
Parameters could be passed with swapped places and the function will set them.
## Proof of Concept
The comments suggest that the f... | https://github.com/code-423n4/2024-08-superposition-findings/issues/124 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-superposition-findings | Missing Validation for Tick Bounds in Position Creation | # Lines of code
https://github.com/code-423n4/2024-08-superposition/blob/4528c9d2dbe1550d2660dac903a8246076044905/pkg/seawater/src/pool.rs#L75
# Vulnerability details
## Impact
The `create_position` function within the pool library fails to validate that the low tick is less than the up tick when creating a new po... | https://github.com/code-423n4/2024-08-superposition-findings/issues/122 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-superposition-findings | No Validation of Input Ranges | # Lines of code
https://github.com/code-423n4/2024-08-superposition/blob/4528c9d2dbe1550d2660dac903a8246076044905/pkg/seawater/src/position.rs#L35
# Vulnerability details
The "new" function initializes a position with low and up bounds but does not validate the input values to ensure that low is less than up or tha... | https://github.com/code-423n4/2024-08-superposition-findings/issues/121 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-superposition-findings | fee_growth_inside calculations doesnt allow oveflow/underflow | # Lines of code
https://github.com/code-423n4/2024-08-superposition/blob/4528c9d2dbe1550d2660dac903a8246076044905/pkg/seawater/src/tick.rs#L163
# Vulnerability details
## Impact
The get_fee_growth_inside function uses checked_sub to prevent overflow and underflow in fee growth calculations. However, the original U... | https://github.com/code-423n4/2024-08-superposition-findings/issues/118 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-superposition-findings | tick.rs does not allow for fees to under/overflow, as it is supposed to be | # Lines of code
https://github.com/code-423n4/2024-08-superposition/blob/4528c9d2dbe1550d2660dac903a8246076044905/pkg/seawater/src/tick.rs#L163-L169
# Vulnerability details
## Impact
Fees will be incorrectly calculated.
## Proof of Concept
In the original UniswapV3 Tick.sol, it uses a version of solidity that al... | https://github.com/code-423n4/2024-08-superposition-findings/issues/111 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-superposition-findings | Incorrect Tick Validation in create_position Function | # Lines of code
https://github.com/code-423n4/2024-08-superposition/blob/4528c9d2dbe1550d2660dac903a8246076044905/pkg/seawater/src/pool.rs#L75-L87
# Vulnerability details
## Impact
The current implementation allows for the creation of positions with invalid tick ranges, potentially leading to logical errors in pool... | https://github.com/code-423n4/2024-08-superposition-findings/issues/106 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-superposition-findings | Incorrect Tick Order in Position Creation Allows Protocol Accounting Manipulation | # Lines of code
https://github.com/code-423n4/2024-08-superposition/blob/4528c9d2dbe1550d2660dac903a8246076044905/pkg/seawater/src/pool.rs#L75
# Vulnerability details
The function `create_position` which is responsible for creating new liquidity positions within the AMM, fails to validate the order of the lower an... | https://github.com/code-423n4/2024-08-superposition-findings/issues/105 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-superposition-findings | Unauthorized NFT reclaiming due to uncleared approvals | # Lines of code
https://github.com/code-423n4/2024-08-superposition/blob/4528c9d2dbe1550d2660dac903a8246076044905/pkg/sol/OwnershipNFTs.sol#L162
https://github.com/code-423n4/2024-08-superposition/blob/4528c9d2dbe1550d2660dac903a8246076044905/pkg/sol/OwnershipNFTs.sol#L109
# Vulnerability details
The `OwnershipNFTs... | https://github.com/code-423n4/2024-08-superposition-findings/issues/104 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-superposition-findings | Emergency Council Update Function Incorrectly Modifies NFT Manager | # Lines of code
https://github.com/code-423n4/2024-08-superposition/blob/4528c9d2dbe1550d2660dac903a8246076044905/pkg/seawater/src/lib.rs#L1121
# Vulnerability details
The `update_emergency_council_7_D_0_C_1_C_58()` function is intended to update the emergency council address, which is a critical security role. How... | https://github.com/code-423n4/2024-08-superposition-findings/issues/103 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-superposition-findings | `OwnershipNFTs` Users Can Maintain NFT Ownership After a Transfer and Transfer the NFT Back to Themselves | # Lines of code
https://github.com/code-423n4/2024-08-superposition/blob/4528c9d2dbe1550d2660dac903a8246076044905/pkg/sol/OwnershipNFTs.sol#L103
# Vulnerability details
## Impact
`OwnershipNFTs` can transfer an NFT back to themselves due to improper validation. In other words a NFT owner can transfer their NFT to s... | https://github.com/code-423n4/2024-08-superposition-findings/issues/100 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-superposition-findings | Incorrect Parameter in `collect_protocol_7540_F_A_9_F` Method of `lib.rs` Causes Token Transfer Failure when Collecting Protocol Fees | # Lines of code
https://github.com/code-423n4/2024-08-superposition/blob/4528c9d2dbe1550d2660dac903a8246076044905/pkg/seawater/src/lib.rs#L1149-L1150
https://github.com/code-423n4/2024-08-superposition/blob/4528c9d2dbe1550d2660dac903a8246076044905/pkg/seawater/src/wasm_erc20.rs#L158
# Vulnerability details
## Impac... | https://github.com/code-423n4/2024-08-superposition-findings/issues/99 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-superposition-findings | Seller can steal back the nft from buyer | # Lines of code
https://github.com/code-423n4/2024-08-superposition/blob/main/pkg/sol/OwnershipNFTs.sol#L109-L116
# Vulnerability details
User can sell/transfer nft to a buyer.
However it is possible for the user to steal back the nft from the buyer because the approvals are not deleted/removed after transfer.
##... | https://github.com/code-423n4/2024-08-superposition-findings/issues/93 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-phi-findings | Upgraded Q -> 3 from #332 [1726856796021] | Judge has assessed an item in Issue #332 as 3 risk. The relevant finding follows:
[L-17] Consider introducing a rate limit as to how often mintFee and soulBounded values can be changed.
Artist has the power to increase fees by frontrunning certain users. This could be used to favour some users over the others by cha... | https://github.com/code-423n4/2024-08-phi-findings/issues/379 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-phi-findings | Upgraded Q -> 3 from #48 [1726245912184] | Judge has assessed an item in Issue #48 as 3 risk. The relevant finding follows:
[03] Allowing art’s properties like startTime, endTime, and soulBounded to be updated through PhiFactory.updateArtSettings function can cause other users’ art claiming and art transfer transactions to be DOS’ed
Description
The PhiFacto... | https://github.com/code-423n4/2024-08-phi-findings/issues/368 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-phi-findings | Cred contract has Unprotected Function _addCredIdPerAddress | # Lines of code
https://github.com/code-423n4/2024-08-phi/blob/8c0985f7a10b231f916a51af5d506dd6b0c54120/src/Cred.sol#L685-L692
# Vulnerability details
## Impact
Detailed description of the impact of this finding.
Cred contract has Unprotected Function _addCredIdPerAddress.
The _addCredIdPerAddress function is mar... | https://github.com/code-423n4/2024-08-phi-findings/issues/318 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-phi-findings | Anyone outside of Phi ecosystem can benefit from rewards | # Lines of code
https://github.com/code-423n4/2024-08-phi/blob/8c0985f7a10b231f916a51af5d506dd6b0c54120/src/reward/CuratorRewardsDistributor.sol#L120
# Vulnerability details
## Impact
`CuratorRewardsDistributor::distribute` is used to distribute the awards to the Cred involved Curators, based on their shares number... | https://github.com/code-423n4/2024-08-phi-findings/issues/316 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-phi-findings | Critical State-Changing Functions Are Marked as Public Instead of Internal or Private | # Lines of code
https://github.com/code-423n4/2024-08-phi/blob/main/src/Cred.sol#L685-L692
https://github.com/code-423n4/2024-08-phi/blob/main/src/Cred.sol#L695-L729
https://github.com/code-423n4/2024-08-phi/blob/main/src/Cred.sol#L666-L682
# Vulnerability details
## Impact
The functions `Cred::_addCredIdPerAddres... | https://github.com/code-423n4/2024-08-phi-findings/issues/314 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-phi-findings | `CuratorRewardsDistributor::distribute` can be DoS-ed, leading to loss of user funds | # Lines of code
https://github.com/code-423n4/2024-08-phi/blob/main/src/reward/CuratorRewardsDistributor.sol#L77-L130
# Vulnerability details
## Impact
If a large amount of users buy shares of the same credential, `CuratorRewardsDistributor::distribute` will hit the block gas limit and rewards will not be transferr... | https://github.com/code-423n4/2024-08-phi-findings/issues/307 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-phi-findings | Lacks of checks in signature inside `createArt` allows other artists without permission to deploy art with their own `CreateConfig` parameters illegally | # Lines of code
https://github.com/code-423n4/2024-08-phi/blob/8c0985f7a10b231f916a51af5d506dd6b0c54120/src/PhiFactory.sol#L196-L213
# Vulnerability details
## Vulnerability Details
```solidity
function createArt(
bytes calldata signedData_,
bytes calldata signature_,
@> CreateConfig memory... | https://github.com/code-423n4/2024-08-phi-findings/issues/306 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-phi-findings | Unauthorized Removal of Credential ID Allows Attacker to Disrupt User CRED Share Management | # Lines of code
https://github.com/code-423n4/2024-08-phi/blob/8c0985f7a10b231f916a51af5d506dd6b0c54120/src/Cred.sol#L695
https://github.com/code-423n4/2024-08-phi/blob/8c0985f7a10b231f916a51af5d506dd6b0c54120/src/Cred.sol#L697
# Vulnerability details
## Impact
A critical access control vulnerability has been ident... | https://github.com/code-423n4/2024-08-phi-findings/issues/305 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-phi-findings | Create art can be frontruned and lead to lose of funds for artist | # Lines of code
https://github.com/code-423n4/2024-08-phi/blob/8c0985f7a10b231f916a51af5d506dd6b0c54120/src/PhiFactory.sol#L191-L213
https://github.com/code-423n4/2024-08-phi/blob/8c0985f7a10b231f916a51af5d506dd6b0c54120/src/PhiFactory.sol#L589-L593
# Vulnerability details
`PhiFactory::createArt` is responsible for... | https://github.com/code-423n4/2024-08-phi-findings/issues/303 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-phi-findings | `signature` can be used by anyone | # Lines of code
https://github.com/code-423n4/2024-08-phi/blob/8c0985f7a10b231f916a51af5d506dd6b0c54120/src/PhiFactory.sol#L589-L593
# Vulnerability details
## Impact
Without sender validation, anyone can use any `signature` and create art as authority is not validated in the function.
## Proof of Concept
[`creat... | https://github.com/code-423n4/2024-08-phi-findings/issues/300 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-phi-findings | Lack of access control in `Cred:_removeCredIdPerAddress` stops user from selling entire share balance. | # Lines of code
https://vscode.dev/github/code-423n4/2024-08-phi/blob/main/src/Cred.sol#L695
# Vulnerability details
## Impact
Lack of access control in `Cred:_removeCredIdPerAddress` allows for a malicious user to remove the credID from an existing user in the `_credIdsPerAddress` mapping. This affects the `_updat... | https://github.com/code-423n4/2024-08-phi-findings/issues/299 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-phi-findings | Malicious artist could lock nfts | # Lines of code
https://github.com/code-423n4/2024-08-phi/blob/8c0985f7a10b231f916a51af5d506dd6b0c54120/src/art/PhiNFT1155.sol#L307-L350
https://github.com/code-423n4/2024-08-phi/blob/8c0985f7a10b231f916a51af5d506dd6b0c54120/src/PhiFactory.sol#L215-L257
# Vulnerability details
Currently, there is a field called `Ph... | https://github.com/code-423n4/2024-08-phi-findings/issues/296 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-phi-findings | Art creators can update royalties to 100% and front-run NFT sales to pocket the whole sale amount. | # Lines of code
https://github.com/code-423n4/2024-08-phi/blob/main/src/PhiFactory.sol#L215-L257
# Vulnerability details
## Impact
Art creators can arbitrarily chose the royalty configuration via the `PhiFactory::updateArtSettings` function, meaning that can listen to the mempool for any sale of NFT that they creat... | https://github.com/code-423n4/2024-08-phi-findings/issues/295 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-phi-findings | Rewards distribution for cred would be blocked if it has too many curators | # Lines of code
https://github.com/code-423n4/2024-08-phi/blob/8c0985f7a10b231f916a51af5d506dd6b0c54120/src/reward/CuratorRewardsDistributor.sol#L84-L118
# Vulnerability details
## Impact
Each credential can have multiple instances (up to 999), so for one `credId`, there could be up to 999 different addresses that ... | https://github.com/code-423n4/2024-08-phi-findings/issues/293 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-phi-findings | A malicious actor can easily add any elements of any user's credIds array making it possible for the getPositionsForCurator() function to revert | # Lines of code
https://github.com/code-423n4/2024-08-phi/blob/8c0985f7a10b231f916a51af5d506dd6b0c54120/src/Cred.sol#L684-L729
# Vulnerability details
## Impact
The `_addCredIdPerAddress()` function have public visibility which allows a malicious actor to update the values of `_credIdsPerAddress`, `_credIdsPerAddre... | https://github.com/code-423n4/2024-08-phi-findings/issues/291 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-phi-findings | A malicious actor can easily substract any elements of any user's credIds array making it impossible for the user to sell his shares | # Lines of code
https://github.com/code-423n4/2024-08-phi/blob/8c0985f7a10b231f916a51af5d506dd6b0c54120/src/Cred.sol#L695
# Vulnerability details
## Impact
The `_removeCredIdPerAddress()` function have public visibility which allows a malicious actor to update the values of `_credIdsPerAddress`, `_credIdsPerAddress... | https://github.com/code-423n4/2024-08-phi-findings/issues/290 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-phi-findings | lack of access control in `CuratorRewardsDistributor:distribute` allows any user to call distrubute and claim ETH dust. | # Lines of code
https://vscode.dev/github/code-423n4/2024-08-phi/blob/main/src/reward/CuratorRewardsDistributor.sol#L77
# Vulnerability details
## Impact
The `distribute` function has no access control allowing for any user to call this function on an active cred.
```solidity
_msgSender().safeTransferETH(royaltyfe... | https://github.com/code-423n4/2024-08-phi-findings/issues/288 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-phi-findings | Wrong function visibility allows anyone to add/remove `credId` from any address's list | # Lines of code
https://github.com/code-423n4/2024-08-phi/blob/8c0985f7a10b231f916a51af5d506dd6b0c54120/src/Cred.sol#L684-L692
https://github.com/code-423n4/2024-08-phi/blob/8c0985f7a10b231f916a51af5d506dd6b0c54120/src/Cred.sol#L694-L729
# Vulnerability details
## Impact
Anyone can call functions `Cred#_addCredIdPe... | https://github.com/code-423n4/2024-08-phi-findings/issues/286 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-phi-findings | Bypass share lock duration to sell Cred share at the first share purchase | # Lines of code
https://github.com/code-423n4/2024-08-phi/blob/8c0985f7a10b231f916a51af5d506dd6b0c54120/src/Cred.sol#L638-L644
https://github.com/code-423n4/2024-08-phi/blob/8c0985f7a10b231f916a51af5d506dd6b0c54120/src/Cred.sol#L570
# Vulnerability details
## Impact
In flow of creating a new Cred, the caller has to... | https://github.com/code-423n4/2024-08-phi-findings/issues/283 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-phi-findings | DoS in `CuratorRewardsDistributor` due to accumulation of curators with 0 shares in `Cred` | # Lines of code
https://github.com/code-423n4/2024-08-phi/blob/8c0985f7a10b231f916a51af5d506dd6b0c54120/src/reward/CuratorRewardsDistributor.sol#L84
https://github.com/code-423n4/2024-08-phi/blob/8c0985f7a10b231f916a51af5d506dd6b0c54120/src/Cred.sol#L666-L682
# Vulnerability details
## Impact
Permanent Denial of S... | https://github.com/code-423n4/2024-08-phi-findings/issues/282 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-phi-findings | Malicious User Can Use flashloan attack to get majority of the PhiRewards | # Lines of code
https://github.com/code-423n4/2024-08-phi/blob/main/src/Cred.sol#L178-L180
https://github.com/code-423n4/2024-08-phi/blob/main/src/Cred.sol#L588-L659
https://github.com/code-423n4/2024-08-phi/blob/main/src/reward/CuratorRewardsDistributor.sol#L77-L131
# Vulnerability details
## Impact
Malicious user... | https://github.com/code-423n4/2024-08-phi-findings/issues/279 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-phi-findings | Frontrunning of reward distribution allows to steal rewards from curators | # Lines of code
https://github.com/code-423n4/2024-08-phi/blob/8c0985f7a10b231f916a51af5d506dd6b0c54120/src/reward/CuratorRewardsDistributor.sol#L68-L75
https://github.com/code-423n4/2024-08-phi/blob/8c0985f7a10b231f916a51af5d506dd6b0c54120/src/reward/CuratorRewardsDistributor.sol#L77-L130
# Vulnerability details
#... | https://github.com/code-423n4/2024-08-phi-findings/issues/278 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-phi-findings | Caller can steal royalty fees and rounding errors in `CuratorRewardsDistributor::distribute()` | # Lines of code
https://github.com/code-423n4/2024-08-phi/blob/8c0985f7a10b231f916a51af5d506dd6b0c54120/src/reward/CuratorRewardsDistributor.sol#L77-L130
# Vulnerability details
## Description
The `CuratorRewardsDistributor` contract is responsible for managing deposits and withdrawals for curator rewards. It int... | https://github.com/code-423n4/2024-08-phi-findings/issues/276 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-phi-findings | Wrong visibility in Cred.sol::_removeCredIdPerAddress() function can prevent users to sell their shares | # Lines of code
https://github.com/code-423n4/2024-08-phi/blob/main/src/Cred.sol#L685-L729
# Vulnerability details
The functions `_removeCredIdPerAddress()` and `_addCredIdPerAddress()` are publicly accessible, allowing users to modify the `_credIdsPerAddress` list with arbitrary `credId_` and `sender_` values. Thi... | https://github.com/code-423n4/2024-08-phi-findings/issues/275 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-phi-findings | The SHARE_LOCK_PERIOD check can be bypassed by `re-entrancy` vulnerability in the function `_handleTrade` | # Lines of code
https://github.com/code-423n4/2024-08-phi/blob/main/src/Cred.sol#L642
# Vulnerability details
## Vulnerability Detail
In the `_handleTrade` function, the state variable `lastTradeTimestamp[credId_][curator_]` is updated after the `safeTransferETH` function which sends ETH to `msg.sender` when `exce... | https://github.com/code-423n4/2024-08-phi-findings/issues/274 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-phi-findings | Failure to restrict royalties in `CreatorRoyaltiesControl` may result in large losses for users | # Lines of code
https://github.com/code-423n4/2024-08-phi/blob/8c0985f7a10b231f916a51af5d506dd6b0c54120/src/abstract/CreatorRoyaltiesControl.sol#L58-L66
# Vulnerability details
## Impact
Arbitrary royalty can be set by the creator for their art, e.g. 500%, leading to potentially large losses for users.
## Summary... | https://github.com/code-423n4/2024-08-phi-findings/issues/273 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-phi-findings | Malicious Actors Can Prevent Share Sales in Cred Contract | # Lines of code
https://github.com/code-423n4/2024-08-phi/blob/8c0985f7a10b231f916a51af5d506dd6b0c54120/src/Cred.sol#L695
# Vulnerability details
## Impact
The vulnerability in the Cred contract allows malicious actors to manipulate the selling mechanism of Signals (shares), leading to several severe consequences:
... | https://github.com/code-423n4/2024-08-phi-findings/issues/270 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-phi-findings | Reentrancy on `Cred::_createCredInternal` allow cred creator to frontrun early share | # Lines of code
https://github.com/code-423n4/2024-08-phi/blob/8c0985f7a10b231f916a51af5d506dd6b0c54120/src/Cred.sol#L570-L574
# Vulnerability details
## Impact
Calling `Cred::createCred` function will call the `_createCredInternal` function where the reentrancy can happen. This allow cred creator to buy multiple ... | https://github.com/code-423n4/2024-08-phi-findings/issues/269 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-phi-findings | Reward distribution is still vulnerable to flash loan attacks | # Lines of code
https://github.com/code-423n4/2024-08-phi/blob/8c0985f7a10b231f916a51af5d506dd6b0c54120/src/Cred.sol#L644
https://github.com/code-423n4/2024-08-phi/blob/8c0985f7a10b231f916a51af5d506dd6b0c54120/src/reward/CuratorRewardsDistributor.sol#L77
# Vulnerability details
## Impact
While a previous audit con... | https://github.com/code-423n4/2024-08-phi-findings/issues/266 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-phi-findings | `PhiFactory::createArt()` is vulnerable to replay attacks due to insufficient validation. | # Lines of code
https://github.com/code-423n4/2024-08-phi/blob/8c0985f7a10b231f916a51af5d506dd6b0c54120/src/PhiFactory.sol#L191-L213
https://github.com/code-423n4/2024-08-phi/blob/8c0985f7a10b231f916a51af5d506dd6b0c54120/src/PhiFactory.sol#L589-L593
# Vulnerability details
The `PhiFactory::createArt()` function is ... | https://github.com/code-423n4/2024-08-phi-findings/issues/265 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-07-reserve-findings | Reentrancy Vulnerability in bidWithCallback(bytes) in the DutchTrade contract | # Lines of code
https://github.com/code-423n4/2024-07-reserve/blob/3f133997e186465f4904553b0f8e86ecb7bbacbf/contracts/plugins/trading/DutchTrade.sol#L235-L269
# Vulnerability details
## Impact
Detailed description of the impact of this finding.
Reentrancy Vulnerability in bidWithCallback(bytes) in the DutchTrade c... | https://github.com/code-423n4/2024-07-reserve-findings/issues/115 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-07-reserve-findings | Critical Bug in prepareTradeToCoverDeficit Function Causing Zero Sell Amount in TradeLib Contract | # Lines of code
https://github.com/reserve-protocol/protocol/blob/4.0.0/contracts/p1/mixins/TradeLib.sol#L148
# Vulnerability details
## Impact
Based on the provided echidna logs there is an issue within the TradeLib contract the prepareTradeToCoverDeficit function. Specifically, the Exact Sell Amount and Request S... | https://github.com/code-423n4/2024-07-reserve-findings/issues/114 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-07-reserve-findings | Reentrancy in RToken may lead to complete loss of funds | # Lines of code
https://github.com/code-423n4/2024-07-reserve/blob/main/contracts/p1/RToken.sol#L105-L155
https://github.com/code-423n4/2024-07-reserve/blob/main/contracts/p1/RToken.sol#L397-L414
# Vulnerability details
## Impact
There’s a reentrancy vulnerability inside the `RToken` contract. Currently, deployed ... | https://github.com/code-423n4/2024-07-reserve-findings/issues/102 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-07-reserve-findings | Delegation to the `zero address` can lead to permanent loss of the user's voting power | # Lines of code
https://github.com/code-423n4/2024-07-reserve/blob/3f133997e186465f4904553b0f8e86ecb7bbacbf/contracts/p1/StRSRVotes.sol#L166-L183
https://github.com/code-423n4/2024-07-reserve/blob/3f133997e186465f4904553b0f8e86ecb7bbacbf/contracts/p1/StRSRVotes.sol#L230-L254
https://github.com/code-423n4/2024-07-reser... | https://github.com/code-423n4/2024-07-reserve-findings/issues/98 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-07-reserve-findings | delegateBySig() does not validate the delegatee address, malicious user can lock other user's NFT(funds) | # Lines of code
https://github.com/code-423n4/2024-07-reserve/blob/main/contracts/p1/StRSRVotes.sol#L162
https://github.com/code-423n4/2024-07-reserve/blob/main/contracts/p1/StRSRVotes.sol#L166
# Vulnerability details
## Impact
function delegateBySig doesn't cover case when delegatee = address(0), malicious users c... | https://github.com/code-423n4/2024-07-reserve-findings/issues/93 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-07-reserve-findings | Attacker can manipulate auction outcome by exploiting rounding in clearingPrice calculation (`GnosisTrade::settle`) | # Lines of code
https://github.com/code-423n4/2024-07-reserve/blob/3f133997e186465f4904553b0f8e86ecb7bbacbf/contracts/plugins/trading/GnosisTrade.sol#L175-L221
# Vulnerability details
## Description
The `GnosisTrade` contract facilitates trades using the Gnosis EasyAuction mechanism. The [`settle()` function](http... | https://github.com/code-423n4/2024-07-reserve-findings/issues/88 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-07-reserve-findings | BackingManager can seize more RSR than intended due to calculation error (`StRSRP1::seizeRSR()`) | # Lines of code
https://github.com/code-423n4/2024-07-reserve/blob/3f133997e186465f4904553b0f8e86ecb7bbacbf/contracts/p1/StRSR.sol#L424-L479
# Vulnerability details
## Description
The `StRSRP1` contract contains a critical vulnerability in its [`seizeRSR()` function](https://github.com/code-423n4/2024-07-reserve/b... | https://github.com/code-423n4/2024-07-reserve-findings/issues/87 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-07-reserve-findings | Malicious users can extract excess RSR due to incorrect rate calculations (`StRSRP1::unstake` and `StRSRP1::withdraw`) | # Lines of code
https://github.com/code-423n4/2024-07-reserve/blob/3f133997e186465f4904553b0f8e86ecb7bbacbf/contracts/p1/StRSR.sol#L259-L281
https://github.com/code-423n4/2024-07-reserve/blob/3f133997e186465f4904553b0f8e86ecb7bbacbf/contracts/p1/StRSR.sol#L640-L664
https://github.com/code-423n4/2024-07-reserve/blob/3f... | https://github.com/code-423n4/2024-07-reserve-findings/issues/86 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-07-reserve-findings | Exchange rate calculation exploit via Stake/Unstake | # Lines of code
https://github.com/code-423n4/2024-07-reserve/blob/main/contracts/p1/StRSR.sol#L304
# Vulnerability details
## Impact
I found a bug in the [StRSR.sol](https://github.com/code-423n4/2024-07-reserve/blob/main/contracts/p1/StRSR.sol)
currently it allows for an attacker to exploit the stake/unstake mec... | https://github.com/code-423n4/2024-07-reserve-findings/issues/85 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-07-reserve-findings | Incorrect Balance Update in `FurnaceP1::melt()` Will Lead to Reduced RToken Melting Over Time | # Lines of code
https://github.com/code-423n4/2024-07-reserve/blob/3f133997e186465f4904553b0f8e86ecb7bbacbf/contracts/p1/Furnace.sol#L65-L79
# Vulnerability details
## Description
The `FurnaceP1` contract implements a mechanism to continuously melt RTokens based on a predefined ratio and elapsed time. The [`melt(... | https://github.com/code-423n4/2024-07-reserve-findings/issues/82 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-07-reserve-findings | Users will be unable to redeem tokens when unregistered assets exist in old baskets (`RTokenP1::redeemCustom`) | # Lines of code
https://github.com/code-423n4/2024-07-reserve/blob/3f133997e186465f4904553b0f8e86ecb7bbacbf/contracts/p1/RToken.sol#L253-L345
# Vulnerability details
## Description
The `RTokenP1` contract implements a [`redeemCustom()` function ](https://github.com/code-423n4/2024-07-reserve/blob/3f133997e186465f4... | https://github.com/code-423n4/2024-07-reserve-findings/issues/80 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-07-reserve-findings | Hyperinflation of RSR tokens during withdrawal | # Lines of code
https://github.com/code-423n4/2024-07-reserve/blob/main/contracts/p1/StRSR.sol#L304
# Vulnerability details
## Where is bug
Located in [withdraw()](https://github.com/code-423n4/2024-07-reserve/blob/main/contracts/p1/StRSR.sol#L304) of [StRSRP.sol](https://github.com/code-423n4/2024-07-reserve/blob... | https://github.com/code-423n4/2024-07-reserve-findings/issues/79 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-07-reserve-findings | Unexpected loss of funds due to missing of the return value check | # Lines of code
https://github.com/code-423n4/2024-07-reserve/blob/main/contracts/p1/RToken.sol#L105-L155
https://github.com/code-423n4/2024-07-reserve/blob/main/contracts/p1/RToken.sol#L183-L225
https://github.com/code-423n4/2024-07-reserve/blob/main/contracts/p1/RToken.sol#L253-L344
# Vulnerability details
## Imp... | https://github.com/code-423n4/2024-07-reserve-findings/issues/76 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-07-reserve-findings | The Loss of Fund of the protocol due to Incorrect Boundary Check of Loop | # Lines of code
https://github.com/code-423n4/2024-07-reserve/blob/main/contracts/p1/BasketHandler.sol#L521-L600
# Vulnerability details
## Impact
Protocol funds can be lost due to incorrect bounds checking on the loop variable in the `BasketHandler.sol#quoteCustomRedemption()` function.
## Proof of Concept
The `... | https://github.com/code-423n4/2024-07-reserve-findings/issues/75 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-07-reserve-findings | Potential Manipulation of Draft RSR During Mass Unstaking Events | # Lines of code
https://github.com/code-423n4/2024-07-reserve/blob/3f133997e186465f4904553b0f8e86ecb7bbacbf/contracts/p1/StRSR.sol#L614-L623
https://github.com/code-423n4/2024-07-reserve/blob/3f133997e186465f4904553b0f8e86ecb7bbacbf/contracts/p1/StRSR.sol#L490-L499
https://github.com/code-423n4/2024-07-reserve/blob/3f... | https://github.com/code-423n4/2024-07-reserve-findings/issues/73 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-07-reserve-findings | First depositer in rToken can ensure that second always suffers a loss of funds | # Lines of code
https://github.com/code-423n4/2024-07-reserve/blob/3f133997e186465f4904553b0f8e86ecb7bbacbf/contracts/p1/Furnace.sol#L65-L79
https://github.com/code-423n4/2024-07-reserve/blob/3f133997e186465f4904553b0f8e86ecb7bbacbf/contracts/p1/RToken.sol#L133-L143
# Vulnerability details
## Impact
If there is "e... | https://github.com/code-423n4/2024-07-reserve-findings/issues/70 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-07-reserve-findings | in `BackingManagerP1::rebalance` Wrong assertion will lead to panic reverts | # Lines of code
https://github.com/code-423n4/2024-07-reserve/blob/3f133997e186465f4904553b0f8e86ecb7bbacbf/contracts/p1/mixins/RecollateralizationLib.sol#L75
# Vulnerability details
## Impact
- unintended behavior (`compromiseBasketsNeeded` would never be called), and the RToken state would stay undercollateralize... | https://github.com/code-423n4/2024-07-reserve-findings/issues/69 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-07-reserve-findings | `rsrRewardsAtLastPayout` is incorrectly updated to a smaller value in `seizeRSR`. | # Lines of code
https://github.com/code-423n4/2024-07-reserve/blob/main/contracts/p1/StRSR.sol#L471-L473
# Vulnerability details
## Impact
`rsrRewardsAtLastPayout` is incorrectly updated to a smaller value in `seizeRSR`. This results in the staker pool receiving less rewards in subsequent reward payouts than expect... | https://github.com/code-423n4/2024-07-reserve-findings/issues/67 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-07-reserve-findings | The discrepency in `issuancePremium` accounting, during the `issuance of RTokens` and the `available basket units` calculation in the `BackingManager`, could lead to an `incorrect assessment` of the `collateralization status` | # Lines of code
https://github.com/code-423n4/2024-07-reserve/blob/main/contracts/p1/RToken.sol#L139-L143
https://github.com/code-423n4/2024-07-reserve/blob/main/contracts/p1/BasketHandler.sol#L499-L504
https://github.com/code-423n4/2024-07-reserve/blob/main/contracts/p1/BackingManager.sol#L124
https://github.com/code... | https://github.com/code-423n4/2024-07-reserve-findings/issues/59 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-07-reserve-findings | Custom Redemption Vulnerability in Reserve Protocol Allows Value Extraction | # Lines of code
https://github.com/reserve-protocol/protocol/blob/c4ec2473bbcb4831d62af55d275368e73e16b984/contracts/p1/RToken.sol#L245-L338
https://github.com/reserve-protocol/protocol/blob/c4ec2473bbcb4831d62af55d275368e73e16b984/contracts/p1/BasketHandler.sol#L437-L440
# Vulnerability details
## Impact
The custo... | https://github.com/code-423n4/2024-07-reserve-findings/issues/56 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-07-reserve-findings | Calling beginEra() in the StRSR initializer will incorrectly reset state variables | # Lines of code
https://github.com/reserve-protocol/protocol/blob/master/contracts/p1/StRSR.sol#L201
https://github.com/reserve-protocol/protocol/blob/master/contracts/p1/StRSR.sol#L671
https://github.com/reserve-protocol/protocol/blob/master/contracts/p1/StRSR.sol#L683
# Vulnerability details
## Impact
The initial... | https://github.com/code-423n4/2024-07-reserve-findings/issues/35 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-07-reserve-findings | GnosisTrade's MAX_ORDERS limit can be circumvented to DoS RToken recollateralization | # Lines of code
https://github.com/code-423n4/2024-07-reserve/blob/3f133997e186465f4904553b0f8e86ecb7bbacbf/contracts/plugins/trading/GnosisTrade.sol#L125
# Vulnerability details
The GnosisTrade contract leverages the Gnosis EasyAuction contract for batch sales.
This contract has a limitation in the fact that its ... | https://github.com/code-423n4/2024-07-reserve-findings/issues/19 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-07-reserve-findings | Malicious proposals can be executed in the Governance | # Lines of code
https://github.com/code-423n4/2024-07-reserve/blob/3f133997e186465f4904553b0f8e86ecb7bbacbf/contracts/p1/StRSR.sol#L452
https://github.com/code-423n4/2024-07-reserve/blob/3f133997e186465f4904553b0f8e86ecb7bbacbf/contracts/plugins/governance/Governance.sol#L131
# Vulnerability details
## Impact
In g... | https://github.com/code-423n4/2024-07-reserve-findings/issues/17 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-07-reserve-findings | Incorrect buying asset calculation in `nextTradePair` | # Lines of code
https://github.com/code-423n4/2024-07-reserve/blob/3f133997e186465f4904553b0f8e86ecb7bbacbf/contracts/p1/mixins/RecollateralizationLib.sol#L332-L353
# Vulnerability details
## Impact
Invalid assets(e.g. assets not in current basket) can be bought which will make collateralization worse.
## Proof of... | https://github.com/code-423n4/2024-07-reserve-findings/issues/12 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-07-reserve-findings | The fee in Gnosis trading isn't included in the calculation of the minBuyAmount | # Lines of code
https://github.com/code-423n4/2024-07-reserve/blob/3f133997e186465f4904553b0f8e86ecb7bbacbf/contracts/p1/mixins/TradeLib.sol#L76-L80
https://github.com/code-423n4/2024-07-reserve/blob/3f133997e186465f4904553b0f8e86ecb7bbacbf/contracts/plugins/trading/GnosisTrade.sol#L114-L120
# Vulnerability details
... | https://github.com/code-423n4/2024-07-reserve-findings/issues/5 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-07-reserve-findings | The recollateralization process isn't working properly | # Lines of code
https://github.com/code-423n4/2024-07-reserve/blob/3f133997e186465f4904553b0f8e86ecb7bbacbf/contracts/p1/mixins/RecollateralizationLib.sol#L198
# Vulnerability details
## Impact
When the `basket` isn't fully `collateralized`, a `recollateralization` process takes place, which is crucial.
The `bask... | https://github.com/code-423n4/2024-07-reserve-findings/issues/4 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-07-reserve-findings | The recollateralization process isn't working properly | # Lines of code
https://github.com/code-423n4/2024-07-reserve/blob/3f133997e186465f4904553b0f8e86ecb7bbacbf/contracts/p1/mixins/RecollateralizationLib.sol#L198
# Vulnerability details
## Impact
When the `basket` isn't fully `collateralized`, a `recollateralization` process takes place, which is crucial.
The `bask... | https://github.com/code-423n4/2024-07-reserve-findings/issues/3 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-wildcat-findings | Disabled SphereXEngine Proctection. | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/WildcatArchController.sol#L61
# Vulnerability details
## Impact
In WildcatArchController.sol file "WildcatArchController" contract constructor is passing "SphereXEngine's" engine address = 0 which will d... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/107 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-wildcat-findings | `WildcatArchController::updateSphereXEngineOnRegisteredContracts` will never execute because `sphereXEngine` is set as `address(0)` and never updated. | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/WildcatArchController.sol#L84
# Vulnerability details
## Impact
The `WildcatArchController::updateSphereXEngineOnRegisteredContracts` updates SphereX engine on registered contracts and add them as allowe... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/99 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-wildcat-findings | Markets do not update delinquency timer correctly if the account goes underwater through interest accrual | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/market/WildcatMarketBase.sol#L406-L465
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/market/WildcatMarketBase.sol#L541-L542
# Vulnerability details
## Imp... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/89 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-wildcat-findings | debit owned by borrower not cleared after full repayment of loan | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/market/WildcatMarket.sol#L226
# Vulnerability details
Current implementation lacks the mechanism to clear borrowers debt either by full repayment of debt owned or closing of market .
This is problematic... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/75 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-wildcat-findings | WildcatSanctionsSentinel:: createEscrow allows unregistered market to used to create escrow | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/WildcatSanctionsSentinel.sol#L121
# Vulnerability details
In `WildcatSanctionsSentinel.sol`, the `createEscrow()` function has two issues :
- There is currently no check that `msg.sender` is a regis... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/65 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-wildcat-findings | User could withdraw more than supposed to, forcing last user withdraw to fail | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/market/WildcatMarketWithdrawals.sol#L248
# Vulnerability details
## Impact
User could withdraw more than supposed to and force last user's withdraw to fail.
## Proof of Concept
Within Wildcat, withdraw requests are put into batches. Users ... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/64 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-wildcat-findings | `SphereXConfig::constructor` argument `engine` set as `0` in `WildcatArchController::constructor` will prevent key `WildcatArchController` functions from from executing | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/WildcatArchController.sol#L61
# Vulnerability details
## Details
In `WildcatArchController::constructor` the `SphereXConfig` is initialiazed by providing its `constructor` arguments as so
```
//src/Wild... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/58 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-wildcat-findings | `state.scaleFactor` is calculated incorrectly when handling the current expired withdrawal batch | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/market/WildcatMarketBase.sol#L409-L431
# Vulnerability details
## Impact
- The amount of assets paid for the current expired withdrawal batch is less than expected
- The amount of reserved assets for unpaid withdrawal batches is insufficien... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/54 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-wildcat-findings | lenders are unable to get full repayment amount | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/market/WildcatMarketWithdrawals.sol#L251
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/market/WildcatMarketWithdrawals.sol#L247
# Vulnerability details
Th... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/34 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.