task_id
stringlengths
10
58
repo
stringclasses
854 values
pr_number
int32
1
321k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
task
stringlengths
2
105k
plan
listlengths
1
100
subagents
listlengths
1
100
revisions
listlengths
0
100
final_diff
stringlengths
256
202M
num_subtasks
int32
1
100
num_changed_files
int32
2
100
zellij-org/zellij#5127
zellij-org/zellij
5,127
b5e39d54246a845bc293cf1521d367b39f476772
5d8ac0239916f33f2c0f946c6a7ffbf15b94e5ad
fix: when publishing, publish current branch rather than hardcoded main Small fix to our release process, in preparation to working with release branches.
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: fix: when publishing, publish current branch rather than hardcoded main", "scope_files": [ "CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `xtask/src/` needed for: fix: w...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 042cf5cce5..61181d277c 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -13,6 +13,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)\n ...
[]
diff --git a/CHANGELOG.md b/CHANGELOG.md index 042cf5cce5..61181d277c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) * feat: support `CSI 2031` + dark/light mode theme switching (https://github.com/zellij-org/zellij/pull/51...
2
2
zellij-org/zellij#5117
zellij-org/zellij
5,117
914953758357024d3c1aeaa496bfe8df906f8416
f79353632270de51aa26793e17d26bdf4ec2d8e8
Fullscreen resize fixes This fixes two bugs: 1. When changing a pane to fullscreen, then resizing the terminal (or changing the font size), then bringing it back, the layout would get messed up. Fixed with some bookkeeping during resize. 2. When resizing a pane to fullscreen, editing its scrollback, bringing it back...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Fullscreen resize fixes", "scope_files": [ "CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `zellij-server/src/panes/tiled_panes/` needed for: Fullscreen resize fixes", ...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 04a2fffbbb..042cf5cce5 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)\n ...
[]
diff --git a/CHANGELOG.md b/CHANGELOG.md index 04a2fffbbb..042cf5cce5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) * fix: prevent occasional duplicate characters in the web client due to IME (https://github.com/zellij-org...
4
4
zellij-org/zellij#5113
zellij-org/zellij
5,113
71e388a2e2bb2bfa9239a669c450130a81699489
dace2549ae8dcc6482ea6a3b2724252afe121ab3
fix: buffer pty processing while waiting for host query reply Continuing the work in https://github.com/zellij-org/zellij/pull/5105 - this makes sure to block (buffer) pty processing while waiting for a host query reply (eg. to OSC10/11).
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: fix: buffer pty processing while waiting for host query reply", "scope_files": [ "CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `zellij-server/src/` needed for: fix: buf...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 87dfd44981..04a2fffbbb 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -10,7 +10,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)\n ...
[]
diff --git a/CHANGELOG.md b/CHANGELOG.md index 87dfd44981..04a2fffbbb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,7 +10,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) * fix: restore kitty keyboard mode on error, handle DECRPM 2026 state 3, clean up client terminal teardown...
6
6
zellij-org/zellij#5105
zellij-org/zellij
5,105
5ab8b6870ccb475ec06fedd7ca3f891ef7bf51ff
d8c469f1843b7b96cc7da274880dc101dbe25aec
Allow automatic light/dark mode detection from applications running within zellij (CSI 2031) Several terminal emulators now allow for automatic switching between light and dark themes, and allow applications running within the terminal to subscribe to theme changes. Automatic switching off all applications together is...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Allow automatic light/dark mode detection from applications running within zellij (CSI 2031)", "scope_files": [ "CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `zellij-cl...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex ea17ec2607..aa583406cf 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -9,6 +9,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)\n * ...
[]
diff --git a/CHANGELOG.md b/CHANGELOG.md index ea17ec2607..aa583406cf 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) * fix: occasional dropped characters in web client (https://github.com/zellij-org/zellij/pull/5080) * fix: ...
21
52
zellij-org/zellij#5082
zellij-org/zellij
5,082
0126a19f4804659a7472421a6d5d1ccd7b562717
81b4072925bd8a391bbadef7c417bea26d6bead1
fix(windows): reuse of terminal pane ids breaks new panes from opening Hello, I have no idea how this code works so I used AI to fix a critical issue I was having (described below). to be clear this code change does fix my issue, but this is **not necessarily intended to be accepted** verbatim. It is to provide ins...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: fix(windows): reuse of terminal pane ids breaks new panes from opening", "scope_files": [ "CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `zellij-server/src/` needed for:...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 1c20fdfdbb..87dfd44981 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -8,6 +8,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)\n * ...
[]
diff --git a/CHANGELOG.md b/CHANGELOG.md index 1c20fdfdbb..87dfd44981 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) * fix: idle CPU + disk i/o, CommandChanged plugin Event, GetSessionList plugin command (https://github.com/z...
2
2
zellij-org/zellij#5110
zellij-org/zellij
5,110
79c0e2088786fe72050eb4dadf41da1c1ac4afad
cdfca71c9579eca9da3016f39f54f7248f15a0e5
fix: incorrect interpretation of unicode keys Reopen #4833 @imsnif
[ { "subtask_id": "s1", "goal": "Implement the changes under `zellij-client/src/` needed for: fix: incorrect interpretation of unicode keys", "scope_files": [ "zellij-client/src/keyboard_parser.rs" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `zellij-utils/src/` ne...
[ { "subtask_id": "s1", "scope_files": [ "zellij-client/src/keyboard_parser.rs" ], "solution_diff": "diff --git a/zellij-client/src/keyboard_parser.rs b/zellij-client/src/keyboard_parser.rs\nindex 86c29b6dd8..a5cbe1cda7 100644\n--- a/zellij-client/src/keyboard_parser.rs\n+++ b/zellij-client/src/...
[]
diff --git a/zellij-client/src/keyboard_parser.rs b/zellij-client/src/keyboard_parser.rs index 86c29b6dd8..a5cbe1cda7 100644 --- a/zellij-client/src/keyboard_parser.rs +++ b/zellij-client/src/keyboard_parser.rs @@ -436,6 +436,24 @@ pub fn can_parse_bare_keys() { Some(KeyWithModifier::new(BareKey::F(4))), ...
2
2
zellij-org/zellij#5111
zellij-org/zellij
5,111
227142dd567ee72bcc137c116bc1ce2b818975e7
d41ad739602ff77c2a8a41fa1e8c644cef20b290
Implement DECQRM for CSI2031 Continuing the work from https://github.com/zellij-org/zellij/pull/5105 - this implements DECQRM handling for CSI2031 (I forgot to add it in the previous PR!)
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Implement DECQRM for CSI2031", "scope_files": [ "CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `zellij-server/src/panes/` needed for: Implement DECQRM for CSI2031", ...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex aa583406cf..05c6080e2e 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -9,7 +9,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)\n * ...
[]
diff --git a/CHANGELOG.md b/CHANGELOG.md index aa583406cf..05c6080e2e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,7 +9,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) * fix: occasional dropped characters in web client (https://github.com/zellij-org/zellij/pull/5080) * fix: ...
3
3
zellij-org/zellij#5080
zellij-org/zellij
5,080
7d647f7b78992c22b0fb5af4746622b1a2552b73
9c089572186f8715f991d746aaf582c1ae501fcc
fix: lost web characters When typing fast in the web client, on platforms that support IME, we would occasionally lose characters. This is because xterm.js doesn't seem to handle (unless I missed something) IME composition of normal characters (the "I didn't actually need IME" path). To bypass this, we're sending t...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: fix: lost web characters", "scope_files": [ "CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `zellij-client/assets/` needed for: fix: lost web characters", "scope_file...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 6c364bcf04..6ca41673ec 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -6,6 +6,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)\n \n...
[]
diff --git a/CHANGELOG.md b/CHANGELOG.md index 6c364bcf04..6ca41673ec 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) ## [Unreleased] * fix: idle CPU + disk i/o, CommandChanged plugin Event, GetSessionList plugin command (h...
2
2
zellij-org/zellij#5058
zellij-org/zellij
5,058
aa29cbaf6631af0afca6aae427a97b3e478393b3
4a06f777c9678943124afb0f80ce20083f0a8c2c
fix: kitty keyboard restore on error path + 2026 DECRPM state 3 handling stdin_ansi_parser.rs: synchronized_output_from_bytes now treats DECRPM state 3 (permanently set) as enabled, matching states 1 and 2. State 3 is a valid "supported and on" response that was previously falling through to None (treated as unsupport...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: fix: kitty keyboard restore on error path + 2026 DECRPM state 3 handling", "scope_files": [ "CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `zellij-client/src/` needed fo...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 8290e4be10..6c364bcf04 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -6,6 +6,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)\n \n...
[]
diff --git a/CHANGELOG.md b/CHANGELOG.md index 8290e4be10..6c364bcf04 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) ## [Unreleased] * fix: idle CPU + disk i/o, CommandChanged plugin Event, GetSessionList plugin command (h...
2
3
zellij-org/zellij#5063
zellij-org/zellij
5,063
0d8ebaa234885ad298962a7b702cbc00bba16521
2f9a6d1c24d3ad5f782a6b29dc8a92bd9621f0de
Some idle CPU and disk/io fixes, new CommandChanged plugin Event This PR aimed to fix some issues with idle CPU utilization occasionally reaching single-digit percentages in some scenarios. Due to the nature of the fixes, I also found myself adding the following features: 1. `OSC7` support to read directory changes...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Some idle CPU and disk/io fixes, new CommandChanged plugin Event", "scope_files": [ "CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `default-plugins/session-manager/src/`...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 276e7ba76b..8290e4be10 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -5,6 +5,7 @@ All notable changes to this project will be documented in this file.\n The format is...
[]
diff --git a/CHANGELOG.md b/CHANGELOG.md index 276e7ba76b..8290e4be10 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) ## [Unreleased] +* fix: idle CPU + d...
13
29
zellij-org/zellij#5014
zellij-org/zellij
5,014
442cb1572480509a2b229972052aad293d6fd11f
8e4e8c7925f12e7674302889018f998e1ee47a8b
fix(windows): skip modifier re-encoding for Char keys in cast_crossterm_key PR #4967 added VT modifier encoding for non-Char keys but the guard condition also matched Char keys, re-encoding Ctrl+C from [0x03] to CSI u sequence \x1b[3;5u which shells don't understand. Skip the encoding block for Char keys since they al...
[ { "subtask_id": "s1", "goal": "Implement the changes under `zellij-server/src/unit/` needed for: fix(windows): skip modifier re-encoding for Char keys in cast_crossterm_key", "scope_files": [ "zellij-server/src/unit/screen_tests.rs" ] }, { "subtask_id": "s2", "goal": "Implement the...
[ { "subtask_id": "s1", "scope_files": [ "zellij-server/src/unit/screen_tests.rs" ], "solution_diff": "diff --git a/zellij-server/src/unit/screen_tests.rs b/zellij-server/src/unit/screen_tests.rs\nindex a93c63bf97..44f0d31abf 100644\n--- a/zellij-server/src/unit/screen_tests.rs\n+++ b/zellij-ser...
[]
diff --git a/zellij-server/src/unit/screen_tests.rs b/zellij-server/src/unit/screen_tests.rs index a93c63bf97..44f0d31abf 100644 --- a/zellij-server/src/unit/screen_tests.rs +++ b/zellij-server/src/unit/screen_tests.rs @@ -2267,6 +2267,74 @@ pub fn send_cli_send_keys_action_to_screen() { assert_snapshot!(format!("...
3
4
zellij-org/zellij#5011
zellij-org/zellij
5,011
985cca716ed5ff130dbe72694f4135602389d613
32b9edc71b95d92be6567f8ed0673cca63dacb9f
Minor fix before patch version This bumps the patch version to 0.44.1, and also contains a minor fix to row background coloring as part of some of the patch fixes.
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Minor fix before patch version", "scope_files": [ "CHANGELOG.md", "Cargo.lock", "Cargo.toml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `zellij-server/src/panes/` neede...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md", "Cargo.lock", "Cargo.toml" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex dc7693d1c0..7bd30fee65 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -19,7 +19,7 @@ The format is based on [Keep a Changelog](...
[]
diff --git a/CHANGELOG.md b/CHANGELOG.md index dc7693d1c0..7bd30fee65 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -19,7 +19,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) * fix: scrollback with partial scroll region (eg. Codex bug) (https://github.com/zellij-org/zellij/pull/49...
2
4
zellij-org/zellij#5010
zellij-org/zellij
5,010
060b7f41a04dc2ff760df2f81c5f007cf0af95f7
fda929a64f0b0409ada0bf4f17a3438a194bfa3a
Fix pty race when opening new panes This fixes an occasional race condition when starting new panes: if the command is extremely short lived (eg. `echo hello`) and is run directly and not in the context of a shell (eg. through `zellij run`), we would sometimes have cases where the command bytes and the `HoldPane` dire...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Fix pty race when opening new panes", "scope_files": [ "CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `zellij-server/src/` needed for: Fix pty race when opening new pane...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex a5ce02e873..382682965a 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -25,6 +25,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)\n ...
[]
diff --git a/CHANGELOG.md b/CHANGELOG.md index a5ce02e873..382682965a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -25,6 +25,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) * fix: encode modifiers in raw bytes for non-Char keys in windows (https://github.com/zellij-org/zellij/pu...
3
3
zellij-org/zellij#4979
zellij-org/zellij
4,979
6542afabd80e44ab730413b92e3456a15a5f0a2f
fd3680be8958c13c57b71e0a12f453ea8bea6a4a
Name flag and name option does not work on windows ## Issue description name pane does not run a pane with the given name ## Minimal reproduction On windows 11 run a clean instance of zellij and the use the following command ```bash zellij action new-pane --name flame -f ``` The pane will not be renamed, it will sho...
[ { "subtask_id": "s1", "goal": "Implement the changes under `zellij-server/src/` needed for: Name flag and name option does not work on windows", "scope_files": [ "zellij-server/src/pty.rs", "zellij-server/src/route.rs", "zellij-server/src/screen.rs" ] }, { "subtask_id": "s2...
[ { "subtask_id": "s1", "scope_files": [ "zellij-server/src/pty.rs", "zellij-server/src/route.rs", "zellij-server/src/screen.rs" ], "solution_diff": "diff --git a/zellij-server/src/pty.rs b/zellij-server/src/pty.rs\nindex bb9c800cbb..0fdcddc45d 100644\n--- a/zellij-server/src/pty.rs\...
[]
diff --git a/zellij-server/src/pty.rs b/zellij-server/src/pty.rs index bb9c800cbb..0fdcddc45d 100644 --- a/zellij-server/src/pty.rs +++ b/zellij-server/src/pty.rs @@ -226,10 +226,14 @@ pub(crate) fn pty_thread_main(mut pty: Pty, layout: Box<Layout>) -> Result<()> { Some(TerminalAction::RunComma...
8
10
zellij-org/zellij#4918
zellij-org/zellij
4,918
15485aea7dc972f67588783b290fd399b2fba856
699cac6a334ddf14ad1cbe3bbde874b1aae292a7
fix: performance regression when switching tabs This fixes an issue reported in https://github.com/zellij-org/zellij/issues/4903 where in some systems switching tabs would lag in 0.44.0 compared to 0.43.1. This was caused by the migration to wasmi from wasmtime exposing a long-standing performance issue where we wo...
[ { "subtask_id": "s1", "goal": "Implement the changes under `default-plugins/compact-bar/src/` needed for: fix: performance regression when switching tabs", "scope_files": [ "default-plugins/compact-bar/src/main.rs" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `de...
[ { "subtask_id": "s1", "scope_files": [ "default-plugins/compact-bar/src/main.rs" ], "solution_diff": "diff --git a/default-plugins/compact-bar/src/main.rs b/default-plugins/compact-bar/src/main.rs\nindex 074e5181a6..3a8446a518 100644\n--- a/default-plugins/compact-bar/src/main.rs\n+++ b/defaul...
[]
diff --git a/default-plugins/compact-bar/src/main.rs b/default-plugins/compact-bar/src/main.rs index 074e5181a6..3a8446a518 100644 --- a/default-plugins/compact-bar/src/main.rs +++ b/default-plugins/compact-bar/src/main.rs @@ -60,6 +60,9 @@ struct State { is_first_run: bool, own_tab_index: Option<usize>, ...
15
21
zellij-org/zellij#4951
zellij-org/zellij
4,951
0532949bbdcee5116e91807ddb45a85d78a2aafc
c2b729f0ab7a84e5ecc037673e02450647cd5e78
fix: position host cursor for CJK IME even when app hides cursor ## Summary When apps like Claude Code (which uses the ink/React library) run inside Zellij, IME composition candidates appear at the wrong position. This makes CJK input (Japanese, Chinese, Korean) effectively broken in these apps. The same apps ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/tests/e2e/` needed for: fix: position host cursor for CJK IME even when app hides cursor", "scope_files": [ "src/tests/e2e/remote_runner.rs" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `zellij-serve...
[ { "subtask_id": "s1", "scope_files": [ "src/tests/e2e/remote_runner.rs" ], "solution_diff": "diff --git a/src/tests/e2e/remote_runner.rs b/src/tests/e2e/remote_runner.rs\nindex 20f4e0c3de..958b8f1e97 100644\n--- a/src/tests/e2e/remote_runner.rs\n+++ b/src/tests/e2e/remote_runner.rs\n@@ -337,8 ...
[]
diff --git a/zellij-server/src/panes/grid.rs b/zellij-server/src/panes/grid.rs index 79a9a7b4d4..ddb462cd8d 100644 --- a/zellij-server/src/panes/grid.rs +++ b/zellij-server/src/panes/grid.rs @@ -1574,11 +1574,15 @@ impl Grid { sixel_image_chunks, ))); } - pub fn cursor_coordinates(&self) -...
8
10
zellij-org/zellij#4981
zellij-org/zellij
4,981
1411b2d9adf2d08a6e14f3262493ca9e6d26b219
07ba27cc531310540e6e865ca9fd917a812f5b53
Web client: session switch ignores base_url behind reverse proxy When switching sessions via the session manager, the web client redirects to `/{session_name}` instead of `{base_url}/{session_name}`, ignoring the configured `base_url`. **Steps to reproduce:** 1. Configure `base_url = "/zellij/"` in `web_client` confi...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Web client: session switch ignores base_url behind reverse proxy", "scope_files": [ "CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `zellij-client/assets/` needed for: We...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 62edea0a0f..221b19b944 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -20,6 +20,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)\n ...
[ { "subtask_id": "s2", "comment": "just a small thing, should use `${encodeURIComponent(new_session_name)`.\nhref and pathname behave a bit differently and we could have problems if the session name contains special characters", "revised_diff": "diff --git a/zellij-client/assets/websockets.js b/zellij-cl...
diff --git a/CHANGELOG.md b/CHANGELOG.md index 62edea0a0f..221b19b944 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -20,6 +20,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) * fix: remote attach issues on macOS (https://github.com/zellij-org/zellij/pull/4972) * test: improve e2e...
2
2
zellij-org/zellij#4992
zellij-org/zellij
4,992
6542afabd80e44ab730413b92e3456a15a5f0a2f
73c494647da98785953a1bc2621f0f74dadf8c8a
Fix bce and other issues Some minor fixes for long standing issues, recently exposed, in our ANSI interpreter regarding background colors. Namely, we now make sure to pad (on render for trailing characters, as part of the grid for internal padding operations) using the style of the row's default background color (give...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Fix bce and other issues", "scope_files": [ "CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `zellij-server/src/output/` needed for: Fix bce and other issues", "scope_...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 7a507a9d8b..62edea0a0f 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -19,6 +19,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)\n ...
[]
diff --git a/CHANGELOG.md b/CHANGELOG.md index 7a507a9d8b..62edea0a0f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -19,6 +19,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) * fix: scrollback with partial scroll region (eg. Codex bug) (https://github.com/zellij-org/zellij/pull/49...
4
4
zellij-org/zellij#4941
zellij-org/zellij
4,941
22ace8e54fbdadd08973854ae7178535a62065b1
e39435ab95c7191f5bbde564525c71546b88259f
Preserve scrollback for partial scroll regions starting at top When a partial scroll region starts at row 0 (the top of the viewport), lines scrolled off the top were silently discarded via viewport.remove(0) instead of being transferred to lines_above (the scrollback buffer). This affected both add_canonical_line and...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Preserve scrollback for partial scroll regions starting at top", "scope_files": [ "CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `zellij-server/src/panes/` needed for: P...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 6ec77b24f5..38b152f40b 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -16,6 +16,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)\n ...
[]
diff --git a/CHANGELOG.md b/CHANGELOG.md index 6ec77b24f5..38b152f40b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) * fix: compilation warnings in windows (https://github.com/zellij-org/zellij/pull/4890) * feat: add --lay...
3
3
zellij-org/zellij#4952
zellij-org/zellij
4,952
7c68623580342940d7cd53bc8bce1926841feb47
07cc583d9e5bfa590d22a67850bc8e8cf5110707
fix(e2e): stabilize tests and support Apple Silicon local dev Tried to run e2e tests locally on macOS, and ran into some problems due to the amd64 docker emulation being slow. - cross-compile musl binary on macOS via cargo-zigbuild, with arch-independent symlink so snapshots are stable across x86_64 and aarch64 - ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: fix(e2e): stabilize tests and support Apple Silicon local dev", "scope_files": [ "CHANGELOG.md", "CONTRIBUTING.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/tests/e2e/`...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md", "CONTRIBUTING.md" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 6ba6b22a65..7a507a9d8b 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -18,6 +18,7 @@ The format is based on [Keep a Changelog](https://keepach...
[]
diff --git a/CHANGELOG.md b/CHANGELOG.md index 6ba6b22a65..7a507a9d8b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) * fix: proper error on socket paths that are too long (https://github.com/zellij-org/zellij/pull/4957) * ...
4
11
zellij-org/zellij#4972
zellij-org/zellij
4,972
50c029afaf3f1b412583f7cfe7aa9f0ee984ffa8
cea51035b382f836de6ae13b6f8d8df21fd02d3f
remote terminal attach didn't work Latest version 0.44.0. Tried to attach to remote terminal and got different error on MacOS and Ubuntu. MacOS: ``` $ zellij attach https://10.10.0.1/fascinating-mountain --token #### --ca-cert localhost+3-jb-ca.pem Connection failed: TLS error: native-tls error: bad protocol version ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: remote terminal attach didn't work", "scope_files": [ "CHANGELOG.md", "Cargo.lock" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `zellij-client/` needed for: remote terminal att...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md", "Cargo.lock" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 38b152f40b..6ba6b22a65 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -17,6 +17,7 @@ The format is based on [Keep a Changelog](https://keepachangel...
[]
diff --git a/CHANGELOG.md b/CHANGELOG.md index 38b152f40b..6ba6b22a65 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,6 +17,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) * feat: add --layout-string to allow for in-line layouts, add --tab-id to all new-pane CLI commands (https...
6
9
zellij-org/zellij#4958
zellij-org/zellij
4,958
00c6b0f549bd25ce82b73da8138d3c63599525f7
4ead2d97727c36b72d34314118571eccb8738470
Proper error when providing layout name with a tab Provide a proper error when providing a `name` (and similar) properties on the `layout` node if we already have one or more `tab` nodes.
[ { "subtask_id": "s1", "goal": "Implement the changes under `zellij-utils/src/input/unit/` needed for: Proper error when providing layout name with a tab", "scope_files": [ "zellij-utils/src/input/unit/layout_test.rs" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `...
[ { "subtask_id": "s1", "scope_files": [ "zellij-utils/src/input/unit/layout_test.rs" ], "solution_diff": "diff --git a/zellij-utils/src/input/unit/layout_test.rs b/zellij-utils/src/input/unit/layout_test.rs\nindex 4ba33c12ea..52b716133f 100644\n--- a/zellij-utils/src/input/unit/layout_test.rs\n...
[]
diff --git a/zellij-utils/src/kdl/kdl_layout_parser.rs b/zellij-utils/src/kdl/kdl_layout_parser.rs index ff7fcfe371..579a4b1402 100644 --- a/zellij-utils/src/kdl/kdl_layout_parser.rs +++ b/zellij-utils/src/kdl/kdl_layout_parser.rs @@ -2505,9 +2505,23 @@ impl<'a> KdlLayoutParser<'a> { let layout_has_hide_fl...
2
2
zellij-org/zellij#4957
zellij-org/zellij
4,957
8ce05f0bbd58acbbca95f95ae14fdc4e866f7391
bafaf8632b6cccd6edc3feb5443a2c383f8519db
Error on socket paths that are too long Previously, if we generated a session name that would exceed the system socket file length - the session would silently hang. This changes it (and related paths) so that we provide a proper error as well as a way to mitigate this.
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Error on socket paths that are too long", "scope_files": [ "CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `zellij-client/src/` needed for: Error on socket paths that are...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 76ad03df04..6ec77b24f5 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -15,6 +15,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)\n ...
[]
diff --git a/CHANGELOG.md b/CHANGELOG.md index 76ad03df04..6ec77b24f5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) * fix: normalize temp socket paths in windows (https://github.com/zellij-org/zellij/pull/4923) * fix: com...
4
5
zellij-org/zellij#4956
zellij-org/zellij
4,956
16beceaa0afcdb559316909ed87b84d487356fa6
94a1d9f754b6a39c75207ead5e046114fe14e630
Layout string flag This adds two things: 1. The various `--layout` receiving CLI commands now also have a `--layout-string` flag, allowing us to in-line a layout if we so wish (eg. `zellij action new-tab --layout-string "layout { pane; pane command=\"htop\"; }; "`). I think this will make some scripting scenarios m...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Layout string flag", "scope_files": [ "CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `default-plugins/compact-bar/src/` needed for: Layout string flag", "scope_files...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex ad47444ad9..76ad03df04 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -14,6 +14,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)\n ...
[]
diff --git a/CHANGELOG.md b/CHANGELOG.md index ad47444ad9..76ad03df04 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) * feat: support and forward OSC-99 desktop notifications (https://github.com/zellij-org/zellij/pull/4931) ...
18
26
zellij-org/zellij#4923
zellij-org/zellij
4,923
9014486ae70fa10ad8083d37837a4f17570f2ee8
94f85e6e3947ea12c333ad6c21ed6b66872fc6df
[windows] : unstable over openning same session over ssh and wezterm ``` WARN |zellij_server::route | 2026-03-19 03:39:06.169 [server_router] [zellij-server\src\route.rs:2134]: Server not ready, trying to place instruction in retry queue... WARN |zellij_server::route | 2026-03-19 03:39:06.169 [server_route...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: [windows] : unstable over openning same session over ssh and wezterm", "scope_files": [ "Cargo.lock" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `zellij-utils/` needed for: [windows...
[ { "subtask_id": "s1", "scope_files": [ "Cargo.lock" ], "solution_diff": "diff --git a/Cargo.lock b/Cargo.lock\nindex 8fc53c96a2..42b0873634 100644\n--- a/Cargo.lock\n+++ b/Cargo.lock\n@@ -4960,6 +4960,7 @@ dependencies = [\n \"crossterm\",\n \"curl-sys\",\n \"directories\",\n+ \"dunce\",\n ...
[]
diff --git a/Cargo.lock b/Cargo.lock index 8fc53c96a2..42b0873634 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -4960,6 +4960,7 @@ dependencies = [ "crossterm", "curl-sys", "directories", + "dunce", "expect-test", "humantime", "include_dir", diff --git a/zellij-utils/Cargo.toml b/zellij-utils/Cargo.toml index...
3
3
zellij-org/zellij#4890
zellij-org/zellij
4,890
e7fbd985cbbf52cc569ec2c0250b51f0c67c2eff
1d6f67013c1d4af34d320053f4e7d853f90a459e
fix: resolve Windows compilation warnings - Consume unused `CompilationResult` from `embed_resource::compile` in `build.rs` - Gate `std::io::prelude` import with `#[cfg(unix)]` since it's only used by `daemonize_web_server` which is unix-only
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/` needed for: fix: resolve Windows compilation warnings", "scope_files": [ "src/build.rs" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `zellij-client/src/web_client/` needed for: fix: resolve Windows...
[ { "subtask_id": "s1", "scope_files": [ "src/build.rs" ], "solution_diff": "diff --git a/src/build.rs b/src/build.rs\nindex 613c948308..ef173e3a59 100644\n--- a/src/build.rs\n+++ b/src/build.rs\n@@ -9,5 +9,5 @@ fn main() {\n \n // Embed the application icon into the Windows executable.\n ...
[]
diff --git a/src/build.rs b/src/build.rs index 613c948308..ef173e3a59 100644 --- a/src/build.rs +++ b/src/build.rs @@ -9,5 +9,5 @@ fn main() { // Embed the application icon into the Windows executable. #[cfg(target_os = "windows")] - embed_resource::compile("assets/zellij.rc", embed_resource::NONE); + ...
2
2
zellij-org/zellij#4931
zellij-org/zellij
4,931
802c96f5fca9de479af7c249130a7928bc441349
65fa7b6588545faf555f5c0bca302d4603f7664f
Support OSC-99 desktop notifications This adds support for OSC99, which means Zellij will now forward desktop notifications that arrive from applications running inside panes. Furthermore, when notifications are clicked, Zellij will also focus the relevant pane that sent the notification. If the pane requested a re...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Support OSC-99 desktop notifications", "scope_files": [ "CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `zellij-client/src/` needed for: Support OSC-99 desktop notificati...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 90401de9a9..b309db5a9a 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -11,6 +11,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)\n ...
[]
diff --git a/CHANGELOG.md b/CHANGELOG.md index 90401de9a9..b309db5a9a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) * fix: performance regression when switching tabs (https://github.com/zellij-org/zellij/pull/4918) * feat...
11
16
zellij-org/zellij#4926
zellij-org/zellij
4,926
2134deb5d565f308a2ce27909a8d611116d58be2
8602e100a5c2df8237573cbb5093bc37c8d5fb49
CLI focus-pane-id and are-floating-panes-visible actions This adds two CLI actions that I forgot to add in the recent CLI overhaul. Namely: 1. `zellij action focus-pane-id terminal_1` -> change the focus of the most-recently-active user to the specified pane 2. `zellij action are-floating-panes-visible` -> returns t...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: CLI focus-pane-id and are-floating-panes-visible actions", "scope_files": [ "CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `zellij-server/src/` needed for: CLI focus-pan...
[ { "subtask_id": "s1", "scope_files": [ "CHANGELOG.md" ], "solution_diff": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex eb59ec9346..90401de9a9 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -9,6 +9,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)\n * ...
[]
diff --git a/CHANGELOG.md b/CHANGELOG.md index eb59ec9346..90401de9a9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) * fix: theme folder not being picked up on startup (https://github.com/zellij-org/zellij/pull/4892) * fix: ...
12
95
zen-browser/desktop#14156
zen-browser/desktop
14,156
8b0aab15b5d279b30daf1eb974e8fe09ec8289f6
ca8a3928e00bee5a3ba81114ff271f27b142b0a7
when boost window is open, than system style is switched from light to dark, window stays in light style ### Preliminary Checks - [x] I have read and understood the important section above. - [x] I have searched existing issues and avoided creating duplicates. - [x] I am not filing an enhancement request. - [x] I hav...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/zen/boosts/` needed for: when boost window is open, than system style is switched from light to dark, window stays in light style", "scope_files": [ "src/zen/boosts/ZenBoostsEditor.mjs" ] }, { "subtask_id": "s2", "goal...
[ { "subtask_id": "s1", "scope_files": [ "src/zen/boosts/ZenBoostsEditor.mjs" ], "solution_diff": "diff --git a/src/zen/boosts/ZenBoostsEditor.mjs b/src/zen/boosts/ZenBoostsEditor.mjs\nindex b120ef25e58..f67ad0fa336 100644\n--- a/src/zen/boosts/ZenBoostsEditor.mjs\n+++ b/src/zen/boosts/ZenBoosts...
[]
diff --git a/src/zen/boosts/ZenBoostsEditor.mjs b/src/zen/boosts/ZenBoostsEditor.mjs index b120ef25e58..f67ad0fa336 100644 --- a/src/zen/boosts/ZenBoostsEditor.mjs +++ b/src/zen/boosts/ZenBoostsEditor.mjs @@ -18,6 +18,7 @@ export class nsZenBoostEditor { "zap-state-update", "selector-picker-state-update", ...
2
2
zen-browser/desktop#14128
zen-browser/desktop
14,128
4797717353c4c220f303ca8492cf3d282f2268b9
8f92c59fdbc10306b61a34175d78132821cbcd16
Routed tabs keep the cookies of the previous Workspaces ### Preliminary Checks - [x] I have read and understood the important section above. - [x] I have searched existing issues and avoided creating duplicates. - [x] I am not filing an enhancement request. - [x] I have checked that this issue cannot be reproduced on...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/browser/components/tabbrowser/content/` needed for: Routed tabs keep the cookies of the previous Workspaces", "scope_files": [ "src/browser/components/tabbrowser/content/tabbrowser-js.patch" ] }, { "subtask_id": "s2", ...
[ { "subtask_id": "s1", "scope_files": [ "src/browser/components/tabbrowser/content/tabbrowser-js.patch" ], "solution_diff": "diff --git a/src/browser/components/tabbrowser/content/tabbrowser-js.patch b/src/browser/components/tabbrowser/content/tabbrowser-js.patch\nindex 0edeeb8d73e..7c8a6bf531d...
[ { "subtask_id": "s2", "comment": "The inline comment has trailing whitespace and awkward punctuation/capitalization (e.g., \"Just in case, Let's...\") which makes it harder to read and may violate linting/formatting rules. Consider rewriting it as a single, grammatically correct sentence.", "revised_dif...
diff --git a/src/browser/components/tabbrowser/content/tabbrowser-js.patch b/src/browser/components/tabbrowser/content/tabbrowser-js.patch index 0edeeb8d73e..7c8a6bf531d 100644 --- a/src/browser/components/tabbrowser/content/tabbrowser-js.patch +++ b/src/browser/components/tabbrowser/content/tabbrowser-js.patch @@ -1,5...
2
2
zen-browser/desktop#14124
zen-browser/desktop
14,124
88b294364f7b478bd595942835d97c23efee1884
7804021f094892dc2e189b0cef06279043580203
[Space Routing Settings] The browser freezes when I look up a domain on google.com that is routed to a different workspace ### Preliminary Checks - [x] I have read and understood the important section above. - [x] I have searched existing issues and avoided creating duplicates. - [x] I am not filing an enhancement re...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: [Space Routing Settings] The browser freezes when I look up a domain on google.com that is routed to a different workspace", "scope_files": [ "surfer.json" ] }, { "subtask_id": "s2", "goal": "Implement...
[ { "subtask_id": "s1", "scope_files": [ "surfer.json" ], "solution_diff": "diff --git a/surfer.json b/surfer.json\nindex bcc52e5b1ef..dab8b73a61e 100644\n--- a/surfer.json\n+++ b/surfer.json\n@@ -20,7 +20,7 @@\n \"brandShortName\": \"Zen\",\n \"brandFullName\": \"Zen Browser\",\n ...
[ { "subtask_id": "s3", "comment": "`onBeforeTabSelect` now blocks the tab switch and schedules `gBrowser.selectedTab = aTab` later. As written, it (1) assumes `changeWorkspaceWithID` always returns a Promise (tests/mocks override it with sync fns), (2) uses `.catch(...).then(...)` so selection can still be a...
diff --git a/src/browser/components/tabbrowser/content/tabbrowser-js.patch b/src/browser/components/tabbrowser/content/tabbrowser-js.patch index 90ad2574e1a..0edeeb8d73e 100644 --- a/src/browser/components/tabbrowser/content/tabbrowser-js.patch +++ b/src/browser/components/tabbrowser/content/tabbrowser-js.patch @@ -1,5...
4
4
zen-browser/desktop#14001
zen-browser/desktop
14,001
bf365f804355a7db4ee0369289bc48530626c644
32ebd08ba79c8983824cca8db2c144d1af3fe0ed
no-bug: bypass workspace container coercion for extension-opened tabs (gh-14001) When a WebExtension (e.g. Grammarly) opens a tab via browser.tabs.create() without specifying a cookieStoreId, it expects the tab to open in the default (No Container) context. Zen's workspace container logic was overriding this, forcing ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `configs/windows/` needed for: no-bug: bypass workspace container coercion for extension-opened tabs (gh-14001)", "scope_files": [ "configs/windows/mozconfig" ] }, { "subtask_id": "s2", "goal": "Implement the changes under ...
[ { "subtask_id": "s1", "scope_files": [ "configs/windows/mozconfig" ], "solution_diff": "diff --git a/configs/windows/mozconfig b/configs/windows/mozconfig\nindex 065ed1291d1..83f4283a47d 100644\n--- a/configs/windows/mozconfig\n+++ b/configs/windows/mozconfig\n@@ -9,6 +9,12 @@ if test \"$ZEN_C...
[]
diff --git a/configs/windows/mozconfig b/configs/windows/mozconfig index 065ed1291d1..83f4283a47d 100644 --- a/configs/windows/mozconfig +++ b/configs/windows/mozconfig @@ -9,6 +9,12 @@ if test "$ZEN_CROSS_COMPILING"; then export WINE="$(echo ~)/win-cross/wine/bin/wine" export WINEDEBUG=-all + # Force Wine to ...
3
3
zen-browser/desktop#14091
zen-browser/desktop
14,091
bd3adba05edc4c8c2e0b9ff594f2b19de9aac796
c0877391da7a4cdbea7963bcd358e5e17e437eb0
size override doesnt reset zoom to default after disabling it ### Preliminary Checks - [x] I have read and understood the important section above. - [x] I have searched existing issues and avoided creating duplicates. - [x] I am not filing an enhancement request. - [x] I have checked that this issue cannot be reprodu...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/zen/boosts/` needed for: size override doesnt reset zoom to default after disabling it", "scope_files": [ "src/zen/boosts/ZenBoostsEditor.mjs" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/zen/bo...
[ { "subtask_id": "s1", "scope_files": [ "src/zen/boosts/ZenBoostsEditor.mjs" ], "solution_diff": "diff --git a/src/zen/boosts/ZenBoostsEditor.mjs b/src/zen/boosts/ZenBoostsEditor.mjs\nindex 7254ac3fdad..2b224690c82 100644\n--- a/src/zen/boosts/ZenBoostsEditor.mjs\n+++ b/src/zen/boosts/ZenBoosts...
[ { "subtask_id": "s1", "comment": "`await actor.sendQuery(...)` can throw/reject (e.g. tab closed/crashed or actor unavailable). Because this is inside the click handler, a rejection would prevent `updateSizeButtonVisuals()`/`updateCurrentBoost()` from running and can surface as an unhandled promise rejectio...
diff --git a/src/zen/boosts/ZenBoostsEditor.mjs b/src/zen/boosts/ZenBoostsEditor.mjs index 7254ac3fdad..2b224690c82 100644 --- a/src/zen/boosts/ZenBoostsEditor.mjs +++ b/src/zen/boosts/ZenBoostsEditor.mjs @@ -638,7 +638,7 @@ ${cssSelector} { /** * Handles the size toggle button press, cycling through size overri...
2
2
zen-browser/desktop#14077
zen-browser/desktop
14,077
11a977e5334393e4f77dce6b732821cb92ff5275
c7f5634bd1c899b65209d06db4deefab0b8f2de5
Space icons overflow inaccessible unless sidebar is made wider than necessary ### Preliminary Checks - [x] I have read and understood the important section above. - [x] I have searched existing issues and avoided creating duplicates. - [x] I am not filing an enhancement request. - [x] I have checked that this issue c...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/zen/spaces/` needed for: Space icons overflow inaccessible unless sidebar is made wider than necessary", "scope_files": [ "src/zen/spaces/ZenSpaceIcons.mjs", "src/zen/spaces/zen-workspaces.css" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "src/zen/spaces/ZenSpaceIcons.mjs", "src/zen/spaces/zen-workspaces.css" ], "solution_diff": "diff --git a/src/zen/spaces/ZenSpaceIcons.mjs b/src/zen/spaces/ZenSpaceIcons.mjs\nindex a15bcc083eb..b8bfb67440e 100644\n--- a/src/zen/spaces/ZenSpaceIcons....
[ { "subtask_id": "s1", "comment": "What does this change exactly?", "revised_diff": "diff --git a/src/zen/spaces/zen-workspaces.css b/src/zen/spaces/zen-workspaces.css\nindex d9fa560af46..f5d7e91a9f9 100644\n--- a/src/zen/spaces/zen-workspaces.css\n+++ b/src/zen/spaces/zen-workspaces.css\n@@ -20,7 +20,6 ...
diff --git a/src/zen/spaces/ZenSpaceIcons.mjs b/src/zen/spaces/ZenSpaceIcons.mjs index a15bcc083eb..b8bfb67440e 100644 --- a/src/zen/spaces/ZenSpaceIcons.mjs +++ b/src/zen/spaces/ZenSpaceIcons.mjs @@ -15,12 +15,12 @@ class nsZenWorkspaceIcons extends MozXULElement { this.initDragAndDrop(); this.addEventList...
1
2
zen-browser/desktop#14089
zen-browser/desktop
14,089
acc5837c138a131ebc5d062f06534c932900df90
442ea54faca95640e44dd1292201a9f13f3b914d
no-bug: Sync upstream Firefox to version `151.0.4` This PR syncs the upstream Firefox to version 151.0.4. * ✅ All patches applied cleanly. @mr-cheffy please review and merge this PR.
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: no-bug: Sync upstream Firefox to version `151.0.4`", "scope_files": [ "README.md", "surfer.json" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `build/firefox-cache/` needed for:...
[ { "subtask_id": "s1", "scope_files": [ "README.md", "surfer.json" ], "solution_diff": "diff --git a/README.md b/README.md\nindex f2655b75a6f..af0a6a3ca23 100644\n--- a/README.md\n+++ b/README.md\n@@ -34,8 +34,8 @@ Zen is a firefox-based browser with the aim of pushing your productivity t...
[ { "subtask_id": "s3", "comment": "This change removes the `[sandbox]` external-test import mapping entirely, which means Zen will no longer pull in any upstream sandbox tests. If this is intentional (upstream removal/deprecation), consider documenting the rationale (here or in the PR description); otherwise...
diff --git a/README.md b/README.md index f2655b75a6f..af0a6a3ca23 100644 --- a/README.md +++ b/README.md @@ -34,8 +34,8 @@ Zen is a firefox-based browser with the aim of pushing your productivity to a ne ### Firefox Versions -- [`Release`](https://zen-browser.app/download) - Is currently built using Firefox versio...
5
28
zen-browser/desktop#14088
zen-browser/desktop
14,088
6bde408c799edd6189d1676f0311bf61f5f422ce
5a09d0c1980daa6e6897b7e1ed590466cbdd4f3a
[META]: Space routing gh-14044: Fix Space-Routing CSS, Filter Out Empty Routes
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/zen/common/sys/ui/` needed for: [META]: Space routing", "scope_files": [ "src/zen/common/sys/ui/ZenSpaceRoutingNavigation.sys.mjs" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/zen/space-routing/...
[ { "subtask_id": "s1", "scope_files": [ "src/zen/common/sys/ui/ZenSpaceRoutingNavigation.sys.mjs" ], "solution_diff": "diff --git a/src/zen/common/sys/ui/ZenSpaceRoutingNavigation.sys.mjs b/src/zen/common/sys/ui/ZenSpaceRoutingNavigation.sys.mjs\nindex fcf85bb1968..ce0fef43752 100644\n--- a/src...
[ { "subtask_id": "s2", "comment": "`saveRoutes()` now assumes every entry in `this.#file.data.routes` has a string `reference`. If a user has a corrupted/legacy routes file where a route is missing `reference` (or is non-object), `route.reference.trim()` will throw and prevent saving/closing the dialog. This...
diff --git a/src/zen/common/sys/ui/ZenSpaceRoutingNavigation.sys.mjs b/src/zen/common/sys/ui/ZenSpaceRoutingNavigation.sys.mjs index fcf85bb1968..ce0fef43752 100644 --- a/src/zen/common/sys/ui/ZenSpaceRoutingNavigation.sys.mjs +++ b/src/zen/common/sys/ui/ZenSpaceRoutingNavigation.sys.mjs @@ -29,7 +29,8 @@ export class ...
2
3
zen-browser/desktop#14048
zen-browser/desktop
14,048
5db8780f5d730b94fa83048840e1c5538621aa6c
9da0f4595dab54066b24e1e20e5f5e2d98bf8f5f
Glance closes pinned tab if no other tabs open ### Preliminary Checks - [x] I have read and understood the important section above. - [x] I have searched existing issues and avoided creating duplicates. - [x] I am not filing an enhancement request. - [x] I have checked that this issue cannot be reproduced on Mozilla ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/zen/spaces/` needed for: Glance closes pinned tab if no other tabs open", "scope_files": [ "src/zen/spaces/ZenSpaceManager.mjs" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/zen/tests/glance/` ne...
[ { "subtask_id": "s1", "scope_files": [ "src/zen/spaces/ZenSpaceManager.mjs" ], "solution_diff": "diff --git a/src/zen/spaces/ZenSpaceManager.mjs b/src/zen/spaces/ZenSpaceManager.mjs\nindex 43dcb6dda6a..caeee405fc0 100644\n--- a/src/zen/spaces/ZenSpaceManager.mjs\n+++ b/src/zen/spaces/ZenSpaceM...
[ { "subtask_id": "s1", "comment": "The guard meant to skip last-unpinned-tab handling when closing a *glance child* currently checks `glance-id`, which is also set on the parent tab. That makes `handleTabBeforeClose` bail out for parent-tab closes while a glance is open as well, which is broader than the com...
diff --git a/src/zen/spaces/ZenSpaceManager.mjs b/src/zen/spaces/ZenSpaceManager.mjs index 43dcb6dda6a..caeee405fc0 100644 --- a/src/zen/spaces/ZenSpaceManager.mjs +++ b/src/zen/spaces/ZenSpaceManager.mjs @@ -1010,6 +1010,14 @@ class nsZenWorkspaces { return null; } + // Closing a glance tab tears down...
2
3
zen-browser/desktop#14069
zen-browser/desktop
14,069
965bb9391da5ca543b9ab79125c7bbab8f645e7a
3692a5047f9fcc46b6051d738be3587c15e82747
[META]: Space routing gh-14044: Finish implementation for space routing
[ { "subtask_id": "s1", "goal": "Implement the changes under `prefs/firefox/` needed for: [META]: Space routing", "scope_files": [ "prefs/firefox/browser.yaml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/browser/components/tabbrowser/content/` needed for: [ME...
[ { "subtask_id": "s1", "scope_files": [ "prefs/firefox/browser.yaml" ], "solution_diff": "diff --git a/prefs/firefox/browser.yaml b/prefs/firefox/browser.yaml\nindex 341577cac76..4545795c628 100644\n--- a/prefs/firefox/browser.yaml\n+++ b/prefs/firefox/browser.yaml\n@@ -94,3 +94,8 @@\n # See gh...
[ { "subtask_id": "s9", "comment": "## Unused variable, import, function or class\n\nUnused function makeFakeWindow.\n\n---\n\n<p>Remove the unused <code>makeFakeWindow</code> helper function from <code>src/zen/tests/space_routing/head.js</code>.</p>\n<p>Best fix without changing functionality:</p>\n<ul>\n<li...
diff --git a/prefs/firefox/browser.yaml b/prefs/firefox/browser.yaml index 341577cac76..4545795c628 100644 --- a/prefs/firefox/browser.yaml +++ b/prefs/firefox/browser.yaml @@ -94,3 +94,8 @@ # See gh-12985 for details on the following preferences - name: browser.search.widget.new value: true + +# Disabled from htt...
10
17
zen-browser/desktop#14054
zen-browser/desktop
14,054
e7e4c5a452289a62df45462ec1bc88f8a86760e6
42b7713f57011c1a174ba4a8533e25ed99771758
[META]: Space routing gh-14044: Change to use gDialogBox instead of openDialog
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/browser/base/content/zen-panels/` needed for: [META]: Space routing", "scope_files": [ "src/browser/base/content/zen-panels/popups.inc" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/zen/boosts/` ...
[ { "subtask_id": "s1", "scope_files": [ "src/browser/base/content/zen-panels/popups.inc" ], "solution_diff": "diff --git a/src/browser/base/content/zen-panels/popups.inc b/src/browser/base/content/zen-panels/popups.inc\nindex bc9abc04e3a..2ff92383d49 100644\n--- a/src/browser/base/content/zen-p...
[ { "subtask_id": "s3", "comment": "`@namespace xul ...` is declared but no default namespace is set. In a XUL document (`zen-space-routing.inc.xhtml` has `xmlns=\"...xul\"`), unprefixed type selectors like `window`, `menulist`, `button`, `h3`, `p`, etc. will no longer match, so large parts of this stylesheet...
diff --git a/src/browser/base/content/zen-panels/popups.inc b/src/browser/base/content/zen-panels/popups.inc index bc9abc04e3a..2ff92383d49 100644 --- a/src/browser/base/content/zen-panels/popups.inc +++ b/src/browser/base/content/zen-panels/popups.inc @@ -30,10 +30,11 @@ <menuitem id="context_zenReorderWorkspaces" ...
3
6
zen-browser/desktop#13981
zen-browser/desktop
13,981
b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
[META]: Space routing gh-14044: Implement Space Routing (gh-13981) This PR aims to implement a version of Arc's Air Traffic Control feature natively into Zen. > [!NOTE] > This PR is based on #9042 > Thanks for providing the necessary pointers in your PR. --- ### Structure | Area | File | Purpose | |---|...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: [META]: Space routing", "scope_files": [ "crowdin.yml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `locales/en-US/browser/browser/` needed for: [META]: Space routing", "scope_fi...
[ { "subtask_id": "s1", "scope_files": [ "crowdin.yml" ], "solution_diff": "diff --git a/crowdin.yml b/crowdin.yml\nindex 469c8a1cddb..964f52d44df 100644\n--- a/crowdin.yml\n+++ b/crowdin.yml\n@@ -22,3 +22,5 @@ files:\n translation: browser/browser/zen-folders.ftl\n - source: en-US/browser...
[ { "subtask_id": "s7", "comment": "Swap out with Nucleo file later", "revised_diff": "diff --git a/src/browser/themes/shared/zen-icons/nucleo/arrow-corner-down-right.svg b/src/browser/themes/shared/zen-icons/nucleo/arrow-corner-down-right.svg\nnew file mode 100644\nindex 00000000000..18b9d18df5a\n--- /de...
diff --git a/crowdin.yml b/crowdin.yml index 469c8a1cddb..964f52d44df 100644 --- a/crowdin.yml +++ b/crowdin.yml @@ -22,3 +22,5 @@ files: translation: browser/browser/zen-folders.ftl - source: en-US/browser/browser/zen-boosts.ftl translation: browser/browser/zen-boosts.ftl + - source: en-US/browser/browse...
16
32
zen-browser/desktop#13598
zen-browser/desktop
13,598
818c448dfc3ed7507e9055c538fa2a05ecb6a6aa
1ac926bea21e0ea1482583196d427fb08ef8d73c
Add space and container sync - Created sync engine for syncing workspaces and containers - patched `ContextualIdentityService` to allow creating containers with specific IDs
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/browser/components/preferences/` needed for: Add space and container sync", "scope_files": [ "src/browser/components/preferences/sync-js.patch" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/servi...
[ { "subtask_id": "s1", "scope_files": [ "src/browser/components/preferences/sync-js.patch" ], "solution_diff": "diff --git a/src/browser/components/preferences/sync-js.patch b/src/browser/components/preferences/sync-js.patch\nnew file mode 100644\nindex 00000000000..5fcabf4c424\n--- /dev/null\n...
[ { "subtask_id": "s7", "comment": "For container tombstones, `parsed.key` is always a string (from `id.slice(...)`), but `ContextualIdentityService.remove/update/create` expect a numeric `userContextId`. This will cause container deletions from Sync to be skipped (remove will likely throw and is ignored in `...
diff --git a/src/browser/components/preferences/sync-js.patch b/src/browser/components/preferences/sync-js.patch new file mode 100644 index 00000000000..5fcabf4c424 --- /dev/null +++ b/src/browser/components/preferences/sync-js.patch @@ -0,0 +1,20 @@ +diff --git a/browser/components/preferences/sync.js b/browser/compon...
7
9
zen-browser/desktop#14047
zen-browser/desktop
14,047
880d61df16db2bc039636025482e07a9c42767d0
035085519475f9fdb0df16711278461ba077c6cb
"X" button to close update notice is not properly visible ### Preliminary Checks - [x] I have read and understood the important section above. - [x] I have searched existing issues and avoided creating duplicates. - [x] I am not filing an enhancement request. - [x] I have checked that this issue cannot be reproduced ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/zen/common/styles/` needed for: \"X\" button to close update notice is not properly visible", "scope_files": [ "src/zen/common/styles/zen-sidebar-notification.css" ] }, { "subtask_id": "s2", "goal": "Implement the chan...
[ { "subtask_id": "s1", "scope_files": [ "src/zen/common/styles/zen-sidebar-notification.css" ], "solution_diff": "diff --git a/src/zen/common/styles/zen-sidebar-notification.css b/src/zen/common/styles/zen-sidebar-notification.css\nindex fdddbe54978..b80f94e9b16 100644\n--- a/src/zen/common/sty...
[ { "subtask_id": "s1", "comment": "The heading is absolutely positioned with a hard-coded `width: calc(100% - 40px)`. This makes `flex: 1` a no-op (positioned elements don’t participate in flex layout) and makes the layout more brittle for text scaling/localization. You can keep the heading in normal flow an...
diff --git a/src/zen/common/styles/zen-sidebar-notification.css b/src/zen/common/styles/zen-sidebar-notification.css index fdddbe54978..b80f94e9b16 100644 --- a/src/zen/common/styles/zen-sidebar-notification.css +++ b/src/zen/common/styles/zen-sidebar-notification.css @@ -27,7 +27,7 @@ display: flex; position: re...
2
2
zen-browser/desktop#14007
zen-browser/desktop
14,007
b812bff07e07ac690cd2175a623317736b258911
d4a830ffb9281e1f6098a9cb179cfc8b4592699d
no-bug: Fixed boosts window not resizing back properly
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/zen/boosts/` needed for: no-bug: Fixed boosts window not resizing back properly", "scope_files": [ "src/zen/boosts/ZenBoostsEditor.mjs", "src/zen/boosts/zen-boosts.css" ] }, { "subtask_id": "s2", "goal": "Impleme...
[ { "subtask_id": "s1", "scope_files": [ "src/zen/boosts/ZenBoostsEditor.mjs", "src/zen/boosts/zen-boosts.css" ], "solution_diff": "diff --git a/src/zen/boosts/ZenBoostsEditor.mjs b/src/zen/boosts/ZenBoostsEditor.mjs\nindex c40a541d7b0..c65b45e16e3 100644\n--- a/src/zen/boosts/ZenBoostsEdi...
[ { "subtask_id": "s1", "comment": "`promiseDocumentFlushed` is not a standard `Window` API and does not appear anywhere else in this codebase. Calling it here will throw when switching back to the boost editor, preventing the resize/move logic from running.", "revised_diff": "diff --git a/src/zen/boosts/...
diff --git a/src/zen/boosts/ZenBoostsEditor.mjs b/src/zen/boosts/ZenBoostsEditor.mjs index c40a541d7b0..c65b45e16e3 100644 --- a/src/zen/boosts/ZenBoostsEditor.mjs +++ b/src/zen/boosts/ZenBoostsEditor.mjs @@ -374,12 +374,6 @@ export class nsZenBoostEditor { } windowElem.setAttribute("editor", "code"); - ...
4
5
zen-browser/desktop#14002
zen-browser/desktop
14,002
e04e910a6fa2fc2001c1daf3f3ed33962591d9af
1ea6dd7b6266218b62cd14659b3437e14148c656
no-bug: Change wine build download
[ { "subtask_id": "s1", "goal": "Implement the changes under `.github/workflows/` needed for: no-bug: Change wine build download", "scope_files": [ ".github/workflows/windows-release-build.yml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `configs/windows/` needed ...
[ { "subtask_id": "s1", "scope_files": [ ".github/workflows/windows-release-build.yml" ], "solution_diff": "diff --git a/.github/workflows/windows-release-build.yml b/.github/workflows/windows-release-build.yml\nindex d2570dbfd77..8bbfbebefe6 100644\n--- a/.github/workflows/windows-release-build...
[]
diff --git a/.github/workflows/windows-release-build.yml b/.github/workflows/windows-release-build.yml index d2570dbfd77..8bbfbebefe6 100644 --- a/.github/workflows/windows-release-build.yml +++ b/.github/workflows/windows-release-build.yml @@ -154,7 +154,7 @@ jobs: zlib1g-dev \ aria2 ...
2
2
zen-browser/desktop#13979
zen-browser/desktop
13,979
2311e183f1d1dccc749c82fde2d0795fc35e1724
b4c55ff368484251761e2d5a0b671985b1d2a44c
[META]: Boosts gh-13439: Implement dark mode boosts panel <img width="1021" height="653" alt="image" src="https://github.com/user-attachments/assets/b1ac0412-2c28-42dc-acf1-8efbb9178513" /> <img width="519" height="639" alt="image" src="https://github.com/user-attachments/assets/4e46134b-1f5c-4a86-a0b4-07e7ed8bbcf...
[ { "subtask_id": "s1", "goal": "Implement the changes under `locales/ar/browser/browser/` needed for: [META]: Boosts", "scope_files": [ "locales/ar/browser/browser/zen-boosts.ftl" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `locales/bg/browser/browser/` needed fo...
[ { "subtask_id": "s1", "scope_files": [ "locales/ar/browser/browser/zen-boosts.ftl" ], "solution_diff": "diff --git a/locales/ar/browser/browser/zen-boosts.ftl b/locales/ar/browser/browser/zen-boosts.ftl\nindex 7211fa124f6..eb42026a74a 100644\n--- a/locales/ar/browser/browser/zen-boosts.ftl\n++...
[ { "subtask_id": "s44", "comment": "```suggestion\n color-scheme: light dark;\n```", "revised_diff": "diff --git a/src/zen/boosts/zen-advanced-color-options.css b/src/zen/boosts/zen-advanced-color-options.css\nindex 4cc651de896..385d075ab78 100644\n--- a/src/zen/boosts/zen-advanced-color-options.css\n++...
diff --git a/locales/ar/browser/browser/zen-boosts.ftl b/locales/ar/browser/browser/zen-boosts.ftl index 7211fa124f6..eb42026a74a 100644 --- a/locales/ar/browser/browser/zen-boosts.ftl +++ b/locales/ar/browser/browser/zen-boosts.ftl @@ -29,9 +29,9 @@ zen-boost-css-picker = .tooltiptext = Pick Selector zen-boost-c...
44
48
zen-browser/desktop#13991
zen-browser/desktop
13,991
2311e183f1d1dccc749c82fde2d0795fc35e1724
3ed89ee2b7b7840a40514b3d516e18550692c608
no-bug: Sync upstream Firefox to version `151.0.3` This PR syncs the upstream Firefox to version 151.0.3. * ✅ All patches applied cleanly. @mr-cheffy please review and merge this PR.
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: no-bug: Sync upstream Firefox to version `151.0.3`", "scope_files": [ "README.md", "surfer.json" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `build/firefox-cache/` needed for:...
[ { "subtask_id": "s1", "scope_files": [ "README.md", "surfer.json" ], "solution_diff": "diff --git a/README.md b/README.md\nindex cb51a0f6129..f2655b75a6f 100644\n--- a/README.md\n+++ b/README.md\n@@ -34,8 +34,8 @@ Zen is a firefox-based browser with the aim of pushing your productivity t...
[]
diff --git a/README.md b/README.md index cb51a0f6129..f2655b75a6f 100644 --- a/README.md +++ b/README.md @@ -34,8 +34,8 @@ Zen is a firefox-based browser with the aim of pushing your productivity to a ne ### Firefox Versions -- [`Release`](https://zen-browser.app/download) - Is currently built using Firefox versio...
3
4
zen-browser/desktop#13987
zen-browser/desktop
13,987
8ea65cba48263a7d655cb0aceeaea1b28648a7c5
3496e4ecee378bfea7dd8c5d57c8c000ca245150
Cannot open Twilight without Nightly popup ### Preliminary Checks - [x] I have read and understood the important section above. - [x] I have searched existing issues and avoided creating duplicates. - [x] I am not filing an enhancement request. - [x] I have checked that this issue cannot be reproduced on Mozilla Fire...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/browser/components/urlbar/content/` needed for: Cannot open Twilight without Nightly popup", "scope_files": [ "src/browser/components/urlbar/content/UrlbarInput-mjs.patch" ] }, { "subtask_id": "s2", "goal": "Implement ...
[ { "subtask_id": "s1", "scope_files": [ "src/browser/components/urlbar/content/UrlbarInput-mjs.patch" ], "solution_diff": "diff --git a/src/browser/components/urlbar/content/UrlbarInput-mjs.patch b/src/browser/components/urlbar/content/UrlbarInput-mjs.patch\nindex f33a99404cc..43314bcc02f 10064...
[ { "subtask_id": "s3", "comment": "Inline comment spacing here doesn’t follow the typical Python style (2+ spaces before an inline comment). Using the standard spacing avoids lint noise if moz.configure is checked by style tooling.", "revised_diff": "diff --git a/src/toolkit/moz-configure.patch b/src/too...
diff --git a/src/browser/components/urlbar/content/UrlbarInput-mjs.patch b/src/browser/components/urlbar/content/UrlbarInput-mjs.patch index f33a99404cc..43314bcc02f 100644 --- a/src/browser/components/urlbar/content/UrlbarInput-mjs.patch +++ b/src/browser/components/urlbar/content/UrlbarInput-mjs.patch @@ -140,9 +140,...
3
3
zen-browser/desktop#13976
zen-browser/desktop
13,976
64e2e49a00c7b22cbaa90680116452615f5bef2b
0058ab898ba770fcd6778be531ff7f57e91a4502
New window does not auto focus url bar with zen.urlbar.replace-newtab set to false ### Preliminary Checks - [x] I have read and understood the important section above. - [x] I have searched existing issues and avoided creating duplicates. - [x] I am not filing an enhancement request. - [x] I have checked that this is...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.github/workflows/` needed for: New window does not auto focus url bar with zen.urlbar.replace-newtab set to false", "scope_files": [ ".github/workflows/sync-upstream.yml" ] }, { "subtask_id": "s2", "goal": "Implement the ...
[ { "subtask_id": "s1", "scope_files": [ ".github/workflows/sync-upstream.yml" ], "solution_diff": "diff --git a/.github/workflows/sync-upstream.yml b/.github/workflows/sync-upstream.yml\nindex e4bca915621..e2662de2192 100644\n--- a/.github/workflows/sync-upstream.yml\n+++ b/.github/workflows/sy...
[ { "subtask_id": "s3", "comment": "`#zen-site-data-icon-button image` sets `-moz-context-properties: fill, fill-opacity` but doesn’t set a `fill` value. Throughout this file, rules that use `-moz-context-properties: fill` also set `fill: currentColor` (e.g. icons.css:13-15), so `color` changes reliably drive...
diff --git a/.github/workflows/sync-upstream.yml b/.github/workflows/sync-upstream.yml index e4bca915621..e2662de2192 100644 --- a/.github/workflows/sync-upstream.yml +++ b/.github/workflows/sync-upstream.yml @@ -129,7 +129,7 @@ jobs: token: ${{ secrets.DEPLOY_KEY }} commit-message: "chore: Sync u...
7
12
zen-browser/desktop#13670
zen-browser/desktop
13,670
0a7ee3fcf0048c00b4e1e639b3c28a96b18a5f2f
0dbe7019d15beff12eb3b134d714d90f861576b0
no-bug: Sync upstream Firefox to version `150.0.3` This PR syncs the upstream Firefox to version 150.0.3. * ⚠️ Some patches did not apply cleanly. Please review them carefully. @mr-cheffy please review and merge this PR.
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: no-bug: Sync upstream Firefox to version `150.0.3`", "scope_files": [ "README.md", "surfer.json" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.github/workflows/` needed for: n...
[ { "subtask_id": "s1", "scope_files": [ "README.md", "surfer.json" ], "solution_diff": "diff --git a/README.md b/README.md\nindex 9df57ae26cf..f7b1a498cfd 100644\n--- a/README.md\n+++ b/README.md\n@@ -34,8 +34,8 @@ Zen is a firefox-based browser with the aim of pushing your productivity t...
[]
diff --git a/.github/workflows/sync-upstream.yml b/.github/workflows/sync-upstream.yml index a8f81b400e1..e4bca915621 100644 --- a/.github/workflows/sync-upstream.yml +++ b/.github/workflows/sync-upstream.yml @@ -129,7 +129,7 @@ jobs: token: ${{ secrets.DEPLOY_KEY }} commit-message: "chore: Sync u...
3
4
zen-browser/desktop#13977
zen-browser/desktop
13,977
64e2e49a00c7b22cbaa90680116452615f5bef2b
d555912e2ac7267dfedfc3129282ca035f034a7b
[META]: Boosts gh-13439: Add tests coverage for boosts
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: [META]: Boosts", "scope_files": [ "package.json" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/zen/boosts/` needed for: [META]: Boosts", "scope_files": [ "src/zen/boost...
[ { "subtask_id": "s1", "scope_files": [ "package.json" ], "solution_diff": "diff --git a/package.json b/package.json\nindex 6e7fd8fd098..c62853c08fa 100644\n--- a/package.json\n+++ b/package.json\n@@ -28,7 +28,7 @@\n \"surfer\": \"surfer\",\n \"test\": \"python3 scripts/run_tests.py\",\...
[ { "subtask_id": "s4", "comment": "## Unused variable, import, function or class\n\n<p>Unused function setBoost.</p>", "revised_diff": "diff --git a/src/zen/tests/boosts/head.js b/src/zen/tests/boosts/head.js\nindex 7514c6dea02..011447b43f9 100644\n--- a/src/zen/tests/boosts/head.js\n+++ b/src/zen/tests/...
diff --git a/package.json b/package.json index 6e7fd8fd098..c62853c08fa 100644 --- a/package.json +++ b/package.json @@ -28,7 +28,7 @@ "surfer": "surfer", "test": "python3 scripts/run_tests.py", "test:dbg": "python3 scripts/run_tests.py --jsdebugger --debug-on-failure", - "test:gtest": "cd engine && ....
4
24
zen-browser/desktop#13965
zen-browser/desktop
13,965
c7818fe35554b76932754f30e26a7b8e2c212139
39746d3d84c2bef01e8f0bd0d41a82043cdb722c
Boosts "Text Color" bugs out if dragged while using auto theme ### Preliminary Checks - [x] I have read and understood the important section above. - [x] I have searched existing issues and avoided creating duplicates. - [x] I am not filing an enhancement request. - [x] I have checked that this issue cannot be reprod...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/browser/components/urlbar/content/` needed for: Boosts \"Text Color\" bugs out if dragged while using auto theme", "scope_files": [ "src/browser/components/urlbar/content/UrlbarInput-mjs.patch" ] }, { "subtask_id": "s2", ...
[ { "subtask_id": "s1", "scope_files": [ "src/browser/components/urlbar/content/UrlbarInput-mjs.patch" ], "solution_diff": "diff --git a/src/browser/components/urlbar/content/UrlbarInput-mjs.patch b/src/browser/components/urlbar/content/UrlbarInput-mjs.patch\nindex bb291a8b8a3..f4e335a6dc0 10064...
[ { "subtask_id": "s2", "comment": "The comment has a grammatical typo: \"they dot\" should be \"the dot\".", "revised_diff": "diff --git a/src/zen/boosts/ZenBoostsEditor.mjs b/src/zen/boosts/ZenBoostsEditor.mjs\nindex 723229743f3..6956c124a48 100644\n--- a/src/zen/boosts/ZenBoostsEditor.mjs\n+++ b/src/ze...
diff --git a/src/browser/components/urlbar/content/UrlbarInput-mjs.patch b/src/browser/components/urlbar/content/UrlbarInput-mjs.patch index bb291a8b8a3..f4e335a6dc0 100644 --- a/src/browser/components/urlbar/content/UrlbarInput-mjs.patch +++ b/src/browser/components/urlbar/content/UrlbarInput-mjs.patch @@ -1,5 +1,5 @@...
2
3
zen-browser/desktop#13964
zen-browser/desktop
13,964
193d004a37bbe6cca5c27ad1f39dd529d4edc89d
dee4cf176abc699ea51fe37e799adccf11a98060
Cannot open Twilight without Nightly popup ### Preliminary Checks - [x] I have read and understood the important section above. - [x] I have searched existing issues and avoided creating duplicates. - [x] I am not filing an enhancement request. - [x] I have checked that this issue cannot be reproduced on Mozilla Fire...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Cannot open Twilight without Nightly popup", "scope_files": [ "surfer.json" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/browser/installer/windows/nsis/` needed for: Cannot open...
[ { "subtask_id": "s1", "scope_files": [ "surfer.json" ], "solution_diff": "diff --git a/surfer.json b/surfer.json\nindex a53e9df9a16..fefc53dd411 100644\n--- a/surfer.json\n+++ b/surfer.json\n@@ -20,7 +20,7 @@\n \"brandShortName\": \"Zen\",\n \"brandFullName\": \"Zen Browser\",\n ...
[]
diff --git a/src/browser/installer/windows/nsis/defines-nsi-in.patch b/src/browser/installer/windows/nsis/defines-nsi-in.patch index 862ac618b77..f423ee10dde 100644 --- a/src/browser/installer/windows/nsis/defines-nsi-in.patch +++ b/src/browser/installer/windows/nsis/defines-nsi-in.patch @@ -1,8 +1,16 @@ diff --git a/...
2
2
zen-browser/desktop#13938
zen-browser/desktop
13,938
2c11b9295e72038edb3a26e64aaa7ba894109883
591edceb23e8ce2da5f16035cb5affed5bbad4ec
Add Boosts animated icons and minor adjustments Extends #12655 1. Added animated icon for Boosts 2. Improved linear gradients for Downloads and Spaces icons
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/browser/themes/shared/zen-icons/common/library/` needed for: Add Boosts animated icons and minor adjustments", "scope_files": [ "src/browser/themes/shared/zen-icons/common/library/library-boosts-active.svg", "src/browser/themes/...
[ { "subtask_id": "s1", "scope_files": [ "src/browser/themes/shared/zen-icons/common/library/library-boosts-active.svg", "src/browser/themes/shared/zen-icons/common/library/library-boosts.svg", "src/browser/themes/shared/zen-icons/common/library/library-downloads-active.svg", "src/brow...
[]
diff --git a/src/browser/themes/shared/zen-icons/common/library/library-boosts-active.svg b/src/browser/themes/shared/zen-icons/common/library/library-boosts-active.svg new file mode 100644 index 00000000000..747efb9b9fb --- /dev/null +++ b/src/browser/themes/shared/zen-icons/common/library/library-boosts-active.svg @@...
1
4
zen-browser/desktop#13893
zen-browser/desktop
13,893
89267dfea01466a78aa4d2229f0f2d1d3e57eaa5
a5907737cf3bea903ed3ab611a8794f66eb4e62b
Boost color customization doesn't persist ### Preliminary Checks - [x] I have read and understood the important section above. - [x] I have searched existing issues and avoided creating duplicates. - [x] I am not filing an enhancement request. - [x] I have checked that this issue cannot be reproduced on Mozilla Firef...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/image/` needed for: Boost color customization doesn't persist", "scope_files": [ "src/image/AutoRestoreSVGState-h.patch" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/layout/base/` needed for: Bo...
[ { "subtask_id": "s1", "scope_files": [ "src/image/AutoRestoreSVGState-h.patch" ], "solution_diff": "diff --git a/src/image/AutoRestoreSVGState-h.patch b/src/image/AutoRestoreSVGState-h.patch\nnew file mode 100644\nindex 00000000000..bd650213592\n--- /dev/null\n+++ b/src/image/AutoRestoreSVGSta...
[ { "subtask_id": "s6", "comment": "The new check `content->HasBeenInUAWidget()` un-exempts all content inside any UA widget shadow tree, but the doc comment immediately above still claims scrollbars (and other native-anonymous UI) are exempt. In current Firefox, several pieces of UA-rendered chrome — most no...
diff --git a/src/image/AutoRestoreSVGState-h.patch b/src/image/AutoRestoreSVGState-h.patch new file mode 100644 index 00000000000..bd650213592 --- /dev/null +++ b/src/image/AutoRestoreSVGState-h.patch @@ -0,0 +1,14 @@ +diff --git a/image/AutoRestoreSVGState.h b/image/AutoRestoreSVGState.h +index be639a7b78c13c2d56be49a...
6
8
zen-browser/desktop#13886
zen-browser/desktop
13,886
89267dfea01466a78aa4d2229f0f2d1d3e57eaa5
b04f1559864de955abef33ef7ffbd2271eb4077a
no-bug: New Crowdin updates
[ { "subtask_id": "s1", "goal": "Implement the changes under `locales/ca/browser/browser/` needed for: no-bug: New Crowdin updates", "scope_files": [ "locales/ca/browser/browser/zen-boosts.ftl" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `locales/ca/browser/browse...
[ { "subtask_id": "s1", "scope_files": [ "locales/ca/browser/browser/zen-boosts.ftl" ], "solution_diff": "diff --git a/locales/ca/browser/browser/zen-boosts.ftl b/locales/ca/browser/browser/zen-boosts.ftl\nindex 877c5afb2df..588c417b02d 100644\n--- a/locales/ca/browser/browser/zen-boosts.ftl\n++...
[ { "subtask_id": "s3", "comment": "`zen-workspace-shortcut-create` uses mixed terminology (“Workspace”) while surrounding strings in this file consistently translate workspace as “pracovní prostor” (e.g., `zen-workspace-shortcut-switch-*`, `zen-workspace-shortcut-forward/backward`). Consider using the same t...
diff --git a/locales/ca/browser/browser/preferences/zen-preferences.ftl b/locales/ca/browser/browser/preferences/zen-preferences.ftl index b7477fb9778..853f1628742 100644 --- a/locales/ca/browser/browser/preferences/zen-preferences.ftl +++ b/locales/ca/browser/browser/preferences/zen-preferences.ftl @@ -281,7 +281,7 @@...
10
10
zen-browser/desktop#13866
zen-browser/desktop
13,866
346219c3b4877cc325c65e8934d8ed7c498498f1
058cbefde55922bfa103d069af587519e28bbc2f
New Crowdin updates
[ { "subtask_id": "s1", "goal": "Implement the changes under `locales/ar/browser/browser/` needed for: New Crowdin updates", "scope_files": [ "locales/ar/browser/browser/zen-boosts.ftl" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `locales/ar/browser/browser/prefer...
[ { "subtask_id": "s1", "scope_files": [ "locales/ar/browser/browser/zen-boosts.ftl" ], "solution_diff": "diff --git a/locales/ar/browser/browser/zen-boosts.ftl b/locales/ar/browser/browser/zen-boosts.ftl\nnew file mode 100644\nindex 00000000000..7211fa124f6\n--- /dev/null\n+++ b/locales/ar/brow...
[]
diff --git a/locales/ar/browser/browser/preferences/zen-preferences.ftl b/locales/ar/browser/browser/preferences/zen-preferences.ftl index c8d4332a57e..a7b2acc9217 100644 --- a/locales/ar/browser/browser/preferences/zen-preferences.ftl +++ b/locales/ar/browser/browser/preferences/zen-preferences.ftl @@ -281,6 +281,7 @@...
82
97
zen-browser/desktop#13875
zen-browser/desktop
13,875
7f08cf437abbacaf7b381af64c5ea6ffd8c503b6
8356d37a331a20132509890dde659690905fd75a
Closing a window lead sometimes to window sync to stop working ### Preliminary Checks - [x] I have read and understood the important section above. - [x] I have searched existing issues and avoided creating duplicates. - [x] I am not filing an enhancement request. - [x] I have checked that this issue cannot be reprod...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Closing a window lead sometimes to window sync to stop working", "scope_files": [ "README.md", "surfer.json" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `build/firefox-cache/`...
[ { "subtask_id": "s1", "scope_files": [ "README.md", "surfer.json" ], "solution_diff": "diff --git a/README.md b/README.md\nindex 5e46f4dc902..cb51a0f6129 100644\n--- a/README.md\n+++ b/README.md\n@@ -34,8 +34,8 @@ Zen is a firefox-based browser with the aim of pushing your productivity t...
[]
diff --git a/README.md b/README.md index 5e46f4dc902..cb51a0f6129 100644 --- a/README.md +++ b/README.md @@ -34,8 +34,8 @@ Zen is a firefox-based browser with the aim of pushing your productivity to a ne ### Firefox Versions -- [`Release`](https://zen-browser.app/download) - Is currently built using Firefox versio...
4
5
zen-browser/desktop#13882
zen-browser/desktop
13,882
e82012ff1c5bab351afecea714ca1f3aa4fb336b
8b8ebcffd5b4917ec82ed50d2cb7317946bf5ec2
Boost color customization doesn't persist ### Preliminary Checks - [x] I have read and understood the important section above. - [x] I have searched existing issues and avoided creating duplicates. - [x] I am not filing an enhancement request. - [x] I have checked that this issue cannot be reproduced on Mozilla Firef...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/accessible/base/` needed for: Boost color customization doesn't persist", "scope_files": [ "src/accessible/base/TextAttrs-cpp.patch" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/accessible/windo...
[ { "subtask_id": "s1", "scope_files": [ "src/accessible/base/TextAttrs-cpp.patch" ], "solution_diff": "diff --git a/src/accessible/base/TextAttrs-cpp.patch b/src/accessible/base/TextAttrs-cpp.patch\nnew file mode 100644\nindex 00000000000..b88ca20d483\n--- /dev/null\n+++ b/src/accessible/base/T...
[ { "subtask_id": "s14", "comment": "This file removes app menu/profile avatar styling and a root variable, which appears unrelated to the PR’s stated goal (boosts + linear gradients). If this is intentional, consider moving it to a dedicated UI/style PR or documenting why it’s needed here to keep the change ...
diff --git a/src/accessible/base/TextAttrs-cpp.patch b/src/accessible/base/TextAttrs-cpp.patch new file mode 100644 index 00000000000..b88ca20d483 --- /dev/null +++ b/src/accessible/base/TextAttrs-cpp.patch @@ -0,0 +1,18 @@ +diff --git a/accessible/base/TextAttrs.cpp b/accessible/base/TextAttrs.cpp +index d2ce06bef67ec...
14
27
zen-browser/desktop#13847
zen-browser/desktop
13,847
8f905e7abd9d4b0c145ea9f5ad3b02190308831f
f8959c4576dd342df492dca436b6f183c3d623a7
Boost color customization doesn't persist ### Preliminary Checks - [x] I have read and understood the important section above. - [x] I have searched existing issues and avoided creating duplicates. - [x] I am not filing an enhancement request. - [x] I have checked that this issue cannot be reproduced on Mozilla Firef...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/gfx/layers/` needed for: Boost color customization doesn't persist", "scope_files": [ "src/gfx/layers/AnimationInfo-cpp.patch" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/layout/base/` needed f...
[ { "subtask_id": "s1", "scope_files": [ "src/gfx/layers/AnimationInfo-cpp.patch" ], "solution_diff": "diff --git a/src/gfx/layers/AnimationInfo-cpp.patch b/src/gfx/layers/AnimationInfo-cpp.patch\nindex aa58cdcbcc2..7a91671c667 100644\n--- a/src/gfx/layers/AnimationInfo-cpp.patch\n+++ b/src/gfx/...
[ { "subtask_id": "s12", "comment": "ZenBoostsChild is still registered for the DOMWindowCreated JSWindowActor event (see ZenActorsManager.sys.mjs), but this class no longer defines handleEvent(). JSWindowActor \"events\" are dispatched to handleEvent, so this can cause runtime errors when DOMWindowCreated fi...
diff --git a/src/gfx/layers/AnimationInfo-cpp.patch b/src/gfx/layers/AnimationInfo-cpp.patch index aa58cdcbcc2..7a91671c667 100644 --- a/src/gfx/layers/AnimationInfo-cpp.patch +++ b/src/gfx/layers/AnimationInfo-cpp.patch @@ -1,5 +1,5 @@ diff --git a/gfx/layers/AnimationInfo.cpp b/gfx/layers/AnimationInfo.cpp -index 1d...
13
25
zenorocha/clipboard.js#807
zenorocha/clipboard.js
807
98c96a1136f78bd0b6fc5f5d3da964550fc9cd17
0df402284eae270cf90a377e22af990ae69fbcae
Trigger loses focus after copy event ## 🐛 Bug Report Setting keyboard focus on one of the "Copy" buttons and activating it, focus is then lost/reset to the start of the page. While browsers try to error-correct for this (meaning that a subsequent Tab moves to the next focusable element), the issue becomes evident ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/` needed for: Trigger loses focus after copy event", "scope_files": [ "src/clipboard.js" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `test/` needed for: Trigger loses focus after copy event", "s...
[ { "subtask_id": "s1", "scope_files": [ "src/clipboard.js" ], "solution_diff": "diff --git a/src/clipboard.js b/src/clipboard.js\nindex 34aef606..ee5fe56b 100644\n--- a/src/clipboard.js\n+++ b/src/clipboard.js\n@@ -86,7 +86,6 @@ class Clipboard extends Emitter {\n if (trigger) {\n ...
[ { "subtask_id": "s2", "comment": "Hey, could you please update this test to ensure that current `document.activeElement` is the trigger? You can use the following approach:\r\n\r\n```javascript\r\n it('should clear text selection', (done) => {\r\n let clipboard = new Clipboard('.btn');\r\n\r\n ...
diff --git a/src/clipboard.js b/src/clipboard.js index 34aef606..ee5fe56b 100644 --- a/src/clipboard.js +++ b/src/clipboard.js @@ -86,7 +86,6 @@ class Clipboard extends Emitter { if (trigger) { trigger.focus(); } - document.activeElement.blur(); window.getSelection().removeA...
2
2
zenorocha/clipboard.js#835
zenorocha/clipboard.js
835
07ba4a89dae8c6679c3694176969c0b3a5ffffb5
8dbb6ad74709b7d45c1404b5ee26a53a76bf6b6c
chore(deps): bump nanoid and mocha Bumps [nanoid](https://github.com/ai/nanoid) to 3.3.3 and updates ancestor dependency [mocha](https://github.com/mochajs/mocha). These dependencies need to be updated together. Updates `nanoid` from 3.1.12 to 3.3.3 <details> <summary>Changelog</summary> <p><em>Sourced from <a href="...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: chore(deps): bump nanoid and mocha", "scope_files": [ "package-lock.json", "package.json" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "package-lock.json", "package.json" ], "solution_diff": "diff --git a/package-lock.json b/package-lock.json\nindex 0b56b914..66fa4a26 100644\n--- a/package-lock.json\n+++ b/package-lock.json\n@@ -32,7 +32,7 @@\n \"karma-sinon\": \"^1.0.4\",\...
[]
diff --git a/package-lock.json b/package-lock.json index 0b56b914..66fa4a26 100644 --- a/package-lock.json +++ b/package-lock.json @@ -32,7 +32,7 @@ "karma-sinon": "^1.0.4", "karma-webpack": "^5.0.0-alpha.5", "lint-staged": "^10.5.3", - "mocha": "^8.2.1", + "mocha": "^10.1.0", ...
1
2
zenorocha/clipboard.js#808
zenorocha/clipboard.js
808
9b0c87b184c064e6dedaf8651532e729e27518d4
ca882fd16f1b088dabc5750dcd891235764aa140
Support more HTML input types. Close #800 <!-- Please make sure to read the Pull Request Guidelines: https://github.com/zenorocha/clipboard.js/blob/master/contributing.md#proposing-pull-requests --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this...
[ { "subtask_id": "s1", "goal": "Implement the changes under `demo/` needed for: Support more HTML input types. Close #800", "scope_files": [ "demo/target-input-number.html" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `dist/` needed for: Support more HTML input ty...
[ { "subtask_id": "s1", "scope_files": [ "demo/target-input-number.html" ], "solution_diff": "diff --git a/demo/target-input-number.html b/demo/target-input-number.html\nnew file mode 100644\nindex 00000000..c5373845\n--- /dev/null\n+++ b/demo/target-input-number.html\n@@ -0,0 +1,37 @@\n+<!DOCTY...
[ { "subtask_id": "s4", "comment": "Just remember to remove the `it.only`.", "revised_diff": "diff --git a/test/actions/copy.js b/test/actions/copy.js\nindex 201c1d68..6c13b5d5 100644\n--- a/test/actions/copy.js\n+++ b/test/actions/copy.js\n@@ -51,5 +51,19 @@ describe('ClipboardActionCopy', () => {\n \n ...
diff --git a/demo/target-input-number.html b/demo/target-input-number.html new file mode 100644 index 00000000..c5373845 --- /dev/null +++ b/demo/target-input-number.html @@ -0,0 +1,37 @@ +<!DOCTYPE html> +<html lang="en"> + <head> + <meta charset="UTF-8" /> + <title>target-input-number</title> + <meta name="...
4
5
zenorocha/clipboard.js#793
zenorocha/clipboard.js
793
9698b1176ae68bc8d9a3507aa8a6fc935099d9fe
b716947eb94ec91231d0c9edcfb623e0c9acb8dc
Event action is now a function not a string <!-- ! PLEASE HELP US HELP YOU ! Bugs are fixed faster if you include: - a repro repository to inspect the code - an url to see the problem live --> ## 🐛 Bug Report Event action parameter used to return a string but now returns a function. The JSFid...
[ { "subtask_id": "s1", "goal": "Implement the changes under `demo/` needed for: Event action is now a function not a string", "scope_files": [ "demo/constructor-node.html", "demo/constructor-nodelist.html", "demo/constructor-selector.html", "demo/function-target.html", "demo...
[ { "subtask_id": "s1", "scope_files": [ "demo/constructor-node.html", "demo/constructor-nodelist.html", "demo/constructor-selector.html", "demo/function-target.html", "demo/function-text.html", "demo/target-div.html", "demo/target-input.html", "demo/target-text...
[]
diff --git a/demo/constructor-node.html b/demo/constructor-node.html index 2135152d..2780ebc2 100644 --- a/demo/constructor-node.html +++ b/demo/constructor-node.html @@ -20,11 +20,15 @@ var clipboard = new ClipboardJS(btn); clipboard.on('success', function (e) { - console.log(e); + consol...
4
12
zenorocha/clipboard.js#355
zenorocha/clipboard.js
355
402c9ee17bed6f273bcbc7efa81874fd9a50b84c
44edd008bff9bf29e783b471ef36c81f30637a5f
Add API to check if copy action is supported Code examples * all commands are checked for support - http://codepen.io/netsi1964/pen/QbLLGW * "copy" command is checked for support - http://jsfiddle.net/the_ghost/679drp3r/ (`!!document.queryCommandSupported && !!document.queryCommandSupported('copy')`) I think i...
[ { "subtask_id": "s1", "goal": "Implement the changes under `dist/` needed for: Add API to check if copy action is supported", "scope_files": [ "dist/clipboard.js", "dist/clipboard.min.js" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/` needed for: Add A...
[ { "subtask_id": "s1", "scope_files": [ "dist/clipboard.js", "dist/clipboard.min.js" ], "solution_diff": "diff --git a/dist/clipboard.js b/dist/clipboard.js\nindex 60741829..b31aec3d 100644\n--- a/dist/clipboard.js\n+++ b/dist/clipboard.js\n@@ -728,6 +728,20 @@ module.exports = E;\n ...
[]
diff --git a/dist/clipboard.js b/dist/clipboard.js index 60741829..b31aec3d 100644 --- a/dist/clipboard.js +++ b/dist/clipboard.js @@ -728,6 +728,20 @@ module.exports = E; this.clipboardAction = null; } } + }], [{ + key: 'isSupported', + va...
3
4
zenorocha/clipboard.js#749
zenorocha/clipboard.js
749
734d36b6ffe3346304904a44f12e4f3f69330101
d1eac52d40c498d6003b07a5e455f9443b189a61
Isolate actions strategies in order to code improvement and programmatic usage. <!-- Please make sure to read the Pull Request Guidelines: https://github.com/zenorocha/clipboard.js/blob/master/contributing.md#proposing-pull-requests --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Isolate actions strategies in order to code improvement and programmatic usage.", "scope_files": [ ".gitignore" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `demo/` needed for: Isola...
[ { "subtask_id": "s1", "scope_files": [ ".gitignore" ], "solution_diff": "diff --git a/.gitignore b/.gitignore\nindex ff4dcd82..d7aa9985 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -4,3 +4,4 @@ bower_components\n node_modules\n yarn-error.log\n yarn.lock\n+.DS_Store\n", "summary": "Edite...
[]
diff --git a/.gitignore b/.gitignore index ff4dcd82..d7aa9985 100644 --- a/.gitignore +++ b/.gitignore @@ -4,3 +4,4 @@ bower_components node_modules yarn-error.log yarn.lock +.DS_Store diff --git a/demo/target-programmatic-copy.html b/demo/target-programmatic-copy.html new file mode 100644 index 00000000..0f00ded7 -...
9
22
zenorocha/clipboard.js#719
zenorocha/clipboard.js
719
5ea83e4473a2e2fbe01a4af8702ca3d3e318be64
43aa5786c9d6e7e5c46cdc9145476cbe339d9a46
Update dev dependencies. This PR updates the dev dependencies of the project doing the following: - Update webpack from 4 to 5 - Update Babel to the latest version - Update test frameworks dependencies - Update the test environment to support webpack 5 - As recommended on [karma-webpack](https://github.com/r...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Update dev dependencies.", "scope_files": [ "karma.conf.js", "package-lock.json", "package.json" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `dist/` needed for: Update d...
[ { "subtask_id": "s1", "scope_files": [ "karma.conf.js", "package-lock.json", "package.json" ], "solution_diff": "diff --git a/karma.conf.js b/karma.conf.js\nindex 93af9e81..ea06e890 100644\n--- a/karma.conf.js\n+++ b/karma.conf.js\n@@ -1,30 +1,36 @@\n-var webpackConfig = require('....
[ { "subtask_id": "s1", "comment": "Just to keep in mind to change this alpha version when having stable v5.\r\n\r\nhttps://github.com/ryanclark/karma-webpack/releases/tag/v5.0.0-alpha.5", "revised_diff": "diff --git a/package.json b/package.json\nindex e479d7c0..6789c577 100644\n--- a/package.json\n+++ b...
diff --git a/dist/clipboard.js b/dist/clipboard.js index 95f5910e..23e2bfc8 100644 --- a/dist/clipboard.js +++ b/dist/clipboard.js @@ -1,7 +1,7 @@ /*! * clipboard.js v2.0.6 * https://clipboardjs.com/ - * + * * Licensed MIT © Zeno Rocha */ (function webpackUniversalModuleDefinition(root, factory) { @@ -14,457...
2
5
zenorocha/clipboard.js#720
zenorocha/clipboard.js
720
221efae529a9d2eef34aade78879240c6ba00da6
ddb5adc6f88ecd237462cab60fa48b5f868a35ac
Remove unnecessary code and add node version control This PR remove `import listen from 'good-listener'` dependency from `test/clipboard.js` and add `.nvmrc` to the project to control which Node version we will be using while running the project.
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Remove unnecessary code and add node version control", "scope_files": [ ".nvmrc" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `dist/` needed for: Remove unnecessary code and add node...
[ { "subtask_id": "s1", "scope_files": [ ".nvmrc" ], "solution_diff": "diff --git a/.nvmrc b/.nvmrc\nnew file mode 100644\nindex 00000000..8351c193\n--- /dev/null\n+++ b/.nvmrc\n@@ -0,0 +1,1 @@\n+14\n", "summary": "Edited 1 file(s) in (root)/" }, { "subtask_id": "s2", "scope_file...
[]
diff --git a/.nvmrc b/.nvmrc new file mode 100644 index 00000000..8351c193 --- /dev/null +++ b/.nvmrc @@ -0,0 +1,1 @@ +14 diff --git a/dist/clipboard.js b/dist/clipboard.js index d3c4a942..23e2bfc8 100644 --- a/dist/clipboard.js +++ b/dist/clipboard.js @@ -71,7 +71,7 @@ var ClipboardAction = /*#__PURE__*/function () { ...
3
3
zenorocha/clipboard.js#743
zenorocha/clipboard.js
743
7dea403fbb5257809623cd1d635bd4a3878ea982
5c27fe02b84f05f0abafa4c5ccbfbe11310b242b
SyntaxError: Unexpected token ')' clipboard.js:17 in 2.0.7 <!-- PhantomJS 2.1.1 (Linux 0.0.0) ERROR SyntaxError: Unexpected token ')' at bower_components/clipboard/dist/clipboard.js:17 --> ## 🐛 Bug Report In dist/clipboard.js in v2.0.7, there's this bizarre number `134:` on line 20 The referen...
[ { "subtask_id": "s1", "goal": "Implement the changes under `dist/` needed for: SyntaxError: Unexpected token ')' clipboard.js:17 in 2.0.7", "scope_files": [ "dist/clipboard.js", "dist/clipboard.min.js" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "dist/clipboard.js", "dist/clipboard.min.js" ], "solution_diff": "diff --git a/dist/clipboard.js b/dist/clipboard.js\nindex 23e2bfc8..d54de7e1 100644\n--- a/dist/clipboard.js\n+++ b/dist/clipboard.js\n@@ -1,5 +1,5 @@\n /*!\n- * clipboard.js v2.0.6\n...
[]
diff --git a/dist/clipboard.js b/dist/clipboard.js index 23e2bfc8..d54de7e1 100644 --- a/dist/clipboard.js +++ b/dist/clipboard.js @@ -1,5 +1,5 @@ /*! - * clipboard.js v2.0.6 + * clipboard.js v2.0.8 * https://clipboardjs.com/ * * Licensed MIT © Zeno Rocha @@ -14,19 +14,25 @@ else root["ClipboardJS"] = facto...
1
2
zenorocha/clipboard.js#733
zenorocha/clipboard.js
733
17be1af63e685963991571ef5adbf988c087b3a3
c23b30d052c451998858b4202a2cc0df2a07e17e
removing element after selection <!-- Please make sure to read the Pull Request Guidelines: https://github.com/zenorocha/clipboard.js/blob/master/contributing.md#proposing-pull-requests --> Closes Issue #732 <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of cha...
[ { "subtask_id": "s1", "goal": "Implement the changes under `src/` needed for: removing element after selection", "scope_files": [ "src/clipboard-action.js" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `test/` needed for: removing element after selection", "sc...
[ { "subtask_id": "s1", "scope_files": [ "src/clipboard-action.js" ], "solution_diff": "diff --git a/src/clipboard-action.js b/src/clipboard-action.js\nindex c7d3cf42..ab6a5f65 100644\n--- a/src/clipboard-action.js\n+++ b/src/clipboard-action.js\n@@ -42,18 +42,10 @@ class ClipboardAction {\n \n ...
[ { "subtask_id": "s2", "comment": "Nice! I don't know about the `xit` to skip tests in Mocha.", "revised_diff": "diff --git a/test/clipboard-action.js b/test/clipboard-action.js\nindex 8d5cc624..b589b4c5 100644\n--- a/test/clipboard-action.js\n+++ b/test/clipboard-action.js\n@@ -47,7 +47,9 @@ describe('C...
diff --git a/src/clipboard-action.js b/src/clipboard-action.js index c7d3cf42..ab6a5f65 100644 --- a/src/clipboard-action.js +++ b/src/clipboard-action.js @@ -42,18 +42,10 @@ class ClipboardAction { /** * Creates a fake textarea element, sets its value from `text` property, - * and makes a selection on it. ...
2
2
zenorocha/clipboard.js#731
zenorocha/clipboard.js
731
982d5ef906e93e14ffb2064a8834e378a5893dd3
20b70bdbca56ce7801698930284639535c732cc1
feat: add linter and linter action **What kind of change does this PR introduce?** (check at least one) - [ ] Bugfix - [x] Feature - [x] Code style update - [x] Refactor - [ ] Build-related changes - [ ] Other, please describe: **Does this PR introduce a breaking change?** (check one) - [ ] Yes - [x] No...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: feat: add linter and linter action", "scope_files": [ ".eslintignore", ".eslintrc.json", "package-lock.json", "package.json" ] }, { "subtask_id": "s2", "goal": "Implement the changes ...
[ { "subtask_id": "s1", "scope_files": [ ".eslintignore", ".eslintrc.json", "package-lock.json", "package.json" ], "solution_diff": "diff --git a/.eslintignore b/.eslintignore\nnew file mode 100644\nindex 00000000..87305477\n--- /dev/null\n+++ b/.eslintignore\n@@ -0,0 +1,12 @@\...
[ { "subtask_id": "s1", "comment": "another small question is, why we added the 'sort-package-json' here, can you share what is the intention with this addition here =)? we want to have as few dependencies as possible ", "revised_diff": "diff --git a/package.json b/package.json\nindex c23bced9..812aea25 1...
diff --git a/.eslintignore b/.eslintignore new file mode 100644 index 00000000..87305477 --- /dev/null +++ b/.eslintignore @@ -0,0 +1,12 @@ +# Ignore artifacts: +dist + +lib +npm-debug.log +bower_components +node_modules +yarn-error.log +yarn.lock + +src/*.ts +/*.js diff --git a/.eslintrc.json b/.eslintrc.json new file...
4
8
zenorocha/clipboard.js#729
zenorocha/clipboard.js
729
119edb067d7436c8bd9b8d9ee7f0d9838a96ae80
8718bdd2a287c2dc3b2e6410017b1addef30c564
Chore upgrade husky **What kind of change does this PR introduce?** (check at least one) - [ ] Bugfix - [ ] Feature - [ ] Code style update - [ ] Refactor - [ ] Build-related changes - [x] Other, please describe: This PR adds Husky v.5.x.x to improve the triggers of Git hooks. **Does this PR introduce a bre...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Chore upgrade husky", "scope_files": [ "package-lock.json", "package.json" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.husky/` needed for: Chore upgrade husky", "scope_f...
[ { "subtask_id": "s1", "scope_files": [ "package-lock.json", "package.json" ], "solution_diff": "diff --git a/package-lock.json b/package-lock.json\nindex cde2cdf5..ce794c4c 100644\n--- a/package-lock.json\n+++ b/package-lock.json\n@@ -2058,12 +2058,6 @@\n \"tslib\": \"^1.9.0\"\n ...
[]
diff --git a/.husky/.gitignore b/.husky/.gitignore new file mode 100644 index 00000000..c9cdc63b --- /dev/null +++ b/.husky/.gitignore @@ -0,0 +1,1 @@ +_ \ No newline at end of file diff --git a/.husky/pre-commit b/.husky/pre-commit new file mode 100755 index 00000000..d37daa07 --- /dev/null +++ b/.husky/pre-commit @@ ...
2
4
zenorocha/clipboard.js#726
zenorocha/clipboard.js
726
2b48909ff1fb6da1378a3a6bc81a61a67f629dc2
94a9d8d3ea8323b91e28cf81105060552b0d3448
removing travis config <!-- Please make sure to read the Pull Request Guidelines: https://github.com/zenorocha/clipboard.js/blob/master/contributing.md#proposing-pull-requests --> This PR removes Travis config file from, this is part of our migration to Github actions <!-- PULL REQUEST TEMPLATE --> <!-- (Upda...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: removing travis config", "scope_files": [ ".travis.yml", "readme.md" ] } ]
[ { "subtask_id": "s1", "scope_files": [ ".travis.yml", "readme.md" ], "solution_diff": "diff --git a/.travis.yml b/.travis.yml\ndeleted file mode 100644\nindex a4bb7b94..00000000\n--- a/.travis.yml\n+++ /dev/null\n@@ -1,4 +0,0 @@\n-sudo: false\n-language: node_js\n-node_js:\n- - stable\n...
[]
diff --git a/.travis.yml b/.travis.yml deleted file mode 100644 index a4bb7b94..00000000 --- a/.travis.yml +++ /dev/null @@ -1,4 +0,0 @@ -sudo: false -language: node_js -node_js: - - stable diff --git a/readme.md b/readme.md index 91467688..c552448f 100644 --- a/readme.md +++ b/readme.md @@ -1,6 +1,6 @@ # clipboard.j...
1
2
zenorocha/clipboard.js#723
zenorocha/clipboard.js
723
41c73cb7ebff5d71becf2ba2a8038d884227a534
40bf3736c405be24e810f3ace102e23b39c4fe87
Add GH templates ## Description It will enable templates for new issues and PR's.
[ { "subtask_id": "s1", "goal": "Implement the changes under `.github/` needed for: Add GH templates", "scope_files": [ ".github/PULL_REQUEST_TEMPLATE.md", ".github/issue_template.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.github/ISSUE_TEMPLATE/` need...
[ { "subtask_id": "s1", "scope_files": [ ".github/PULL_REQUEST_TEMPLATE.md", ".github/issue_template.md" ], "solution_diff": "diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md\nnew file mode 100644\nindex 00000000..b2f50c8d\n--- /dev/null\n+++ b/.github/PULL_...
[ { "subtask_id": "s1", "comment": "What about creating an approach that makes issue and test declaration optional or less opinionated? I mean, for non-code PRs like documentation PRs, improvement or integrations suggestions, etc.", "revised_diff": "diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/...
diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md new file mode 100644 index 00000000..99fe3e69 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -0,0 +1,57 @@ +--- +name: 🐛 Bug Report +about: Submit a bug report to help us improve +labels: 'bug, needs triage' +--- + +<...
2
5
zenorocha/clipboard.js#722
zenorocha/clipboard.js
722
62eef3e5b0d6f09a15338ba9ffb7b6c12168e80c
b460d6864cf3e333dc3b1ba6ed6b348607590a6e
Adding basic Type definitions ## Description This PR adds initial support for Types Definitions, now we can offer some basic type checks =) <!--- Describe your changes in detail --> ## Motivation and Context the idea here is to give some better support for typescript without having to touch the source code, w...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Adding basic Type definitions", "scope_files": [ "package-lock.json", "package.json" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `src/` needed for: Adding basic Type definitio...
[ { "subtask_id": "s1", "scope_files": [ "package-lock.json", "package.json" ], "solution_diff": "diff --git a/package-lock.json b/package-lock.json\nindex f9b34bd7..cde2cdf5 100644\n--- a/package-lock.json\n+++ b/package-lock.json\n@@ -1,61 +1,30 @@\n {\n \"name\": \"clipboard\",\n \"...
[ { "subtask_id": "s2", "comment": "Just remember to add EOF.", "revised_diff": "diff --git a/src/clipboard.test-d.ts b/src/clipboard.test-d.ts\nnew file mode 100644\nindex 00000000..d09b4ebb\n--- /dev/null\n+++ b/src/clipboard.test-d.ts\n@@ -0,0 +1,4 @@\n+import { expectType } from 'tsd';\n+import Clipbo...
diff --git a/package-lock.json b/package-lock.json index f9b34bd7..cde2cdf5 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,61 +1,30 @@ { "name": "clipboard", "version": "2.0.6", - "lockfileVersion": 2, + "lockfileVersion": 1, "requires": true, - "packages": { - "": { - "name": "clipbo...
2
4
zenorocha/clipboard.js#721
zenorocha/clipboard.js
721
64797395643b6bab7221842150f63d5916dbb9be
971834388cb13d01bbe915f54ccb440490c7f4b4
Feature Prettier ## Description This PR adds Prettier to be our code style formatting tool <!--- Describe your changes in detail --> ## Motivation and Context with more collaborators now, we want to improve the development experience while maintaining a unique code style consistent with the project. <!-...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Feature Prettier", "scope_files": [ ".editorconfig", ".prettierignore", ".prettierrc.json", "bower.json", "contributing.md", "karma.conf.js", "package-lock.json", "package.js"...
[ { "subtask_id": "s1", "scope_files": [ ".editorconfig", ".prettierignore", ".prettierrc.json", "bower.json", "contributing.md", "karma.conf.js", "package-lock.json", "package.js", "package.json", "readme.md", "webpack.config.js" ], "s...
[]
diff --git a/.editorconfig b/.editorconfig index 0f1d01bd..202ee218 100644 --- a/.editorconfig +++ b/.editorconfig @@ -7,7 +7,7 @@ root = true [*] # Change these settings to your own preference indent_style = space -indent_size = 4 +indent_size = 2 # We recommend you to keep these unchanged end_of_line = lf diff...
5
24
zenorocha/clipboard.js#703
zenorocha/clipboard.js
703
26a8d6392456eebc7dfa3410e232f7319180d120
4456d61877446f9990f85fb1c5f7c2f10ea1e6ff
Upgrade babel to version 7 Resurrecting an old PR, #602, from @pedroabreu. This is a straight upgrade maintaining the old behaviour.
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Upgrade babel to version 7", "scope_files": [ ".babelrc", "package-lock.json", "package.json" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `dist/` needed for: Upgrade bab...
[ { "subtask_id": "s1", "scope_files": [ ".babelrc", "package-lock.json", "package.json" ], "solution_diff": "diff --git a/.babelrc b/.babelrc\nindex 2e7d3f4f..b4421995 100644\n--- a/.babelrc\n+++ b/.babelrc\n@@ -1,11 +1,9 @@\n {\n \"presets\": [\n [\n- \"env\",\n+ \"...
[]
diff --git a/.babelrc b/.babelrc index 2e7d3f4f..b4421995 100644 --- a/.babelrc +++ b/.babelrc @@ -1,11 +1,9 @@ { "presets": [ [ - "env", + "@babel/env", { - "targets": { - "uglify": true - }, + "forceAllTransforms": true, "modules": false } ]...
2
5
zephyrproject-rtos/zephyr#108984
zephyrproject-rtos/zephyr
108,984
a7464a0211222bb087fd30b40cab8628cbc39720
94002c9c1dc02741be0b042e72b93a829e70abfa
disk: nvme: enable by default and select PCIE enable the nvme disk by default, if enabled in the devicetree, also select all PCIE dependencies.
[ { "subtask_id": "s1", "goal": "Implement the changes under `drivers/disk/nvme/` needed for: disk: nvme: enable by default and select PCIE", "scope_files": [ "drivers/disk/nvme/Kconfig" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `tests/drivers/disk/disk_access/`...
[ { "subtask_id": "s1", "scope_files": [ "drivers/disk/nvme/Kconfig" ], "solution_diff": "diff --git a/drivers/disk/nvme/Kconfig b/drivers/disk/nvme/Kconfig\nindex 4ab51992c1be4..9262b761da878 100644\n--- a/drivers/disk/nvme/Kconfig\n+++ b/drivers/disk/nvme/Kconfig\n@@ -3,9 +3,12 @@\n \n menucon...
[]
diff --git a/drivers/disk/nvme/Kconfig b/drivers/disk/nvme/Kconfig index 4ab51992c1be4..9262b761da878 100644 --- a/drivers/disk/nvme/Kconfig +++ b/drivers/disk/nvme/Kconfig @@ -3,9 +3,12 @@ menuconfig NVME bool "NVMe disk" - depends on PCIE + select PCIE + select PCIE_MSI select PCIE_MSI_X select PCIE_MSI_MULT...
5
9
zephyrproject-rtos/zephyr#105596
zephyrproject-rtos/zephyr
105,596
3638fc57328a7a0e6988b79b0bdedd2b9e27e0e1
8bbe78422fdabb80fea4cc3c6bfa043613814b76
kernel/sched: fix IPI race in z_get_next_switch_handle Move signal_pending_ipi() inside the K_SPINLOCK block in z_get_next_switch_handle(). Calling it after the lock release creates a window where a CPU can consume its own pending IPI bit via atomic_clear in signal_pending_ipi(), then silently drop it in arch_sched_d...
[ { "subtask_id": "s1", "goal": "Implement the changes under `kernel/` needed for: kernel/sched: fix IPI race in z_get_next_switch_handle", "scope_files": [ "kernel/ipi.c", "kernel/sched.c" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "kernel/ipi.c", "kernel/sched.c" ], "solution_diff": "diff --git a/kernel/ipi.c b/kernel/ipi.c\nindex 13377ee26c52f..f723f588db8f6 100644\n--- a/kernel/ipi.c\n+++ b/kernel/ipi.c\n@@ -71,12 +71,15 @@ atomic_val_t ipi_mask_create(struct k_thread *thre...
[ { "subtask_id": "s1", "comment": "The fix is sound: `z_ready_thread()` holds `_sched_spinlock` when calling `flag_ipi()`, so moving `signal_pending_ipi()` inside the same lock makes `next_up()` + IPI dispatch atomic w.r.t. thread readying.\n\nHowever, `reschedule()` and `z_reschedule_irqlock()` have the sam...
diff --git a/kernel/ipi.c b/kernel/ipi.c index 13377ee26c52f..f723f588db8f6 100644 --- a/kernel/ipi.c +++ b/kernel/ipi.c @@ -71,12 +71,15 @@ atomic_val_t ipi_mask_create(struct k_thread *thread) void signal_pending_ipi(void) { - /* Synchronization note: you might think we need to lock these - * two steps, but an I...
1
2
zephyrproject-rtos/zephyr#109875
zephyrproject-rtos/zephyr
109,875
91db82a245b731166c547a598029884cb32debe4
d24a3065218dadf017e6d95b89054385cef8ada2
llext: misc fixes and error checking A variety of fixes and error checking from me and @nashif: * Cap variable length array in call_fn_table * Add bounds checking assert to llext_string * Validate st_shndx in llext_symbol_name for STT_SECTION symbols * Bound-check r_offset in Xtensa PLT relocatable branch * Val...
[ { "subtask_id": "s1", "goal": "Implement the changes under `include/zephyr/llext/` needed for: llext: misc fixes and error checking", "scope_files": [ "include/zephyr/llext/llext_internal.h", "include/zephyr/llext/loader.h" ] }, { "subtask_id": "s2", "goal": "Implement the ch...
[ { "subtask_id": "s1", "scope_files": [ "include/zephyr/llext/llext_internal.h", "include/zephyr/llext/loader.h" ], "solution_diff": "diff --git a/include/zephyr/llext/llext_internal.h b/include/zephyr/llext/llext_internal.h\nindex 8bd6fa4dd7096..29199031d84c7 100644\n--- a/include/zephyr...
[ { "subtask_id": "s1", "comment": "why not a runtime check? Asserts are not enabled in production builds.", "revised_diff": "diff --git a/include/zephyr/llext/llext_internal.h b/include/zephyr/llext/llext_internal.h\nindex 8bd6fa4dd7096..29199031d84c7 100644\n--- a/include/zephyr/llext/llext_internal.h\n...
diff --git a/include/zephyr/llext/llext_internal.h b/include/zephyr/llext/llext_internal.h index 8bd6fa4dd7096..29199031d84c7 100644 --- a/include/zephyr/llext/llext_internal.h +++ b/include/zephyr/llext/llext_internal.h @@ -32,6 +32,10 @@ const void *llext_loaded_sect_ptr(struct llext_loader *ldr, struct llext *ext, u...
2
8
zephyrproject-rtos/zephyr#108359
zephyrproject-rtos/zephyr
108,359
bcf31c20f01f11609dbff940483d5172d7897691
e96fb7d5ef0d133e77f98d37de53b8ce715ce0cd
Port drivers to use sys/ring_buffer There are some drivers that are implementing their own ring_buffer, there are cases where even functions names are colliding with sys/ring_buffer. Drivers doing it: `drivers/ethernet/eth_sam_gmac.c` `drivers/i2s/i2s_sam_ssc.c` `drivers/i2s/i2s_ll_stm32.h` drivers: ethernet: s...
[ { "subtask_id": "s1", "goal": "Implement the changes under `drivers/ethernet/` needed for: Port drivers to use sys/ring_buffer", "scope_files": [ "drivers/ethernet/Kconfig.sam_gmac", "drivers/ethernet/eth_sam_gmac.c", "drivers/ethernet/eth_sam_gmac_priv.h" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "drivers/ethernet/Kconfig.sam_gmac", "drivers/ethernet/eth_sam_gmac.c", "drivers/ethernet/eth_sam_gmac_priv.h" ], "solution_diff": "diff --git a/drivers/ethernet/Kconfig.sam_gmac b/drivers/ethernet/Kconfig.sam_gmac\nindex 78ea1c5ae62e4..8f3ad8...
[]
diff --git a/drivers/ethernet/Kconfig.sam_gmac b/drivers/ethernet/Kconfig.sam_gmac index 78ea1c5ae62e4..8f3ad8c7491db 100644 --- a/drivers/ethernet/Kconfig.sam_gmac +++ b/drivers/ethernet/Kconfig.sam_gmac @@ -11,6 +11,7 @@ menuconfig ETH_SAM_GMAC DT_HAS_ATMEL_SAM0_GMAC_ENABLED select NOCACHE_MEMORY if ARCH_HAS_...
1
3
zephyrproject-rtos/zephyr#98255
zephyrproject-rtos/zephyr
98,255
59a42a765d6d2cf6c7ff0b1e7a469d8d5ffe0139
d38b7efbcb938a447fc7bd1b7e2e5282d72c4efb
Add fixed-size FIFO implementation This PR aims to introduce a fixed-size FIFO implementation in Zephyr's utils library. It is built on top of the existing ring buffer and abstracts item management away from both the ring buffer and the user. The goal is to improve readability and reduce boilerplate in code tha...
[ { "subtask_id": "s1", "goal": "Implement the changes under `doc/kernel/data_structures/` needed for: Add fixed-size FIFO implementation", "scope_files": [ "doc/kernel/data_structures/index.rst", "doc/kernel/data_structures/ring_buffers.rst", "doc/kernel/data_structures/ringq.rst" ]...
[ { "subtask_id": "s1", "scope_files": [ "doc/kernel/data_structures/index.rst", "doc/kernel/data_structures/ring_buffers.rst", "doc/kernel/data_structures/ringq.rst" ], "solution_diff": "diff --git a/doc/kernel/data_structures/index.rst b/doc/kernel/data_structures/index.rst\nindex ...
[ { "subtask_id": "s7", "comment": "Nit: the member is still named `rb` (from its ring_buffer past). Consider renaming to `fifo` for clarity now that the type is `struct sys_fifo`.", "revised_diff": "diff --git a/subsys/net/lib/lwm2m/lwm2m_registry.h b/subsys/net/lib/lwm2m/lwm2m_registry.h\nindex 21023a69...
diff --git a/doc/kernel/data_structures/index.rst b/doc/kernel/data_structures/index.rst index b67cff1be1980..735edea8bddc3 100644 --- a/doc/kernel/data_structures/index.rst +++ b/doc/kernel/data_structures/index.rst @@ -39,3 +39,4 @@ structures are thread safe in specific usage scenarios (see mpsc_lockfree.rst s...
11
22
zephyrproject-rtos/zephyr#107526
zephyrproject-rtos/zephyr
107,526
6d04936b1540001089ea7c60e328399f014bc087
a355aea0cb3b656168c311e4919a94506cb13388
testsuite: ztest: benchmark: Fix namespace collisions & remove no-hook macro variants - Namespace the linker-visible symbols emitted by `ZTEST_BENCHMARK*()` via new `Z_ZTEST_BENCHMARK_*` identifier builders, so identically-named benchmarks in different suites no longer collide. - Drop `ZTEST_BENCHMARK_SETUP...
[ { "subtask_id": "s1", "goal": "Implement the changes under `doc/develop/test/` needed for: testsuite: ztest: benchmark: Fix namespace collisions & remove no-hook macro variants", "scope_files": [ "doc/develop/test/benchmark.rst" ] }, { "subtask_id": "s2", "goal": "Implement the cha...
[ { "subtask_id": "s1", "scope_files": [ "doc/develop/test/benchmark.rst" ], "solution_diff": "diff --git a/doc/develop/test/benchmark.rst b/doc/develop/test/benchmark.rst\nindex 1508ecca72436..1c550db19fb75 100644\n--- a/doc/develop/test/benchmark.rst\n+++ b/doc/develop/test/benchmark.rst\n@@ -...
[ { "subtask_id": "s4", "comment": "Not sure about `Z_ZTEST` feel a bit like double prefixing.", "revised_diff": "diff --git a/subsys/testsuite/ztest/include/zephyr/benchmark.h b/subsys/testsuite/ztest/include/zephyr/benchmark.h\nindex 128e1bd66b7d2..5541e69c29255 100644\n--- a/subsys/testsuite/ztest/incl...
diff --git a/doc/releases/migration-guide-4.5.rst b/doc/releases/migration-guide-4.5.rst index 8d8c87a5bd898..7a3ada276ed87 100644 --- a/doc/releases/migration-guide-4.5.rst +++ b/doc/releases/migration-guide-4.5.rst @@ -179,7 +179,6 @@ Other subsystems into ``subsys/mem_mgmt/demand_paging``. Custom backing store an...
4
4
zephyrproject-rtos/zephyr#108847
zephyrproject-rtos/zephyr
108,847
a7464a0211222bb087fd30b40cab8628cbc39720
d68b4424dc794a6f9520dba51de43bc5804d8032
osDelayUntil Implementation Violates CMSIS-RTOS v2 Specification ### Describe the bug The osDelayUntil implementation in subsys/portability/cmsis_rtos_v2/kernel.c does not properly handle wraparound cases and violates the CMSIS-RTOS v2 specification, causing infinite delays when the target tick has already passed. T...
[ { "subtask_id": "s1", "goal": "Implement the changes under `subsys/portability/cmsis_rtos_v2/` needed for: osDelayUntil Implementation Violates CMSIS-RTOS v2 Specification", "scope_files": [ "subsys/portability/cmsis_rtos_v2/kernel.c" ] }, { "subtask_id": "s2", "goal": "Implement t...
[ { "subtask_id": "s1", "scope_files": [ "subsys/portability/cmsis_rtos_v2/kernel.c" ], "solution_diff": "diff --git a/subsys/portability/cmsis_rtos_v2/kernel.c b/subsys/portability/cmsis_rtos_v2/kernel.c\nindex 9f19e89e69fc9..592931d50a42a 100644\n--- a/subsys/portability/cmsis_rtos_v2/kernel.c...
[ { "subtask_id": "s2", "comment": "The within 5 tick is just to give some wiggle room for the tests and different platforms. It is an arbitrary number and not part of any specc as far as I know. ", "revised_diff": "diff --git a/tests/subsys/portability/cmsis_rtos_v2/src/kernel.c b/tests/subsys/portabilit...
diff --git a/subsys/portability/cmsis_rtos_v2/kernel.c b/subsys/portability/cmsis_rtos_v2/kernel.c index 9f19e89e69fc9..592931d50a42a 100644 --- a/subsys/portability/cmsis_rtos_v2/kernel.c +++ b/subsys/portability/cmsis_rtos_v2/kernel.c @@ -134,14 +134,16 @@ osStatus_t osDelay(uint32_t ticks) */ osStatus_t osDelayUn...
2
2
zephyrproject-rtos/zephyr#109415
zephyrproject-rtos/zephyr
109,415
f9fcc1bb12bde594aba63828d0cf174c9d8b885f
a718bb02720986179bb80af6655894ad6d7c8b12
sensor: pac194x: fetch optimization and devicetree refresh-mode support Key Changes - I2C Bus Optimization: Modified the `pac194x_sample_fetch` routine to respect the specific sensor channel. - Devicetree Configuration: Added the microchip,refresh-mode property to the devicetree bindings. This allows board to co...
[ { "subtask_id": "s1", "goal": "Implement the changes under `drivers/sensor/microchip/pac194x/` needed for: sensor: pac194x: fetch optimization and devicetree refresh-mode support", "scope_files": [ "drivers/sensor/microchip/pac194x/pac194x.c" ] }, { "subtask_id": "s2", "goal": "Imp...
[ { "subtask_id": "s1", "scope_files": [ "drivers/sensor/microchip/pac194x/pac194x.c" ], "solution_diff": "diff --git a/drivers/sensor/microchip/pac194x/pac194x.c b/drivers/sensor/microchip/pac194x/pac194x.c\nindex a002c9410b436..18a5bc8fa87af 100644\n--- a/drivers/sensor/microchip/pac194x/pac19...
[ { "subtask_id": "s1", "comment": "I think this starts too look a bit weird, normally I think it's good to keep a `buf, sizeof(buf)` pattern but at this point it may be worth just keep a single buffer (the 8 bytes one) and use it for all transfer, you don't need multiple of these at the same time right?", ...
diff --git a/drivers/sensor/microchip/pac194x/pac194x.c b/drivers/sensor/microchip/pac194x/pac194x.c index a002c9410b436..18a5bc8fa87af 100644 --- a/drivers/sensor/microchip/pac194x/pac194x.c +++ b/drivers/sensor/microchip/pac194x/pac194x.c @@ -76,6 +76,7 @@ static const struct pac194x_chip_info pac194x_chip_info_table...
4
4
zephyrproject-rtos/zephyr#109310
zephyrproject-rtos/zephyr
109,310
b02731645bdf63e897e34219bf8883ad320b2d08
6ca99eecd4ecd96ddba0c939b91a4160e2512749
tests: drivers/comparator/gpio_loopback: Add FRDM-iMXRT1186 Add FRDM-iMXRT1186 (CM33 and CM7) support to the comparator `gpio_loopback` test, exercising ACMP3 through the Zephyr comparator driver model (`CONFIG_COMPARATOR_MCUX_ACMP`). ACMP3 IN2 is on `GPIO_AD_29` (Arduino header **J2-5**, via jumper `J29` in the 2-3 ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `tests/drivers/comparator/gpio_loopback/` needed for: tests: drivers/comparator/gpio_loopback: Add FRDM-iMXRT1186", "scope_files": [ "tests/drivers/comparator/gpio_loopback/testcase.yaml" ] }, { "subtask_id": "s2", "goal": ...
[ { "subtask_id": "s1", "scope_files": [ "tests/drivers/comparator/gpio_loopback/testcase.yaml" ], "solution_diff": "diff --git a/tests/drivers/comparator/gpio_loopback/testcase.yaml b/tests/drivers/comparator/gpio_loopback/testcase.yaml\nindex 6395acb269842..6a440c7b7a5e2 100644\n--- a/tests/dr...
[]
diff --git a/tests/drivers/comparator/gpio_loopback/boards/frdm_imxrt1186_mimxrt1186_cm33.overlay b/tests/drivers/comparator/gpio_loopback/boards/frdm_imxrt1186_mimxrt1186_cm33.overlay new file mode 100644 index 0000000000000..da96d7d51e26b --- /dev/null +++ b/tests/drivers/comparator/gpio_loopback/boards/frdm_imxrt11...
2
3
zephyrproject-rtos/zephyr#108547
zephyrproject-rtos/zephyr
108,547
d2f8e308bdc427c15ffbc3f442d231f6ea8ab6b4
5c2ae7c4da9ef66271eb88d14917392bcb86bbd1
boards: shields: st87mxx update Updated documentation to give more information regarding the EVKITST87M01 board for the ST87M01. https://builds.zephyrproject.io/zephyr/pr/108547/docs/boards/shields/st87mxx/doc/index.html Signed-off-by: Isabelle OGER isabelle.oger@st.com
[ { "subtask_id": "s1", "goal": "Implement the changes under `boards/shields/st87mxx/` needed for: boards: shields: st87mxx update", "scope_files": [ "boards/shields/st87mxx/st87mxx.conf" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `boards/shields/st87mxx/doc/` ne...
[ { "subtask_id": "s1", "scope_files": [ "boards/shields/st87mxx/st87mxx.conf" ], "solution_diff": "diff --git a/boards/shields/st87mxx/st87mxx.conf b/boards/shields/st87mxx/st87mxx.conf\nnew file mode 100644\nindex 0000000000000..5083fda2bb4f7\n--- /dev/null\n+++ b/boards/shields/st87mxx/st87mx...
[ { "subtask_id": "s1", "comment": "Please add copyright + license", "revised_diff": "diff --git a/boards/shields/st87mxx/st87mxx.conf b/boards/shields/st87mxx/st87mxx.conf\nnew file mode 100644\nindex 0000000000000..5083fda2bb4f7\n--- /dev/null\n+++ b/boards/shields/st87mxx/st87mxx.conf\n@@ -0,0 +1,6 @@\...
diff --git a/boards/shields/st87mxx/doc/EVKITST87M01-1.webp b/boards/shields/st87mxx/doc/EVKITST87M01-1.webp deleted file mode 100644 index 2bd710cdfb579..0000000000000 Binary files a/boards/shields/st87mxx/doc/EVKITST87M01-1.webp and /dev/null differ diff --git a/boards/shields/st87mxx/doc/EVKITST87M01-2.webp b/boards...
2
4
zephyrproject-rtos/zephyr#106672
zephyrproject-rtos/zephyr
106,672
f9fcc1bb12bde594aba63828d0cf174c9d8b885f
31ce4cc8333b7a8abe4ba77c77a10dec4b3f995e
drivers: watchdog: add Realtek Ameba series support This PR adds the watchdog driver support for Realtek Ameba series SoCs.
[ { "subtask_id": "s1", "goal": "Implement the changes under `drivers/watchdog/` needed for: drivers: watchdog: add Realtek Ameba series support", "scope_files": [ "drivers/watchdog/CMakeLists.txt", "drivers/watchdog/Kconfig", "drivers/watchdog/Kconfig.ameba", "drivers/watchdog/wdt...
[ { "subtask_id": "s1", "scope_files": [ "drivers/watchdog/CMakeLists.txt", "drivers/watchdog/Kconfig", "drivers/watchdog/Kconfig.ameba", "drivers/watchdog/wdt_ameba.c" ], "solution_diff": "diff --git a/drivers/watchdog/CMakeLists.txt b/drivers/watchdog/CMakeLists.txt\nindex 8a...
[ { "subtask_id": "s1", "comment": "Add a trailing comma so formatting looks nicer\r\n\r\n```suggestion\r\nstatic DEVICE_API(wdt, wdt_api) = {\r\n\t.setup = wdt_ameba_setup,\r\n\t.disable = wdt_ameba_disable,\r\n\t.install_timeout = wdt_ameba_install_timeout,\r\n\t.feed = wdt_ameba_feed,\r\n};\r\n```", "r...
diff --git a/drivers/watchdog/CMakeLists.txt b/drivers/watchdog/CMakeLists.txt index 8a6719e1cacf3..a613d9aa82f5a 100644 --- a/drivers/watchdog/CMakeLists.txt +++ b/drivers/watchdog/CMakeLists.txt @@ -12,6 +12,7 @@ zephyr_library_sources_ifdef(CONFIG_USERSPACE wdt_handlers.c) zephyr_library_sources_ifdef(CONFIG_WDOG_C...
5
8
zephyrproject-rtos/zephyr#110951
zephyrproject-rtos/zephyr
110,951
0e62b7d7f363702abe206cf38672dd6722b6def1
f73aefdf9fd4353f59d8cadd3983835c07e008d4
tests: with_mcumgr: Rework to use prebuilt signed images Fixes tests, as support for imgtool in west sign was deprecated https://github.com/zephyrproject-rtos/zephyr/pull/109588 The pytest scenarios relied on the `west sign` command to re-sign images at runtime, which broke after that command changed. Rework the t...
[ { "subtask_id": "s1", "goal": "Implement the changes under `tests/boot/with_mcumgr/` needed for: tests: with_mcumgr: Rework to use prebuilt signed images", "scope_files": [ "tests/boot/with_mcumgr/README.rst", "tests/boot/with_mcumgr/bt.conf", "tests/boot/with_mcumgr/testcase.yaml" ...
[ { "subtask_id": "s1", "scope_files": [ "tests/boot/with_mcumgr/README.rst", "tests/boot/with_mcumgr/bt.conf", "tests/boot/with_mcumgr/testcase.yaml" ], "solution_diff": "diff --git a/tests/boot/with_mcumgr/README.rst b/tests/boot/with_mcumgr/README.rst\nindex 5c82efa137a10..bd1d2d0...
[ { "subtask_id": "s1", "comment": "nit. this should be renamed to remove overlay from the name, but can be done in a future PR", "revised_diff": "diff --git a/tests/boot/with_mcumgr/testcase.yaml b/tests/boot/with_mcumgr/testcase.yaml\nindex 4bfb319b234a8..5c135ad9a64ae 100644\n--- a/tests/boot/with_mcum...
diff --git a/tests/boot/with_mcumgr/README.rst b/tests/boot/with_mcumgr/README.rst index 5c82efa137a10..bd1d2d0de411b 100644 --- a/tests/boot/with_mcumgr/README.rst +++ b/tests/boot/with_mcumgr/README.rst @@ -15,12 +15,9 @@ use following command: .. code-block:: console - ./zephyr/scripts/twister -vv --west-fl...
2
8
zephyrproject-rtos/zephyr#110937
zephyrproject-rtos/zephyr
110,937
ef5cfd369f4a0ab3601db9a23c1da8c406cc1a72
439d1e43993cdeb402336ae3287f536d643d3244
drivers: dai: intel: ssp: improvements to get_properties implementation The current implementation in ssp driver forces the client to use additional lockign for concurrent TX/RX use. See discussion in https://github.com/thesofproject/sof/pull/6930#issuecomment-1382089429 This really should be handled in the dai dr...
[ { "subtask_id": "s1", "goal": "Implement the changes under `drivers/dai/intel/ssp/` needed for: drivers: dai: intel: ssp: improvements to get_properties implementation", "scope_files": [ "drivers/dai/intel/ssp/ssp.c", "drivers/dai/intel/ssp/ssp.h" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "drivers/dai/intel/ssp/ssp.c", "drivers/dai/intel/ssp/ssp.h" ], "solution_diff": "diff --git a/drivers/dai/intel/ssp/ssp.c b/drivers/dai/intel/ssp/ssp.c\nindex 880ab74841c26..86cce192def10 100644\n--- a/drivers/dai/intel/ssp/ssp.c\n+++ b/drivers/dai...
[ { "subtask_id": "s1", "comment": "`dai_ssp_get_properties_copy()` only assigns `fifo_address`, `dma_hs_id`, and `reg_init_delay`. Callers of `dai_get_properties_copy()` may pass an uninitialized `struct dai_properties`, so `fifo_depth` and `stream_id` can remain garbage/incorrect. The driver should populate...
diff --git a/drivers/dai/intel/ssp/ssp.c b/drivers/dai/intel/ssp/ssp.c index 880ab74841c26..86cce192def10 100644 --- a/drivers/dai/intel/ssp/ssp.c +++ b/drivers/dai/intel/ssp/ssp.c @@ -2519,15 +2519,28 @@ static int dai_ssp_config_set(const struct device *dev, const struct dai_config return ret; } -static const st...
1
2
zephyrproject-rtos/zephyr#110797
zephyrproject-rtos/zephyr
110,797
0e62b7d7f363702abe206cf38672dd6722b6def1
e6281b53ac6d3509e96a355b4ae1e267369fc27d
boards: st: stm32h573i_dk/b_u585i_iot02a: Use EC-P256 as default signature type The default signature type for TF-M was changed for v3.7, but `stm32h573i_dk` and `b_u585i_iot02a` were still using RSA-3072 as default due to not supporting EC-P256 at the time. With the recent addition of EC-P256 support for this board, ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `boards/st/b_u585i_iot02a/` needed for: boards: st: stm32h573i_dk/b_u585i_iot02a: Use EC-P256 as default signature type", "scope_files": [ "boards/st/b_u585i_iot02a/b_u585i_iot02a_stm32u585xx_ns_defconfig" ] }, { "subtask_id": ...
[ { "subtask_id": "s1", "scope_files": [ "boards/st/b_u585i_iot02a/b_u585i_iot02a_stm32u585xx_ns_defconfig" ], "solution_diff": "diff --git a/boards/st/b_u585i_iot02a/b_u585i_iot02a_stm32u585xx_ns_defconfig b/boards/st/b_u585i_iot02a/b_u585i_iot02a_stm32u585xx_ns_defconfig\nindex b52669bee6fb5.....
[]
diff --git a/boards/st/b_u585i_iot02a/b_u585i_iot02a_stm32u585xx_ns_defconfig b/boards/st/b_u585i_iot02a/b_u585i_iot02a_stm32u585xx_ns_defconfig index b52669bee6fb5..2e5185bc4e37a 100644 --- a/boards/st/b_u585i_iot02a/b_u585i_iot02a_stm32u585xx_ns_defconfig +++ b/boards/st/b_u585i_iot02a/b_u585i_iot02a_stm32u585xx_ns_d...
3
3
zephyrproject-rtos/zephyr#110778
zephyrproject-rtos/zephyr
110,778
8e33acdc8107a02e6e8f844c839cc5e4b54c7037
7a585a790134e9afc2b558a8b02dabc988a3efee
boards: nxp: frdm_mcxn947: enable power management Enable Zephyr power management on FRDM-MCXN947 (cpu0): - Select HAS_PM and PM_STATE_SET_IRQ_LOCKED for SOC_MCXN947_CPU0, matching the already-enabled MCXN547 and MCXN236. - Add zephyr,system-timer-companion = &lptmr0 so the kernel has a low-power wake source...
[ { "subtask_id": "s1", "goal": "Implement the changes under `boards/nxp/frdm_mcxn947/` needed for: boards: nxp: frdm_mcxn947: enable power management", "scope_files": [ "boards/nxp/frdm_mcxn947/frdm_mcxn947.dtsi" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `soc/n...
[ { "subtask_id": "s1", "scope_files": [ "boards/nxp/frdm_mcxn947/frdm_mcxn947.dtsi" ], "solution_diff": "diff --git a/boards/nxp/frdm_mcxn947/frdm_mcxn947.dtsi b/boards/nxp/frdm_mcxn947/frdm_mcxn947.dtsi\nindex 7aa056b7985e2..1da20b537e253 100644\n--- a/boards/nxp/frdm_mcxn947/frdm_mcxn947.dtsi...
[]
diff --git a/boards/nxp/frdm_mcxn947/frdm_mcxn947.dtsi b/boards/nxp/frdm_mcxn947/frdm_mcxn947.dtsi index 7aa056b7985e2..1da20b537e253 100644 --- a/boards/nxp/frdm_mcxn947/frdm_mcxn947.dtsi +++ b/boards/nxp/frdm_mcxn947/frdm_mcxn947.dtsi @@ -23,6 +23,7 @@ chosen { zephyr,edac = &erm0; + zephyr,system-timer-compa...
4
5
zephyrproject-rtos/zephyr#110396
zephyrproject-rtos/zephyr
110,396
b02731645bdf63e897e34219bf8883ad320b2d08
99db95f40b5fcc3669c86032cae61c065fae2d87
boards: kit_pse84_ai: add tfm non-secure variant Add TF-M non-secure variant for the PSE84 AI Kit board, enabling secure/non-secure partitioning. The NS variant is configured with TF-M medium profile, clock control, GPIO and UART console. Assisted-by: GitHub Copilot:claude-sonnet-4.5
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: boards: kit_pse84_ai: add tfm non-secure variant", "scope_files": [ "west.yml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `boards/infineon/kit_pse84_ai/` needed for: boards: kit_ps...
[ { "subtask_id": "s1", "scope_files": [ "west.yml" ], "solution_diff": "diff --git a/west.yml b/west.yml\nindex 27ad9b06398a0..5960b2e1d5274 100644\n--- a/west.yml\n+++ b/west.yml\n@@ -188,7 +188,7 @@ manifest:\n groups:\n - hal\n - name: hal_infineon\n- revision: dca66de...
[]
diff --git a/boards/infineon/kit_pse84_ai/Kconfig.defconfig b/boards/infineon/kit_pse84_ai/Kconfig.defconfig index 19d6964af44a8..15999d86c2de2 100644 --- a/boards/infineon/kit_pse84_ai/Kconfig.defconfig +++ b/boards/infineon/kit_pse84_ai/Kconfig.defconfig @@ -5,6 +5,9 @@ if BOARD_KIT_PSE84_AI_PSE846GPS2DBZC4A_M55 ...
7
15
zephyrproject-rtos/zephyr#110289
zephyrproject-rtos/zephyr
110,289
8e33acdc8107a02e6e8f844c839cc5e4b54c7037
a439c7c6aa457560fb04be2ffcf4d191bdd5e26b
Infineon Autanalog PSE84 FIR and FIFO additions - Autanalog SAR FIR postprocessing support - Autanalog SAR FIFO support - Added vendor-specific samples for autanalog FIR and FIFO
[ { "subtask_id": "s1", "goal": "Implement the changes under `boards/infineon/kit_pse84_eval/` needed for: Infineon Autanalog PSE84 FIR and FIFO additions", "scope_files": [ "boards/infineon/kit_pse84_eval/kit_pse84_eval_m55.yaml" ] }, { "subtask_id": "s2", "goal": "Implement the cha...
[ { "subtask_id": "s1", "scope_files": [ "boards/infineon/kit_pse84_eval/kit_pse84_eval_m55.yaml" ], "solution_diff": "diff --git a/boards/infineon/kit_pse84_eval/kit_pse84_eval_m55.yaml b/boards/infineon/kit_pse84_eval/kit_pse84_eval_m55.yaml\nindex 7bb05c948893b..0fb20ed207294 100644\n--- a/bo...
[ { "subtask_id": "s2", "comment": "The comment states that the interrupt performs a mask before invoking the callback and restoring the mask after returning from the callback. I don't see that happening in the code, so either the comment should be corrected or the code updated to perform the mask/unmask. "...
diff --git a/boards/infineon/kit_pse84_eval/kit_pse84_eval_m55.yaml b/boards/infineon/kit_pse84_eval/kit_pse84_eval_m55.yaml index 7bb05c948893b..0fb20ed207294 100644 --- a/boards/infineon/kit_pse84_eval/kit_pse84_eval_m55.yaml +++ b/boards/infineon/kit_pse84_eval/kit_pse84_eval_m55.yaml @@ -1,5 +1,5 @@ -# Copyright (c...
13
20
zephyrproject-rtos/zephyr#104146
zephyrproject-rtos/zephyr
104,146
ef5cfd369f4a0ab3601db9a23c1da8c406cc1a72
e5f4f3cc0d2854453bc4ab811c6f4391229da7ed
drivers: flash: stm32u5/stm32l5 option bytes Expose option bytes reading / writing via flash_ex_op interface
[ { "subtask_id": "s1", "goal": "Implement the changes under `drivers/flash/` needed for: drivers: flash: stm32u5/stm32l5 option bytes", "scope_files": [ "drivers/flash/flash_stm32_ex_op.c", "drivers/flash/flash_stm32l5x.c" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "drivers/flash/flash_stm32_ex_op.c", "drivers/flash/flash_stm32l5x.c" ], "solution_diff": "diff --git a/drivers/flash/flash_stm32_ex_op.c b/drivers/flash/flash_stm32_ex_op.c\nindex 7478529c74dae..3d7d4b1ce22e6 100644\n--- a/drivers/flash/flash_stm32...
[ { "subtask_id": "s1", "comment": "I think you could swap this 2 cases:\n```c\n\tif ((regs->OPTR & mask) == value) {\n\t\treturn 0;\n\t}\n\n\tif (regs->NSCR & FLASH_NSCR_OPTLOCK) {\n\t\treturn -EIO;\n\t}", "revised_diff": "diff --git a/drivers/flash/flash_stm32l5x.c b/drivers/flash/flash_stm32l5x.c\ninde...
diff --git a/drivers/flash/flash_stm32_ex_op.c b/drivers/flash/flash_stm32_ex_op.c index 7478529c74dae..3d7d4b1ce22e6 100644 --- a/drivers/flash/flash_stm32_ex_op.c +++ b/drivers/flash/flash_stm32_ex_op.c @@ -336,7 +336,10 @@ int flash_stm32_ex_op(const struct device *dev, uint16_t code, defined(CONFIG_DT_HAS_ST_STM...
1
2
zephyrproject-rtos/zephyr#108244
zephyrproject-rtos/zephyr
108,244
8cb75f4fbdde883e8020929c0c9a5b1db1a4bd4c
eb888f2ab30bc12c526baff121a634f0bef7f7d7
drivers: gpio: aesc: driver does not use struct gpio_driver_config and struct gpio_driver_data ### Describe the bug All gpio drivers need to have struct gpio_driver_config and struct gpio_driver_data at the first position of the data and config struct. The drivers/gpio/gpio_aesc.c does not do that. Also the config s...
[ { "subtask_id": "s1", "goal": "Implement the changes under `drivers/gpio/` needed for: drivers: gpio: aesc: driver does not use struct gpio_driver_config and struct gpio_driver_data", "scope_files": [ "drivers/gpio/Kconfig.aesc", "drivers/gpio/gpio_aesc.c" ] }, { "subtask_id": "s...
[ { "subtask_id": "s1", "scope_files": [ "drivers/gpio/Kconfig.aesc", "drivers/gpio/gpio_aesc.c" ], "solution_diff": "diff --git a/drivers/gpio/Kconfig.aesc b/drivers/gpio/Kconfig.aesc\nindex aa7fa29ce3f26..5ced4da5a1edf 100644\n--- a/drivers/gpio/Kconfig.aesc\n+++ b/drivers/gpio/Kconfig.a...
[ { "subtask_id": "s1", "comment": "use GPIO_COMMON_CONFIG_FROM_DT_INST", "revised_diff": "diff --git a/drivers/gpio/gpio_aesc.c b/drivers/gpio/gpio_aesc.c\nindex 8190fbbe2d442..d837003f556c6 100644\n--- a/drivers/gpio/gpio_aesc.c\n+++ b/drivers/gpio/gpio_aesc.c\n@@ -1,5 +1,5 @@\n /*\n- * Copyright (c) 20...
diff --git a/drivers/gpio/Kconfig.aesc b/drivers/gpio/Kconfig.aesc index aa7fa29ce3f26..5ced4da5a1edf 100644 --- a/drivers/gpio/Kconfig.aesc +++ b/drivers/gpio/Kconfig.aesc @@ -1,4 +1,4 @@ -# Copyright (c) 2025 Aesc Silicon +# SPDX-FileCopyrightText: 2025 Aesc Silicon # SPDX-License-Identifier: Apache-2.0 config GP...
4
6
zephyrproject-rtos/zephyr#108261
zephyrproject-rtos/zephyr
108,261
d2f8e308bdc427c15ffbc3f442d231f6ea8ab6b4
e0c80c5ddee84ce1354165e2c02562fb4f1e11c5
Bluetooth: Audio: apply U suffix to unsigned integer literals Apply the U suffix to unsigned integer literal constants used in contexts involving unsigned types (uint8_t, uint16_t, uint32_t, uint64_t, size_t, etc.) with coding guideline 40 which requires that a U suffix be applied to all unsigned integer constants. ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `include/zephyr/bluetooth/audio/` needed for: Bluetooth: Audio: apply U suffix to unsigned integer literals", "scope_files": [ "include/zephyr/bluetooth/audio/aics.h", "include/zephyr/bluetooth/audio/audio.h", "include/zephyr/b...
[ { "subtask_id": "s1", "scope_files": [ "include/zephyr/bluetooth/audio/aics.h", "include/zephyr/bluetooth/audio/audio.h", "include/zephyr/bluetooth/audio/bap.h", "include/zephyr/bluetooth/audio/ccid.h", "include/zephyr/bluetooth/audio/csip.h", "include/zephyr/bluetooth/au...
[ { "subtask_id": "s1", "comment": "`MEDIA_PROXY_PLAYBACK_SPEED_UNITY` is part of a signed playback-speed range (see the surrounding -128/-64/+64/+127 values). Defining it as `0U` makes it an unsigned constant, which can trigger unintended unsigned promotions (e.g., if compared against negative speeds) and ma...
diff --git a/include/zephyr/bluetooth/audio/aics.h b/include/zephyr/bluetooth/audio/aics.h index d946d499d2943..5a22ad6ba3f09 100644 --- a/include/zephyr/bluetooth/audio/aics.h +++ b/include/zephyr/bluetooth/audio/aics.h @@ -47,11 +47,11 @@ extern "C" { * @{ */ /** The mute state is unmuted */ -#define BT_AICS_STA...
3
77
zephyrproject-rtos/zephyr#111130
zephyrproject-rtos/zephyr
111,130
fb64460fd6e563f02129f40fd78d7c18fd5718cc
f5c96422e7ffce2e815d3136b51c6c4cee3e0dc2
Bluetooth: BAP: Shell: Make it easier to copy broadcast IDs The broadcast ID is printed in the shell various places. Often the shell user wants to copy this value and use it for future commands. Remove any following commas, so that the user can easier click-to-mark the value to copy it.
[ { "subtask_id": "s1", "goal": "Implement the changes under `subsys/bluetooth/audio/shell/` needed for: Bluetooth: BAP: Shell: Make it easier to copy broadcast IDs", "scope_files": [ "subsys/bluetooth/audio/shell/bap_broadcast_assistant.c", "subsys/bluetooth/audio/shell/bap_scan_delegator.c" ...
[ { "subtask_id": "s1", "scope_files": [ "subsys/bluetooth/audio/shell/bap_broadcast_assistant.c", "subsys/bluetooth/audio/shell/bap_scan_delegator.c" ], "solution_diff": "diff --git a/subsys/bluetooth/audio/shell/bap_broadcast_assistant.c b/subsys/bluetooth/audio/shell/bap_broadcast_assis...
[]
diff --git a/subsys/bluetooth/audio/shell/bap_broadcast_assistant.c b/subsys/bluetooth/audio/shell/bap_broadcast_assistant.c index 59ee0a02e38f1..20f710dccf59b 100644 --- a/subsys/bluetooth/audio/shell/bap_broadcast_assistant.c +++ b/subsys/bluetooth/audio/shell/bap_broadcast_assistant.c @@ -130,7 +130,7 @@ static void...
1
2
zephyrproject-rtos/zephyr#110930
zephyrproject-rtos/zephyr
110,930
f18c5499b717fce02399ae5102781ac013200598
d82b9ed1bf7d4ef6d6c17d63a3b28c65fd4ac3f3
net: if: remove net_if_config_get remove net_if_config_get, which is not used in the tree, in favor of net_if_get_config. Both did the exact same thing.
[ { "subtask_id": "s1", "goal": "Implement the changes under `doc/releases/` needed for: net: if: remove net_if_config_get", "scope_files": [ "doc/releases/migration-guide-4.5.rst" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `include/zephyr/net/` needed for: net: ...
[ { "subtask_id": "s1", "scope_files": [ "doc/releases/migration-guide-4.5.rst" ], "solution_diff": "diff --git a/doc/releases/migration-guide-4.5.rst b/doc/releases/migration-guide-4.5.rst\nindex 3b80821568009..f3dd1b5749030 100644\n--- a/doc/releases/migration-guide-4.5.rst\n+++ b/doc/releases...
[]
diff --git a/doc/releases/migration-guide-4.5.rst b/doc/releases/migration-guide-4.5.rst index 3b80821568009..f3dd1b5749030 100644 --- a/doc/releases/migration-guide-4.5.rst +++ b/doc/releases/migration-guide-4.5.rst @@ -630,6 +630,9 @@ Networking keys. Use ``samples/net/wifi/test_certs/rsa2k_no_des`` instead, or se...
2
2
zeroclaw-labs/zeroclaw#7116
zeroclaw-labs/zeroclaw
7,116
a7a07558ee32e607deef4fc59ddb266b08c3e4e7
bc8494971a737fe60cc5e815c85634cc938dce3d
docs(providers): add OpenAI Codex over a ChatGPT subscription ## Summary - **Base branch:** `master` - **What changed and why:** Adds a Model Providers book page — **OpenAI Codex over a ChatGPT subscription** (`docs/book/src/providers/openai-codex-subscription.md`) + a SUMMARY entry. The `openai` slot can authenticat...
[ { "subtask_id": "s1", "goal": "Implement the changes under `docs/book/src/` needed for: docs(providers): add OpenAI Codex over a ChatGPT subscription", "scope_files": [ "docs/book/src/SUMMARY.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `docs/book/src/provide...
[ { "subtask_id": "s1", "scope_files": [ "docs/book/src/SUMMARY.md" ], "solution_diff": "diff --git a/docs/book/src/SUMMARY.md b/docs/book/src/SUMMARY.md\nindex 1ac207d27a6..055d1e60ab6 100644\n--- a/docs/book/src/SUMMARY.md\n+++ b/docs/book/src/SUMMARY.md\n@@ -54,6 +54,8 @@\n - [Streaming](./...
[]
diff --git a/docs/book/src/SUMMARY.md b/docs/book/src/SUMMARY.md index 1ac207d27a6..055d1e60ab6 100644 --- a/docs/book/src/SUMMARY.md +++ b/docs/book/src/SUMMARY.md @@ -54,6 +54,8 @@ - [Streaming](./providers/streaming.md) - [Routing](./providers/routing.md) - [Custom providers](./providers/custom.md) + - [Op...
2
2
zeroclaw-labs/zeroclaw#5797
zeroclaw-labs/zeroclaw
5,797
d6255bd1d356f40e86134fc24daeb28be00961c1
7ce4afb088185ca86b463ced186266ce7b63fc99
[Feature]: Add support for local CA certificates for custom inference provider ### Summary Enable user to specify a trusted root CA for custom inference provider ### Problem statement Zeroclaw does not enable the user to specify a trusted certificate authority for custom inference endpoints. This prevents zeroclaw ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `crates/zeroclaw-config/src/` needed for: [Feature]: Add support for local CA certificates for custom inference provider", "scope_files": [ "crates/zeroclaw-config/src/schema.rs" ] }, { "subtask_id": "s2", "goal": "Implemen...
[ { "subtask_id": "s1", "scope_files": [ "crates/zeroclaw-config/src/schema.rs" ], "solution_diff": "diff --git a/crates/zeroclaw-config/src/schema.rs b/crates/zeroclaw-config/src/schema.rs\nindex 5cc45620321..0674a79c7a9 100644\n--- a/crates/zeroclaw-config/src/schema.rs\n+++ b/crates/zeroclaw-...
[]
diff --git a/crates/zeroclaw-config/src/schema.rs b/crates/zeroclaw-config/src/schema.rs index 5cc45620321..0674a79c7a9 100644 --- a/crates/zeroclaw-config/src/schema.rs +++ b/crates/zeroclaw-config/src/schema.rs @@ -795,6 +795,12 @@ pub struct ModelProviderConfig { #[tab(Advanced)] #[serde(default, skip_seri...
2
4