zhan1206 commited on
Commit
bb40eba
·
1 Parent(s): 2661c24

fix: F4-1/2/3 — three crash-on-run bugs

Browse files

F4-1 (dashboard.py): _init_tokenizer() -> _ensure_tokenizer()
F4-2 (train_grpo.py): GRPOConfig — remove non-existent fields
(learning_rate/reward_fn_name/num_generations)
F4-3 (train_grpo.py): GRPOTrainer(config=...) -> grpo_config=...;
extract learning_rate into separate AdamW optimizer;
pass reward_fn name string to trainer (resolved at call time)
8/8 tests passed.

Files changed (2) hide show
  1. inference/dashboard.py +1 -1
  2. train/train_grpo.py +10 -6
inference/dashboard.py CHANGED
@@ -77,7 +77,7 @@ class InferenceEngine:
77
  self.model.eval()
78
  self.inference_config = InferenceConfig()
79
  self.kv_cache = None
80
- self._init_tokenizer()
81
 
82
  def _load_model(self, model_path: str) -> tuple:
83
  """Load model from path."""
 
77
  self.model.eval()
78
  self.inference_config = InferenceConfig()
79
  self.kv_cache = None
80
+ self._ensure_tokenizer()
81
 
82
  def _load_model(self, model_path: str) -> tuple:
83
  """Load model from path."""
train/train_grpo.py CHANGED
@@ -126,18 +126,22 @@ def main():
126
  # 加载模型
127
  model, config, device = load_fusion_model(args.model_path, args.device)
128
 
129
- # GRPO 配置
130
  grpo_config = GRPOConfig(
131
- learning_rate=args.learning_rate,
132
  kl_coef=args.kl_coef,
133
- reward_fn_name=args.reward_fn,
134
- num_generations=args.num_generations,
135
  )
136
 
137
- # 创建 GRPOTrainer
 
 
 
 
 
 
138
  trainer = GRPOTrainer(
139
  model=model,
140
- config=grpo_config,
 
141
  )
142
 
143
  # 加载数据
 
126
  # 加载模型
127
  model, config, device = load_fusion_model(args.model_path, args.device)
128
 
129
+ # GRPO config
130
  grpo_config = GRPOConfig(
 
131
  kl_coef=args.kl_coef,
 
 
132
  )
133
 
134
+ # Optimizer (separate from GRPO config)
135
+ optimizer = torch.optim.AdamW(model.parameters(), lr=args.learning_rate)
136
+
137
+ # Reward function (string name, resolved by GRPOTrainer.compute_reward)
138
+ reward_fn = args.reward_fn
139
+
140
+ # Create GRPOTrainer
141
  trainer = GRPOTrainer(
142
  model=model,
143
+ grpo_config=grpo_config,
144
+ reward_fn=reward_fn,
145
  )
146
 
147
  # 加载数据