Reviewer sees review history across all versions

- Admin still shows one row per trial (latest version), but now displays the
full review history spanning every version, each review tagged with the
version it was made on.
- add list_pair_reviews(); list_submissions() includes all_reviews per trial.
- Current status still reflects the latest version's most recent review; new
reviews attach to the latest version.

README.md

@@ -24,7 +24,7 @@ A Streamlit intake form for trial statisticians. Submissions are saved to a **Hu
     - `derivation_required` → 4 rubrics: `output.json` × {Inputs used, Calculated value, Method} + `output.R` × {Reproducibility}
   - Each rubric collects `points`, `tolerance`, `criterion`.
   - **Versions** — every Submit saves a new version. Re-enter the same `trial_id` + `username`, click **Find versions**, pick one, and **Load selected version** to pull it back into the form for editing; Submit then saves a new version.
-- **Admin page (`pages/1_Admin.py`)** — password-gated review console. Shows **only the latest version of each trial** (one row per `trial_id` + `username`). A version can be reviewed many times by different people: each review (status + reviewer name + comment) is written as its own file under `reviews/<trial>__<user>/<version>/`, and the page shows the full timeline. The current status is the most recent review's status. (Submitters can still see and load all their own versions on the form.)
+- **Admin page (`pages/1_Admin.py`)** — password-gated review console. Shows **only the latest version of each trial** (one row per `trial_id` + `username`), but the review history covers **all versions** of that trial (each review tagged with the version it was made on). The current status reflects the latest version's most recent review. New reviews are added to the latest version. Each review is its own file under `reviews/<trial>__<user>/<version>/`. (Submitters can still see and load all their own versions on the form.)
 
 ## Run locally
 

lib/storage.py

@@ -242,8 +242,33 @@ def add_review(submission_id: str, status: str, reviewer: str, note: str = "") -
     return review
 
 
+def list_pair_reviews(
+    pair_key: str, all_files: Optional[List[str]] = None
+) -> List[Dict[str, Any]]:
+    """Every review across ALL versions of a (trial_id, username) pair.
+
+    pair_key is '<trial>__<user>'. Each returned review is tagged with the
+    `version` it was made on. Oldest first.
+    """
+    prefix = f"{REVIEWS_PREFIX}/{pair_key}/"
+    files = all_files if all_files is not None else _all_files()
+    paths = sorted(f for f in files if f.startswith(prefix) and f.endswith(".json"))
+    out: List[Dict[str, Any]] = []
+    for p in paths:
+        rec = _read_json(p)
+        if not rec:
+            continue
+        # p = reviews/<pair>/<version>/<revfile>.json
+        parts = p[len(REVIEWS_PREFIX) + 1 :].split("/")
+        rec = dict(rec)
+        rec["version"] = parts[1] if len(parts) >= 3 else ""
+        out.append(rec)
+    out.sort(key=lambda r: r.get("at", ""))
+    return out
+
+
 def list_reviews(submission_id: str, all_files: Optional[List[str]] = None) -> List[Dict[str, Any]]:
-    """All reviews for a submission, oldest first."""
+    """All reviews for a single submission version, oldest first."""
     base = _base_id(submission_id)
     prefix = f"{REVIEWS_PREFIX}/{base}/"
     files = all_files if all_files is not None else _all_files()
@@ -290,12 +315,15 @@ def list_submissions() -> List[Dict[str, Any]]:
             latest_by_pair[key] = sp
 
     result: List[Dict[str, Any]] = []
-    for sp in latest_by_pair.values():
+    for key, sp in latest_by_pair.items():
         sub = _read_json(sp)
         if not sub:
             continue
+        # Reviews on the latest version drive the current status.
         reviews = list_reviews(sp, all_files=files)
         latest = reviews[-1] if reviews else None
+        # All reviews across every version of this trial (tagged with version).
+        all_reviews = list_pair_reviews(key, all_files=files)
         result.append(
             {
                 "submissionId": sp,
@@ -308,6 +336,7 @@ def list_submissions() -> List[Dict[str, Any]]:
                 "reviewer": latest["reviewer"] if latest else "",
                 "review_count": len(reviews),
                 "reviews": reviews,
+                "all_reviews": all_reviews,
                 "submission": sub,
             }
         )

pages/1_Admin.py

@@ -107,26 +107,30 @@ for s in items:
             )
         with meta_c2:
             st.markdown(
-                f"**File:** `{s.get('submissionId', '')}`  \n"
+                f"**Latest version:** `{s.get('version', '')}`  \n"
                 f"**Last reviewer:** {s.get('reviewer', '') or '—'}"
             )
 
-        # ---- Review timeline -----------------------------------------
-        reviews = s.get("reviews") or []
-        st.markdown(f"#### Review history ({len(reviews)})")
-        if not reviews:
+        # ---- Review history across ALL versions of this trial --------
+        all_reviews = s.get("all_reviews") or []
+        current_version = s.get("version", "")
+        st.markdown(f"#### Review history — all versions ({len(all_reviews)})")
+        if not all_reviews:
             st.caption("No reviews yet.")
         else:
-            for rev in reversed(reviews):  # newest first
+            for rev in reversed(all_reviews):  # newest first
+                rev_version = rev.get("version", "")
+                is_current = rev_version == current_version
+                vtag = f"`v{rev_version}`" + ("  _(current)_" if is_current else "")
                 st.markdown(
                     f"- {status_badge(rev.get('status', ''))} — "
                     f"**{rev.get('reviewer') or 'anon'}** "
-                    f"· _{rev.get('at', '')}_"
+                    f"· _{rev.get('at', '')}_ · on {vtag}"
                     + (f"  \n  {rev.get('note')}" if rev.get("note") else "")
                 )
 
-        # ---- Add a review --------------------------------------------
-        st.markdown("#### Add a review")
+        # ---- Add a review (applies to the latest version) -----------
+        st.markdown(f"#### Add a review — on latest version `v{s.get('version', '')}`")
         with st.form(f"review_{s['submissionId']}"):
             new_status = st.radio(
                 "Status",