Upload 6 files

CHANGELOG.md

@@ -1,18 +1,10 @@
-# v164 — Premium Timeline Refactor
+# v171 — delete Space option, ghost-run cleanup, storage polish
 
-- Reworked the Active Run timeline as a premium, single-row milestone system with clockwise partial rings for grouped substeps.
-- Renamed user-facing timeline labels where helpful while retaining worker-step precision underneath.
-- Kept Agent recovery and Run traces roles from v158/v159; v120 Agent recovery remains documented and visible as the operational recovery summary.
-- Reduced redundant terminal Failure milestone: precise failed stages are marked directly, with Failure only as a fallback terminal anchor.
+- Added an opt-in checkbox in the premium delete modal to also delete the associated Hugging Face Space for build runs.
+- Extended the DELETE run API to accept `{ "delete_space": true }`, delete the Space repo in the authenticated user's namespace, and return an explicit Space deletion report.
+- Kept Space deletion disabled for validation runs to avoid deleting existing Spaces that were only tested.
+- Made incomplete/unknown ghost runs deletable from Run Explorer so stale bucket prefixes can be cleaned up.
+- Polished the Run Storage card error state with compact, user-readable messages instead of dumping long bucket HTTP errors into the card.
+- Preserved the v170 real recursive bucket deletion behavior.
 
-Validation: 452 tests pass.
-
-# v163 — Section Harmony Audit
-
-- Reviewed the one-page UI section by section for state ownership, event-handler conflicts and cross-panel interference.
-- Fixed duplicate DOM IDs in the support/compatibility area so hidden legacy elements no longer shadow visible Active Run hardware fields.
-- Separated Space Test's visible “Started at” field from the Active Run polling compatibility field. Active Run progress no longer writes into the Space Test timestamp.
-- Hardened Run traces document state so backend-provided `present: true` document links are not downgraded when a light payload lacks a `files` listing.
-- Added regression tests covering unique DOM IDs, Active Run vs Space Test timestamp separation, hidden-field compatibility boundaries, and stable Run traces document presence.
-
-Validation: 448 tests pass.
+Validation: `478 passed, 2 warnings`.

README.md

@@ -1,21 +1,14 @@
----
-title: Agentic Space Factory
-sdk: docker
-hf_oauth: true
-hf_oauth_expiration_minutes: 480
-hf_oauth_scopes:
-  - read-repos
-  - write-repos
-  - manage-repos
-  - gated-repos
-  - inference-api
-  - jobs
-  - read-billing
----
+## v170 — Real bucket recursive run deletion
 
+- DELETE `/api/runs/{run_id}` now removes concrete bucket objects under `runs/<run_id>/` using recursive discovery instead of relying only on virtual-folder deletion.
+- The API returns a cleanup report with deleted and remaining object counts.
+- Frontend cache invalidation remains as a protection layer, but deletion is now a real backend bucket cleanup.
 
 # Agentic Space Factory
 
+- **v170** fixes run deletion so the backend recursively removes all concrete Bucket objects for the run prefix.
+- **v168** refreshes Pi assistant model choices and surfaces requested/effective provider model routing in Active Run.
+- **v165** fixes fresh-install recovery failures, README metadata preservation, timeline failure anchoring, premium pre-scan/progress polish, and broader Pi assistant model choices.
 - **v161** fixes duplicate delete modal triggers and stuck `Deleting…` states with single-flight delete guards.
 
 ---
@@ -261,3 +254,11 @@ Run traces now renders as a horizontal document dock: compact source-file icons
 ## v164 timeline
 
 The Active Run timeline uses compact product milestones backed by exact worker steps. Grouped milestones expose clockwise partial progress rings and substep counts, while recovery details remain in Agent recovery and source files remain in Run traces.
+
+### v167 note: run artifact manifest
+
+The worker writes `runs/<run_id>/artifact_manifest.json` as the source of truth for run artifacts. This lets the API expose Run traces from what the worker actually wrote, including failed runs where the Space was created but later entered build/runtime error.
+
+## v171 notes
+
+Run deletion now supports an explicit opt-in option to delete the associated generated Space for build runs. Validation run deletion remains run-artifact-only by default. The Run Storage card also summarizes bucket setup errors so fresh installs remain visually clean.

app.py

@@ -8,7 +8,7 @@ from typing import Any
 import gradio as gr
 from fastapi import FastAPI, HTTPException, Request
 from fastapi.responses import HTMLResponse, JSONResponse, FileResponse, RedirectResponse
-from huggingface_hub import attach_huggingface_oauth
+from huggingface_hub import HfApi, attach_huggingface_oauth
 
 from src.bucket import RunPaths, check_user_bucket, create_user_bucket, delete_run_folder, read_run_bundle, list_recent_runs, write_json, write_launch_metadata
 from src.config import settings, user_bucket_source
@@ -562,13 +562,33 @@ def register_custom_routes(fastapi_app: FastAPI) -> None:
         ctx = _oauth_context_from_request(request)
         run_id = validate_run_id(run_id)
         bucket_source = user_bucket_source(username=ctx["username"], bucket_name=bucket_name)
+        body: dict[str, Any] = {}
         try:
-            delete_run_folder(run_id, bucket_source=bucket_source, token=ctx["token"])
+            body = await request.json()
+            if not isinstance(body, dict):
+                body = {}
+        except Exception:
+            body = {}
+        delete_space = bool(body.get("delete_space"))
+        bundle: dict[str, Any] = {}
+        space_report: dict[str, Any] = {"space_delete_requested": delete_space, "space_deleted": False}
+        if delete_space:
+            try:
+                bundle = read_run_bundle(run_id, bucket_source=bucket_source, token=ctx["token"], include_heavy=False)
+                associated_space = _associated_space_from_bundle(bundle)
+                kind = str((bundle.get("summary") or {}).get("kind") or (bundle.get("state") or {}).get("kind") or (bundle.get("launch") or {}).get("kind") or "").lower()
+                if "validation" in kind or "space_test" in kind:
+                    raise PermissionError("Associated Space deletion is not available for validation runs.")
+                space_report = _delete_associated_space(associated_space, username=ctx["username"], token=ctx["token"])
+            except Exception as exc:  # noqa: BLE001
+                space_report = {"space_delete_requested": True, "space_deleted": False, "space_delete_error": redact(str(exc))}
+        try:
+            delete_report = delete_run_folder(run_id, bucket_source=bucket_source, token=ctx["token"])
         except FileNotFoundError:
-            pass
+            delete_report = {"matched_count": 0, "deleted_count": 0, "remaining_count": 0}
         except Exception as exc:  # noqa: BLE001
             raise HTTPException(status_code=400, detail=redact(str(exc))) from exc
-        return JSONResponse({"ok": True, "run_id": run_id, "deleted": True})
+        return JSONResponse({"ok": True, "run_id": run_id, "deleted": True, **delete_report, **space_report})
 
     @fastapi_app.get("/api/runs/{run_id}/progress")
     async def api_run_progress(request: Request, run_id: str, bucket_name: str = settings.bucket_name, include_job_logs: bool = False):  # type: ignore[no-untyped-def]
@@ -905,7 +925,7 @@ def build_demo() -> gr.Blocks:
         with gr.Tab("Build from model card"):
             gr.Markdown(
                 """
-Paste a Hugging Face model ID or model-card URL. The worker creates a **private** Space, asks Pi + Qwen Coder to build the best Gradio app it can, attempts ZeroGPU first, then a fixed-GPU fallback if enabled. If automatic hardware assignment fails, set the hardware manually in the generated Space settings and run the validation tab.
+Paste a Hugging Face model ID or model-card URL. The worker creates a **private** Space, asks Pi + the selected coding assistant to build the best Gradio app it can, attempts ZeroGPU first, then a fixed-GPU fallback if enabled. If automatic hardware assignment fails, set the hardware manually in the generated Space settings and run the validation tab.
 """
             )
             with gr.Row():
@@ -921,10 +941,19 @@ Paste a Hugging Face model ID or model-card URL. The worker creates a **private*
                 placeholder="e.g. space-factory-z-image-v1",
                 info="Use a fresh name. The Space is created under your username and remains private.",
             )
-            pi_model = gr.Textbox(
+            pi_model = gr.Dropdown(
                 label="Pi model",
+                choices=[
+                    "Qwen/Qwen3-Coder-Next",
+                    "moonshotai/Kimi-K2-Instruct-0905",
+                    "zai-org/GLM-4.7",
+                    "zai-org/GLM-4.5-Air",
+                    "deepseek-ai/DeepSeek-V3.2",
+                    "Qwen/Qwen3-Coder-480B-A35B-Instruct",
+                ],
                 value="Qwen/Qwen3-Coder-Next",
-                info="Model used by Pi through Hugging Face Inference Providers.",
+                allow_custom_value=True,
+                info="Assistant model used by Pi through Hugging Face Inference Providers.",
             )
             implementation_mode = gr.Dropdown(
                 label="Build goal",
@@ -1074,6 +1103,55 @@ It cannot guarantee that every model card becomes a working Space. It cannot byp
     return demo
 
 
+
+def _first_non_empty(*values: Any) -> str:
+    for value in values:
+        text = str(value or "").strip()
+        if text:
+            return text
+    return ""
+
+
+def _associated_space_from_bundle(bundle: dict[str, Any]) -> str:
+    summary = bundle.get("summary") or {}
+    summary_file = bundle.get("summary_file") or {}
+    launch = bundle.get("launch") or {}
+    state = bundle.get("state") or {}
+    links = bundle.get("links") or {}
+    target = _first_non_empty(
+        summary.get("target_space"),
+        summary_file.get("target_space"),
+        launch.get("target_space"),
+        state.get("target_space"),
+        links.get("target_space"),
+    )
+    if target:
+        return target.replace("https://huggingface.co/spaces/", "").strip("/")
+    url = _first_non_empty(summary.get("target_space_url"), summary_file.get("target_space_url"), launch.get("target_space_url"), state.get("target_space_url"), links.get("target_space_url"))
+    marker = "huggingface.co/spaces/"
+    if marker in url:
+        return url.split(marker, 1)[1].split("?", 1)[0].split("#", 1)[0].strip("/")
+    return ""
+
+
+def _delete_associated_space(space_id: str, *, username: str, token: str) -> dict[str, Any]:
+    cleaned = str(space_id or "").strip().strip("/")
+    if not cleaned or "/" not in cleaned:
+        raise ValueError("No associated Space id is available for this run.")
+    owner = cleaned.split("/", 1)[0]
+    if owner != username:
+        raise PermissionError(f"Refusing to delete Space {cleaned}: it is not in your namespace.")
+    api = HfApi(token=token)
+    try:
+        api.delete_repo(repo_id=cleaned, repo_type="space")
+        return {"space_delete_requested": True, "space_deleted": True, "space_id": cleaned}
+    except Exception as exc:  # noqa: BLE001
+        message = redact(str(exc))
+        missing_markers = ("404", "not found", "Repository Not Found", "does not exist")
+        if any(marker.lower() in message.lower() for marker in missing_markers):
+            return {"space_delete_requested": True, "space_deleted": False, "space_already_missing": True, "space_id": cleaned, "space_delete_error": message}
+        return {"space_delete_requested": True, "space_deleted": False, "space_id": cleaned, "space_delete_error": message}
+
 def create_app() -> FastAPI:
     """Create the product FastAPI app.