File size: 12,115 Bytes
bd0a2e7
 
 
 
 
 
 
 
 
 
 
 
 
f662601
bd0a2e7
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
f662601
bd0a2e7
 
 
 
 
 
 
 
 
 
f662601
bd0a2e7
 
 
 
 
 
 
 
f662601
bd0a2e7
 
 
 
 
 
 
 
 
 
 
 
f662601
bd0a2e7
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
7d68969
bd0a2e7
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
"""Sprint A14-S45 β€” VLM adapters (4 fournisseurs).

Tests des 4 adapters VLM qui hΓ©ritent de ``BaseVLMAdapter`` +
leur LLM sibling (composition par MRO multiple).
"""

from __future__ import annotations

import base64
from pathlib import Path

import pytest

from picarones.adapters.vlm.base import VLMAdapterError
from picarones.adapters.vlm import (
    AnthropicVLMAdapter,
    BaseVLMAdapter,
    MistralVLMAdapter,
    OllamaVLMAdapter,
    OpenAIVLMAdapter,
)
from picarones.domain.artifacts import Artifact, ArtifactType
from picarones.pipeline.types import RunContext


# ──────────────────────────────────────────────────────────────────────
# Helpers
# ──────────────────────────────────────────────────────────────────────


class _StubVLMAdapter(BaseVLMAdapter):
    """VLM stub pour tests : retourne un texte fixe."""

    def __init__(
        self,
        response_text="texte transcrit",
        raise_on_call=False,
        config=None,
    ):
        super().__init__(config=config or {"max_retries": 0})
        self._response = response_text
        self._raise = raise_on_call
        self.last_image_b64 = None

    @property
    def name(self) -> str:
        return "stub_vlm"

    @property
    def default_model(self) -> str:
        return "stub-vlm-1.0"

    def _call(self, prompt, image_b64=None):
        self.last_image_b64 = image_b64
        if self._raise:
            raise RuntimeError("VLM crashed")
        return self._response


def _make_image_artifact(uri: str) -> Artifact:
    return Artifact(
        id="doc01:image",
        document_id="doc01",
        type=ArtifactType.IMAGE,
        uri=uri,
    )


def _make_context() -> RunContext:
    return RunContext(
        document_id="doc01",
        code_version="1.0.0",
        pipeline_name="test",
    )


# ──────────────────────────────────────────────────────────────────────
# Contrat StepExecutor (BaseVLMAdapter)
# ──────────────────────────────────────────────────────────────────────


class TestBaseVLMAdapterContract:
    def test_input_types_is_image(self) -> None:
        adapter = _StubVLMAdapter()
        assert adapter.input_types == frozenset({ArtifactType.IMAGE})

    def test_output_types_is_raw_text(self) -> None:
        adapter = _StubVLMAdapter()
        assert adapter.output_types == frozenset({ArtifactType.RAW_TEXT})

    def test_execution_mode_is_io(self) -> None:
        # HΓ©ritΓ© de BaseLLMAdapter.
        assert _StubVLMAdapter.execution_mode == "io"


class TestVLMExecuteNominal:
    def test_basic_transcription(self, tmp_path: Path) -> None:
        image_path = tmp_path / "doc01.png"
        image_path.write_bytes(b"PNGBYTES")
        adapter = _StubVLMAdapter(response_text="ceci est le texte")

        result = adapter.execute(
            inputs={ArtifactType.IMAGE: _make_image_artifact(str(image_path))},
            params={},
            context=_make_context(),
        )
        assert ArtifactType.RAW_TEXT in result
        produced = result[ArtifactType.RAW_TEXT]
        assert produced.type == ArtifactType.RAW_TEXT
        assert produced.document_id == "doc01"
        out_path = Path(produced.uri)
        assert out_path.exists()
        assert out_path.read_text(encoding="utf-8") == "ceci est le texte"
        assert out_path.name == "doc01.stub_vlm.txt"

    def test_image_passed_to_llm_as_base64(self, tmp_path: Path) -> None:
        image_path = tmp_path / "doc01.png"
        image_path.write_bytes(b"VLM_TEST_BYTES")
        adapter = _StubVLMAdapter()
        adapter.execute(
            inputs={ArtifactType.IMAGE: _make_image_artifact(str(image_path))},
            params={},
            context=_make_context(),
        )
        decoded = base64.b64decode(adapter.last_image_b64)
        assert decoded == b"VLM_TEST_BYTES"

    def test_artifact_id_uses_adapter_name(self, tmp_path: Path) -> None:
        image_path = tmp_path / "doc01.png"
        image_path.write_bytes(b"x")
        adapter = _StubVLMAdapter()
        result = adapter.execute(
            inputs={ArtifactType.IMAGE: _make_image_artifact(str(image_path))},
            params={},
            context=_make_context(),
        )
        produced = result[ArtifactType.RAW_TEXT]
        assert produced.id == "doc01:stub_vlm:raw_text"
        assert produced.produced_by_step == "vlm_transcription"

    def test_custom_transcription_prompt(self, tmp_path: Path) -> None:
        image_path = tmp_path / "doc01.png"
        image_path.write_bytes(b"x")
        adapter = _StubVLMAdapter(config={
            "max_retries": 0,
            "transcription_prompt": "Custom VLM prompt",
        })
        # On capture le prompt en surchargeant _call.
        captured = {}

        def _capture_call(prompt, image_b64=None):
            captured["prompt"] = prompt
            return "x"

        adapter._call = _capture_call  # type: ignore[method-assign]
        adapter.execute(
            inputs={ArtifactType.IMAGE: _make_image_artifact(str(image_path))},
            params={},
            context=_make_context(),
        )
        assert captured["prompt"] == "Custom VLM prompt"


# ──────────────────────────────────────────────────────────────────────
# Erreurs
# ──────────────────────────────────────────────────────────────────────


class TestVLMExecuteErrors:
    def test_missing_image_raises(self) -> None:
        adapter = _StubVLMAdapter()
        with pytest.raises(VLMAdapterError, match="IMAGE manquant"):
            adapter.execute(inputs={}, params={}, context=_make_context())

    def test_image_without_uri_raises(self) -> None:
        adapter = _StubVLMAdapter()
        artifact = Artifact(
            id="x",
            document_id="doc01",
            type=ArtifactType.IMAGE,
            uri=None,
        )
        with pytest.raises(VLMAdapterError, match="sans URI"):
            adapter.execute(
                inputs={ArtifactType.IMAGE: artifact},
                params={},
                context=_make_context(),
            )

    def test_image_path_not_existing_raises(self) -> None:
        adapter = _StubVLMAdapter()
        with pytest.raises(VLMAdapterError, match="introuvable"):
            adapter.execute(
                inputs={ArtifactType.IMAGE: _make_image_artifact(
                    "/nonexistent/img.png",
                )},
                params={},
                context=_make_context(),
            )

    def test_vlm_call_failing_raises(self, tmp_path: Path) -> None:
        image_path = tmp_path / "doc.png"
        image_path.write_bytes(b"x")
        adapter = _StubVLMAdapter(raise_on_call=True)
        with pytest.raises(VLMAdapterError, match="VLM a Γ©chouΓ©"):
            adapter.execute(
                inputs={ArtifactType.IMAGE: _make_image_artifact(str(image_path))},
                params={},
                context=_make_context(),
            )


# ──────────────────────────────────────────────────────────────────────
# Adapters concrets β€” hΓ©ritage MRO
# ──────────────────────────────────────────────────────────────────────


class TestConcreteVLMAdapters:
    @pytest.mark.parametrize("adapter_cls,expected_name", [
        (AnthropicVLMAdapter, "anthropic_vlm"),
        (OpenAIVLMAdapter, "openai_vlm"),
        (MistralVLMAdapter, "mistral_vlm"),
        (OllamaVLMAdapter, "ollama_vlm"),
    ])
    def test_adapter_name(self, adapter_cls, expected_name) -> None:
        adapter = adapter_cls()
        assert adapter.name == expected_name

    @pytest.mark.parametrize("adapter_cls", [
        AnthropicVLMAdapter,
        OpenAIVLMAdapter,
        MistralVLMAdapter,
        OllamaVLMAdapter,
    ])
    def test_adapter_input_types(self, adapter_cls) -> None:
        # input_types vient de BaseVLMAdapter par MRO.
        adapter = adapter_cls()
        assert adapter.input_types == frozenset({ArtifactType.IMAGE})

    @pytest.mark.parametrize("adapter_cls", [
        AnthropicVLMAdapter,
        OpenAIVLMAdapter,
        MistralVLMAdapter,
        OllamaVLMAdapter,
    ])
    def test_adapter_output_types(self, adapter_cls) -> None:
        adapter = adapter_cls()
        assert adapter.output_types == frozenset({ArtifactType.RAW_TEXT})

    @pytest.mark.parametrize("adapter_cls", [
        AnthropicVLMAdapter,
        OpenAIVLMAdapter,
        MistralVLMAdapter,
        OllamaVLMAdapter,
    ])
    def test_adapter_has_execute(self, adapter_cls) -> None:
        # execute() vient de BaseVLMAdapter par MRO.
        assert hasattr(adapter_cls, "execute")

    def test_mistral_default_model_is_pixtral(self) -> None:
        adapter = MistralVLMAdapter()
        assert "pixtral" in adapter.default_model.lower()

    def test_ollama_default_model_is_vision_capable(self) -> None:
        adapter = OllamaVLMAdapter()
        # ModΓ¨le par dΓ©faut doit Γͺtre un modΓ¨le vision (llava family).
        assert "llava" in adapter.default_model.lower()


# ──────────────────────────────────────────────────────────────────────
# IntΓ©gration pipeline (utilisation comme StepExecutor)
# ──────────────────────────────────────────────────────────────────────


class TestVLMPipelineIntegration:
    def test_used_as_pipeline_step(self, tmp_path: Path) -> None:
        from picarones.pipeline.executor import PipelineExecutor
        from picarones.domain.pipeline_spec import PipelineSpec, PipelineStep
        from picarones.domain.documents import DocumentRef

        image_path = tmp_path / "doc01.png"
        image_path.write_bytes(b"PNG_BYTES")

        adapter = _StubVLMAdapter(response_text="VLM transcription")
        executor = PipelineExecutor(adapter_resolver=lambda name: adapter)
        spec = PipelineSpec(
            name="vlm_pipeline",
            initial_inputs=(ArtifactType.IMAGE,),
            steps=(
                PipelineStep(
                    id="vlm",
                    kind="vlm_transcription",
                    adapter_name="stub_vlm",
                    input_types=(ArtifactType.IMAGE,),
                    output_types=(ArtifactType.RAW_TEXT,),
                ),
            ),
        )
        result = executor.run(
            spec=spec,
            document=DocumentRef(id="doc01"),
            initial_inputs={
                ArtifactType.IMAGE: _make_image_artifact(str(image_path)),
            },
            context=_make_context(),
        )
        assert result.succeeded
        raw_text_artifacts = [
            a for a in result.artifacts
            if a.type == ArtifactType.RAW_TEXT
        ]
        assert len(raw_text_artifacts) == 1
        out_path = Path(raw_text_artifacts[0].uri)
        assert out_path.read_text(encoding="utf-8") == "VLM transcription"